All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Joonsoo Kim <js1304@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Aaron Lu <aaron.lu@intel.com>, Mel Gorman <mgorman@suse.de>,
	Rik van Riel <riel@redhat.com>,
	David Rientjes <rientjes@google.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH v2 2/3] mm/compaction: pass only pageblock aligned range to pageblock_pfn_to_page
Date: Wed, 10 Feb 2016 13:52:08 +0100	[thread overview]
Message-ID: <56BB3278.3020907@suse.cz> (raw)
In-Reply-To: <1454566775-30973-2-git-send-email-iamjoonsoo.kim@lge.com>

On 02/04/2016 07:19 AM, Joonsoo Kim wrote:
> pageblock_pfn_to_page() is used to check there is valid pfn and all pages
> in the pageblock is in a single zone. If there is a hole in the pageblock,
> passing arbitrary position to pageblock_pfn_to_page() could cause to skip
> whole pageblock scanning, instead of just skipping the hole page. For
> deterministic behaviour, it's better to always pass pageblock aligned
> range to pageblock_pfn_to_page(). It will also help further optimization
> on pageblock_pfn_to_page() in the following patch.
> 
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Joonsoo Kim <js1304@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Aaron Lu <aaron.lu@intel.com>, Mel Gorman <mgorman@suse.de>,
	Rik van Riel <riel@redhat.com>,
	David Rientjes <rientjes@google.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH v2 2/3] mm/compaction: pass only pageblock aligned range to pageblock_pfn_to_page
Date: Wed, 10 Feb 2016 13:52:08 +0100	[thread overview]
Message-ID: <56BB3278.3020907@suse.cz> (raw)
In-Reply-To: <1454566775-30973-2-git-send-email-iamjoonsoo.kim@lge.com>

On 02/04/2016 07:19 AM, Joonsoo Kim wrote:
> pageblock_pfn_to_page() is used to check there is valid pfn and all pages
> in the pageblock is in a single zone. If there is a hole in the pageblock,
> passing arbitrary position to pageblock_pfn_to_page() could cause to skip
> whole pageblock scanning, instead of just skipping the hole page. For
> deterministic behaviour, it's better to always pass pageblock aligned
> range to pageblock_pfn_to_page(). It will also help further optimization
> on pageblock_pfn_to_page() in the following patch.
> 
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-02-10 12:52 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04  6:19 [PATCH v2 1/3] mm/compaction: fix invalid free_pfn and compact_cached_free_pfn Joonsoo Kim
2016-02-04  6:19 ` Joonsoo Kim
2016-02-04  6:19 ` [PATCH v2 2/3] mm/compaction: pass only pageblock aligned range to pageblock_pfn_to_page Joonsoo Kim
2016-02-04  6:19   ` Joonsoo Kim
2016-02-10 12:52   ` Vlastimil Babka [this message]
2016-02-10 12:52     ` Vlastimil Babka
2016-02-04  6:19 ` [PATCH v2 3/3] mm/compaction: speed up pageblock_pfn_to_page() when zone is contiguous Joonsoo Kim
2016-02-04  6:19   ` Joonsoo Kim
2016-02-05  0:49   ` Andrew Morton
2016-02-05  0:49     ` Andrew Morton
2016-02-05 16:11     ` Joonsoo Kim
2016-02-05 16:11       ` Joonsoo Kim
2016-02-09 17:58       ` Vlastimil Babka
2016-02-09 17:58         ` Vlastimil Babka
2016-02-09 20:53         ` Andrew Morton
2016-02-09 20:53           ` Andrew Morton
2016-02-10 13:42           ` Vlastimil Babka
2016-02-10 13:42             ` Vlastimil Babka
2016-02-10 18:58             ` Andrew Morton
2016-02-10 18:58               ` Andrew Morton
2016-02-11  1:58               ` Joonsoo Kim
2016-02-11  1:58                 ` Joonsoo Kim
2016-02-14 10:21       ` zhong jiang
2016-02-14 10:21         ` zhong jiang
2016-02-15  2:42         ` Joonsoo Kim
2016-02-15  2:42           ` Joonsoo Kim
2016-02-15 10:06           ` Xishi Qiu
2016-02-15 10:06             ` Xishi Qiu
2016-02-15 14:24             ` Joonsoo Kim
2016-02-15 14:24               ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BB3278.3020907@suse.cz \
    --to=vbabka@suse.cz \
    --cc=aaron.lu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=js1304@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.