* [PATCH] efifb: Don't show the mapping VA
@ 2016-05-11 23:57 ` Andy Lutomirski
0 siblings, 0 replies; 6+ messages in thread
From: Andy Lutomirski @ 2016-05-11 23:57 UTC (permalink / raw)
To: Peter Jones, Jean-Christophe Plagniol-Villard
Cc: Andy Lutomirski, Tomi Valkeinen, linux-fbdev, linux-kernel
The framebuffer mapping virtual address leaks information about the
kernel memory layout. Stop logging it.
Cc: Peter Jones <pjones@redhat.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-fbdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
drivers/video/fbdev/efifb.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
index 95d293b7445a..3dcaf4e82885 100644
--- a/drivers/video/fbdev/efifb.c
+++ b/drivers/video/fbdev/efifb.c
@@ -247,10 +247,8 @@ static int efifb_probe(struct platform_device *dev)
goto err_release_fb;
}
- printk(KERN_INFO "efifb: framebuffer at 0x%lx, mapped to 0x%p, "
- "using %dk, total %dk\n",
- efifb_fix.smem_start, info->screen_base,
- size_remap/1024, size_total/1024);
+ printk(KERN_INFO "efifb: framebuffer at 0x%lx, using %dk, total %dk\n",
+ efifb_fix.smem_start, size_remap/1024, size_total/1024);
printk(KERN_INFO "efifb: mode is %dx%dx%d, linelength=%d, pages=%d\n",
efifb_defined.xres, efifb_defined.yres,
efifb_defined.bits_per_pixel, efifb_fix.line_length,
--
2.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] efifb: Don't show the mapping VA
@ 2016-05-11 23:57 ` Andy Lutomirski
0 siblings, 0 replies; 6+ messages in thread
From: Andy Lutomirski @ 2016-05-11 23:57 UTC (permalink / raw)
To: Peter Jones, Jean-Christophe Plagniol-Villard
Cc: Andy Lutomirski, Tomi Valkeinen, linux-fbdev, linux-kernel
The framebuffer mapping virtual address leaks information about the
kernel memory layout. Stop logging it.
Cc: Peter Jones <pjones@redhat.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-fbdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
drivers/video/fbdev/efifb.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
index 95d293b7445a..3dcaf4e82885 100644
--- a/drivers/video/fbdev/efifb.c
+++ b/drivers/video/fbdev/efifb.c
@@ -247,10 +247,8 @@ static int efifb_probe(struct platform_device *dev)
goto err_release_fb;
}
- printk(KERN_INFO "efifb: framebuffer at 0x%lx, mapped to 0x%p, "
- "using %dk, total %dk\n",
- efifb_fix.smem_start, info->screen_base,
- size_remap/1024, size_total/1024);
+ printk(KERN_INFO "efifb: framebuffer at 0x%lx, using %dk, total %dk\n",
+ efifb_fix.smem_start, size_remap/1024, size_total/1024);
printk(KERN_INFO "efifb: mode is %dx%dx%d, linelength=%d, pages=%d\n",
efifb_defined.xres, efifb_defined.yres,
efifb_defined.bits_per_pixel, efifb_fix.line_length,
--
2.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] efifb: Don't show the mapping VA
2016-05-11 23:57 ` Andy Lutomirski
@ 2016-05-12 20:19 ` Peter Jones
-1 siblings, 0 replies; 6+ messages in thread
From: Peter Jones @ 2016-05-12 20:19 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, linux-fbdev,
linux-kernel, Matt Fleming
On Wed, May 11, 2016 at 04:57:47PM -0700, Andy Lutomirski wrote:
> The framebuffer mapping virtual address leaks information about the
> kernel memory layout. Stop logging it.
>
> Cc: Peter Jones <pjones@redhat.com>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
In practice it also hasn't ever helped any actual debugging.
Signed-off-by: Peter Jones <pjones@redhat.com>
> ---
> drivers/video/fbdev/efifb.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
> index 95d293b7445a..3dcaf4e82885 100644
> --- a/drivers/video/fbdev/efifb.c
> +++ b/drivers/video/fbdev/efifb.c
> @@ -247,10 +247,8 @@ static int efifb_probe(struct platform_device *dev)
> goto err_release_fb;
> }
>
> - printk(KERN_INFO "efifb: framebuffer at 0x%lx, mapped to 0x%p, "
> - "using %dk, total %dk\n",
> - efifb_fix.smem_start, info->screen_base,
> - size_remap/1024, size_total/1024);
> + printk(KERN_INFO "efifb: framebuffer at 0x%lx, using %dk, total %dk\n",
> + efifb_fix.smem_start, size_remap/1024, size_total/1024);
> printk(KERN_INFO "efifb: mode is %dx%dx%d, linelength=%d, pages=%d\n",
> efifb_defined.xres, efifb_defined.yres,
> efifb_defined.bits_per_pixel, efifb_fix.line_length,
> --
> 2.5.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Peter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] efifb: Don't show the mapping VA
@ 2016-05-12 20:19 ` Peter Jones
0 siblings, 0 replies; 6+ messages in thread
From: Peter Jones @ 2016-05-12 20:19 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, linux-fbdev,
linux-kernel, Matt Fleming
On Wed, May 11, 2016 at 04:57:47PM -0700, Andy Lutomirski wrote:
> The framebuffer mapping virtual address leaks information about the
> kernel memory layout. Stop logging it.
>
> Cc: Peter Jones <pjones@redhat.com>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
In practice it also hasn't ever helped any actual debugging.
Signed-off-by: Peter Jones <pjones@redhat.com>
> ---
> drivers/video/fbdev/efifb.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
> index 95d293b7445a..3dcaf4e82885 100644
> --- a/drivers/video/fbdev/efifb.c
> +++ b/drivers/video/fbdev/efifb.c
> @@ -247,10 +247,8 @@ static int efifb_probe(struct platform_device *dev)
> goto err_release_fb;
> }
>
> - printk(KERN_INFO "efifb: framebuffer at 0x%lx, mapped to 0x%p, "
> - "using %dk, total %dk\n",
> - efifb_fix.smem_start, info->screen_base,
> - size_remap/1024, size_total/1024);
> + printk(KERN_INFO "efifb: framebuffer at 0x%lx, using %dk, total %dk\n",
> + efifb_fix.smem_start, size_remap/1024, size_total/1024);
> printk(KERN_INFO "efifb: mode is %dx%dx%d, linelength=%d, pages=%d\n",
> efifb_defined.xres, efifb_defined.yres,
> efifb_defined.bits_per_pixel, efifb_fix.line_length,
> --
> 2.5.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Peter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] efifb: Don't show the mapping VA
2016-05-11 23:57 ` Andy Lutomirski
@ 2016-05-13 11:43 ` Tomi Valkeinen
-1 siblings, 0 replies; 6+ messages in thread
From: Tomi Valkeinen @ 2016-05-13 11:43 UTC (permalink / raw)
To: Andy Lutomirski, Peter Jones, Jean-Christophe Plagniol-Villard
Cc: linux-fbdev, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1434 bytes --]
On 12/05/16 02:57, Andy Lutomirski wrote:
> The framebuffer mapping virtual address leaks information about the
> kernel memory layout. Stop logging it.
>
> Cc: Peter Jones <pjones@redhat.com>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
> drivers/video/fbdev/efifb.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
> index 95d293b7445a..3dcaf4e82885 100644
> --- a/drivers/video/fbdev/efifb.c
> +++ b/drivers/video/fbdev/efifb.c
> @@ -247,10 +247,8 @@ static int efifb_probe(struct platform_device *dev)
> goto err_release_fb;
> }
>
> - printk(KERN_INFO "efifb: framebuffer at 0x%lx, mapped to 0x%p, "
> - "using %dk, total %dk\n",
> - efifb_fix.smem_start, info->screen_base,
> - size_remap/1024, size_total/1024);
> + printk(KERN_INFO "efifb: framebuffer at 0x%lx, using %dk, total %dk\n",
> + efifb_fix.smem_start, size_remap/1024, size_total/1024);
> printk(KERN_INFO "efifb: mode is %dx%dx%d, linelength=%d, pages=%d\n",
> efifb_defined.xres, efifb_defined.yres,
> efifb_defined.bits_per_pixel, efifb_fix.line_length,
>
Thanks, queued for 4.7.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] efifb: Don't show the mapping VA
@ 2016-05-13 11:43 ` Tomi Valkeinen
0 siblings, 0 replies; 6+ messages in thread
From: Tomi Valkeinen @ 2016-05-13 11:43 UTC (permalink / raw)
To: Andy Lutomirski, Peter Jones, Jean-Christophe Plagniol-Villard
Cc: linux-fbdev, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1434 bytes --]
On 12/05/16 02:57, Andy Lutomirski wrote:
> The framebuffer mapping virtual address leaks information about the
> kernel memory layout. Stop logging it.
>
> Cc: Peter Jones <pjones@redhat.com>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
> drivers/video/fbdev/efifb.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
> index 95d293b7445a..3dcaf4e82885 100644
> --- a/drivers/video/fbdev/efifb.c
> +++ b/drivers/video/fbdev/efifb.c
> @@ -247,10 +247,8 @@ static int efifb_probe(struct platform_device *dev)
> goto err_release_fb;
> }
>
> - printk(KERN_INFO "efifb: framebuffer at 0x%lx, mapped to 0x%p, "
> - "using %dk, total %dk\n",
> - efifb_fix.smem_start, info->screen_base,
> - size_remap/1024, size_total/1024);
> + printk(KERN_INFO "efifb: framebuffer at 0x%lx, using %dk, total %dk\n",
> + efifb_fix.smem_start, size_remap/1024, size_total/1024);
> printk(KERN_INFO "efifb: mode is %dx%dx%d, linelength=%d, pages=%d\n",
> efifb_defined.xres, efifb_defined.yres,
> efifb_defined.bits_per_pixel, efifb_fix.line_length,
>
Thanks, queued for 4.7.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-05-13 11:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-11 23:57 [PATCH] efifb: Don't show the mapping VA Andy Lutomirski
2016-05-11 23:57 ` Andy Lutomirski
2016-05-12 20:19 ` Peter Jones
2016-05-12 20:19 ` Peter Jones
2016-05-13 11:43 ` Tomi Valkeinen
2016-05-13 11:43 ` Tomi Valkeinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.