All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kulkarni, Vandita" <vandita.kulkarni@intel.com>
To: "Shankar, Uma" <uma.shankar@intel.com>,
	"Deak, Imre" <imre.deak@intel.com>
Cc: "Nikula, Jani" <jani.nikula@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/i915/icl/dsi: Fix port disable sequence
Date: Thu, 21 Mar 2019 13:57:03 +0000	[thread overview]
Message-ID: <57510F3E2013164E925CD03ED7512A3B7FEAF9A8@BGSMSX110.gar.corp.intel.com> (raw)
In-Reply-To: <E7C9878FBA1C6D42A1CA3F62AEB6945F81F8A62C@BGSMSX104.gar.corp.intel.com>



> -----Original Message-----
> From: Shankar, Uma
> Sent: Wednesday, March 20, 2019 5:32 PM
> To: Deak, Imre <imre.deak@intel.com>; Kulkarni, Vandita
> <vandita.kulkarni@intel.com>
> Cc: Nikula, Jani <jani.nikula@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: RE: [Intel-gfx] [PATCH 2/2] drm/i915/icl/dsi: Fix port disable sequence
> 
> 
> 
> >-----Original Message-----
> >From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On
> >Behalf Of Imre Deak
> >Sent: Wednesday, March 20, 2019 4:38 PM
> >To: Kulkarni, Vandita <vandita.kulkarni@intel.com>
> >Cc: Nikula, Jani <jani.nikula@intel.com>;
> >intel-gfx@lists.freedesktop.org
> >Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/icl/dsi: Fix port disable
> >sequence
> 
> You can drop the dsi from drm/i915/icl/. Add at description or commit header.
> Like
> drm/i915/icl: Fix DSI port disable sequence
Okay. 
> 
> >
> >On Wed, Mar 20, 2019 at 03:38:59PM +0530, Vandita Kulkarni wrote:
> >> Re-enable clock gating of DDI clocks.
> >>
> >> Fixes: 1026bea00381 (drm/i915/icl: Ungate DSI clocks)
> >> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
> >> ---
> >>  drivers/gpu/drm/i915/icl_dsi.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/icl_dsi.c
> >> b/drivers/gpu/drm/i915/icl_dsi.c index f02504d..716be38 100644
> >> --- a/drivers/gpu/drm/i915/icl_dsi.c
> >> +++ b/drivers/gpu/drm/i915/icl_dsi.c
> >> @@ -1125,7 +1125,7 @@ static void gen11_dsi_disable_port(struct
> >> intel_encoder
> >*encoder)
> >>  			DRM_ERROR("DDI port:%c buffer not idle\n",
> >>  				  port_name(port));
> >>  	}
> >> -	gen11_dsi_ungate_clocks(encoder);
> >> +	gen11_dsi_gate_clocks(encoder);
> >
> >This also requires updating icl_sanitize_encoder_pll_mapping().
> >Currently it assumes that the DDI clock needs to be ungated if the
> >corresponding DSI port is disabled and gated if the port is enabled.
> >
> >The changes in this patchset mean that the DDI clock should be gated
> >for DSI ports regardless of whether the port is enabled or not.
> 
> I agree. This change look fine, but there is an issue there with
> icl_sanitize_encoder_pll_mapping.

Thank you. Will send the fix in V2.
-Vandita
> 
> >>  }
> >>
> >>  static void gen11_dsi_disable_io_power(struct intel_encoder
> >> *encoder)
> >> --
> >> 1.9.1
> >>
> >> _______________________________________________
> >> Intel-gfx mailing list
> >> Intel-gfx@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >_______________________________________________
> >Intel-gfx mailing list
> >Intel-gfx@lists.freedesktop.org
> >https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-03-21 13:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 10:08 [PATCH 1/2] drm/i915/icl/dsi: Ungate clocks if gated Vandita Kulkarni
2019-03-20 10:08 ` [PATCH 2/2] drm/i915/icl/dsi: Fix port disable sequence Vandita Kulkarni
2019-03-20 11:07   ` Imre Deak
2019-03-20 12:02     ` Shankar, Uma
2019-03-21 13:57       ` Kulkarni, Vandita [this message]
2019-03-21 13:56     ` Kulkarni, Vandita
2019-03-20 11:49 ` [PATCH 1/2] drm/i915/icl/dsi: Ungate clocks if gated Shankar, Uma
2019-03-21 13:53   ` Kulkarni, Vandita
2019-03-22  7:48     ` Kulkarni, Vandita
2019-03-22  8:18       ` Shankar, Uma
2019-03-20 14:28 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2019-03-20 19:01 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57510F3E2013164E925CD03ED7512A3B7FEAF9A8@BGSMSX110.gar.corp.intel.com \
    --to=vandita.kulkarni@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.