* [f2fs-dev] [PATCH -next] f2fs: Revert "f2fs: Fix indefinite loop in f2fs_gc() v1"
@ 2021-07-14 7:46 Jia Yang
2021-07-17 7:45 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Jia Yang @ 2021-07-14 7:46 UTC (permalink / raw)
To: linux-f2fs-devel; +Cc: jaegeuk
This reverts commit 957fa47823dfe449c5a15a944e4e7a299a6601db.
The patch "f2fs: Fix indefinite loop in f2fs_gc()" v1 and v4 are all
merged. Patch v4 is test info for patch v1. Patch v1 doesn't work and
may cause that sbi->cur_victim_sec can't be resetted to NULL_SEGNO,
which makes SSR unable to get segment of sbi->cur_victim_sec.
So it should be reverted.
The mails record:
[1] https://lore.kernel.org/linux-f2fs-devel/7288dcd4-b168-7656-d1af-7e2cafa4f720@huawei.com/T/
[2] https://lore.kernel.org/linux-f2fs-devel/20190809153653.GD93481@jaegeuk-macbookpro.roam.corp.google.com/T/
Signed-off-by: Jia Yang <jiayang5@huawei.com>
---
fs/f2fs/gc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 0e42ee5f7770..396b6f55ec24 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -1747,7 +1747,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync,
round++;
}
- if (gc_type == FG_GC && seg_freed)
+ if (gc_type == FG_GC)
sbi->cur_victim_sec = NULL_SEGNO;
if (sync)
--
2.25.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [f2fs-dev] [PATCH -next] f2fs: Revert "f2fs: Fix indefinite loop in f2fs_gc() v1"
2021-07-14 7:46 [f2fs-dev] [PATCH -next] f2fs: Revert "f2fs: Fix indefinite loop in f2fs_gc() v1" Jia Yang
@ 2021-07-17 7:45 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2021-07-17 7:45 UTC (permalink / raw)
To: Jia Yang, linux-f2fs-devel; +Cc: jaegeuk
+Cc Sahitya Tummala <stummala@codeaurora.org>
On 2021/7/14 15:46, Jia Yang wrote:
> This reverts commit 957fa47823dfe449c5a15a944e4e7a299a6601db.
>
> The patch "f2fs: Fix indefinite loop in f2fs_gc()" v1 and v4 are all
> merged. Patch v4 is test info for patch v1. Patch v1 doesn't work and
> may cause that sbi->cur_victim_sec can't be resetted to NULL_SEGNO,
> which makes SSR unable to get segment of sbi->cur_victim_sec.
> So it should be reverted.
>
> The mails record:
> [1] https://lore.kernel.org/linux-f2fs-devel/7288dcd4-b168-7656-d1af-7e2cafa4f720@huawei.com/T/
> [2] https://lore.kernel.org/linux-f2fs-devel/20190809153653.GD93481@jaegeuk-macbookpro.roam.corp.google.com/T/
>
> Signed-off-by: Jia Yang <jiayang5@huawei.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-17 7:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-14 7:46 [f2fs-dev] [PATCH -next] f2fs: Revert "f2fs: Fix indefinite loop in f2fs_gc() v1" Jia Yang
2021-07-17 7:45 ` Chao Yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.