* [PATCH] drm/amdgpu: fix vm pte pde flags to 64-bit for sdma v4
@ 2017-03-28 8:55 Junwei Zhang
[not found] ` <1490691347-29590-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Junwei Zhang @ 2017-03-28 8:55 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Junwei Zhang
Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com>
---
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
index dcbef50..6cfb100 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
@@ -968,8 +968,8 @@ static void sdma_v4_0_vm_set_pte_pde(struct amdgpu_ib *ib,
ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_PTEPDE);
ib->ptr[ib->length_dw++] = lower_32_bits(pe); /* dst addr */
ib->ptr[ib->length_dw++] = upper_32_bits(pe);
- ib->ptr[ib->length_dw++] = flags; /* mask */
- ib->ptr[ib->length_dw++] = 0;
+ ib->ptr[ib->length_dw++] = lower_32_bits(flags); /* mask */
+ ib->ptr[ib->length_dw++] = upper_32_bits(flags);
ib->ptr[ib->length_dw++] = lower_32_bits(addr); /* value */
ib->ptr[ib->length_dw++] = upper_32_bits(addr);
ib->ptr[ib->length_dw++] = incr; /* increment size */
--
1.9.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <1490691347-29590-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH] drm/amdgpu: fix vm pte pde flags to 64-bit for sdma v4 [not found] ` <1490691347-29590-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> @ 2017-03-28 10:06 ` Christian König [not found] ` <0a8d9c5c-5ee5-7c86-be40-9c0fa4bc1a8a-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> 2017-03-28 15:09 ` Deucher, Alexander 1 sibling, 1 reply; 4+ messages in thread From: Christian König @ 2017-03-28 10:06 UTC (permalink / raw) To: Junwei Zhang, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Am 28.03.2017 um 10:55 schrieb Junwei Zhang: > Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com> Good catch, patch is Reviewed-by: Christian König <christian.koenig@amd.com>. It doesn't matter for older versions because they don't have flags in the high bits, but just for completeness could you fix this for them as well? Thanks, Christian. > --- > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > index dcbef50..6cfb100 100644 > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > @@ -968,8 +968,8 @@ static void sdma_v4_0_vm_set_pte_pde(struct amdgpu_ib *ib, > ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_PTEPDE); > ib->ptr[ib->length_dw++] = lower_32_bits(pe); /* dst addr */ > ib->ptr[ib->length_dw++] = upper_32_bits(pe); > - ib->ptr[ib->length_dw++] = flags; /* mask */ > - ib->ptr[ib->length_dw++] = 0; > + ib->ptr[ib->length_dw++] = lower_32_bits(flags); /* mask */ > + ib->ptr[ib->length_dw++] = upper_32_bits(flags); > ib->ptr[ib->length_dw++] = lower_32_bits(addr); /* value */ > ib->ptr[ib->length_dw++] = upper_32_bits(addr); > ib->ptr[ib->length_dw++] = incr; /* increment size */ _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <0a8d9c5c-5ee5-7c86-be40-9c0fa4bc1a8a-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>]
* Re: [PATCH] drm/amdgpu: fix vm pte pde flags to 64-bit for sdma v4 [not found] ` <0a8d9c5c-5ee5-7c86-be40-9c0fa4bc1a8a-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> @ 2017-03-29 7:21 ` Zhang, Jerry (Junwei) 0 siblings, 0 replies; 4+ messages in thread From: Zhang, Jerry (Junwei) @ 2017-03-29 7:21 UTC (permalink / raw) To: Christian König, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On 03/28/2017 06:06 PM, Christian König wrote: > Am 28.03.2017 um 10:55 schrieb Junwei Zhang: >> Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com> > > Good catch, patch is Reviewed-by: Christian König <christian.koenig@amd.com>. > > It doesn't matter for older versions because they don't have flags in the high > bits, but just for completeness could you fix this for them as well? Yeah, just focused on Vega10 yesterday, neglecting others. please check it in another mail. Jerry > > Thanks, > Christian. > >> --- >> drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c >> b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c >> index dcbef50..6cfb100 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c >> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c >> @@ -968,8 +968,8 @@ static void sdma_v4_0_vm_set_pte_pde(struct amdgpu_ib *ib, >> ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_PTEPDE); >> ib->ptr[ib->length_dw++] = lower_32_bits(pe); /* dst addr */ >> ib->ptr[ib->length_dw++] = upper_32_bits(pe); >> - ib->ptr[ib->length_dw++] = flags; /* mask */ >> - ib->ptr[ib->length_dw++] = 0; >> + ib->ptr[ib->length_dw++] = lower_32_bits(flags); /* mask */ >> + ib->ptr[ib->length_dw++] = upper_32_bits(flags); >> ib->ptr[ib->length_dw++] = lower_32_bits(addr); /* value */ >> ib->ptr[ib->length_dw++] = upper_32_bits(addr); >> ib->ptr[ib->length_dw++] = incr; /* increment size */ > > _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] drm/amdgpu: fix vm pte pde flags to 64-bit for sdma v4 [not found] ` <1490691347-29590-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> 2017-03-28 10:06 ` Christian König @ 2017-03-28 15:09 ` Deucher, Alexander 1 sibling, 0 replies; 4+ messages in thread From: Deucher, Alexander @ 2017-03-28 15:09 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Zhang, Jerry > -----Original Message----- > From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf > Of Junwei Zhang > Sent: Tuesday, March 28, 2017 4:56 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Jerry > Subject: [PATCH] drm/amdgpu: fix vm pte pde flags to 64-bit for sdma v4 > > Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > index dcbef50..6cfb100 100644 > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > @@ -968,8 +968,8 @@ static void sdma_v4_0_vm_set_pte_pde(struct > amdgpu_ib *ib, > ib->ptr[ib->length_dw++] = > SDMA_PKT_HEADER_OP(SDMA_OP_PTEPDE); > ib->ptr[ib->length_dw++] = lower_32_bits(pe); /* dst addr */ > ib->ptr[ib->length_dw++] = upper_32_bits(pe); > - ib->ptr[ib->length_dw++] = flags; /* mask */ > - ib->ptr[ib->length_dw++] = 0; > + ib->ptr[ib->length_dw++] = lower_32_bits(flags); /* mask */ > + ib->ptr[ib->length_dw++] = upper_32_bits(flags); > ib->ptr[ib->length_dw++] = lower_32_bits(addr); /* value */ > ib->ptr[ib->length_dw++] = upper_32_bits(addr); > ib->ptr[ib->length_dw++] = incr; /* increment size */ > -- > 1.9.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-29 7:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-28 8:55 [PATCH] drm/amdgpu: fix vm pte pde flags to 64-bit for sdma v4 Junwei Zhang
[not found] ` <1490691347-29590-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
2017-03-28 10:06 ` Christian König
[not found] ` <0a8d9c5c-5ee5-7c86-be40-9c0fa4bc1a8a-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-03-29 7:21 ` Zhang, Jerry (Junwei)
2017-03-28 15:09 ` Deucher, Alexander
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.