* [Outreachy Kernel][PATCH] staging: comedi: comedi_pci.h: prefer a maximum 75 chars per line
@ 2018-10-05 12:57 Bhanusree Pola
2018-10-05 17:56 ` [Outreachy kernel] " Himanshu Jha
0 siblings, 1 reply; 2+ messages in thread
From: Bhanusree Pola @ 2018-10-05 12:57 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
comedi_pci_auto_config() function prototype is exceeding more than 75 characters per line.
Adjusted to less than 75 characters to improve readability.
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
---
drivers/staging/comedi/comedi_pci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h
index 4e06944..5cb7cd7 100644
--- a/drivers/staging/comedi/comedi_pci.h
+++ b/drivers/staging/comedi/comedi_pci.h
@@ -31,8 +31,8 @@ int comedi_pci_enable(struct comedi_device *dev);
void comedi_pci_disable(struct comedi_device *dev);
void comedi_pci_detach(struct comedi_device *dev);
-int comedi_pci_auto_config(struct pci_dev *pcidev, struct comedi_driver *driver,
- unsigned long context);
+int comedi_pci_auto_config(struct pci_dev *pcidev,
+ struct comedi_driver *driver,unsigned long context);
void comedi_pci_auto_unconfig(struct pci_dev *pcidev);
int comedi_pci_driver_register(struct comedi_driver *comedi_driver,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [Outreachy Kernel][PATCH] staging: comedi: comedi_pci.h: prefer a maximum 75 chars per line
2018-10-05 12:57 [Outreachy Kernel][PATCH] staging: comedi: comedi_pci.h: prefer a maximum 75 chars per line Bhanusree Pola
@ 2018-10-05 17:56 ` Himanshu Jha
0 siblings, 0 replies; 2+ messages in thread
From: Himanshu Jha @ 2018-10-05 17:56 UTC (permalink / raw)
To: Bhanusree Pola; +Cc: gregkh, outreachy-kernel
On Fri, Oct 05, 2018 at 06:27:18PM +0530, Bhanusree Pola wrote:
> comedi_pci_auto_config() function prototype is exceeding more than 75 characters per line.
Run checkpatch on your generated patch too before sending.
Wrap commit log to 75 characters as well.
> Adjusted to less than 75 characters to improve readability.
>
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
Send new verion with a changelog here.
> drivers/staging/comedi/comedi_pci.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h
> index 4e06944..5cb7cd7 100644
> --- a/drivers/staging/comedi/comedi_pci.h
> +++ b/drivers/staging/comedi/comedi_pci.h
> @@ -31,8 +31,8 @@ int comedi_pci_enable(struct comedi_device *dev);
> void comedi_pci_disable(struct comedi_device *dev);
> void comedi_pci_detach(struct comedi_device *dev);
>
> -int comedi_pci_auto_config(struct pci_dev *pcidev, struct comedi_driver *driver,
> - unsigned long context);
> +int comedi_pci_auto_config(struct pci_dev *pcidev,
> + struct comedi_driver *driver,unsigned long context);
No! Adjust arguments to match open parentheses.
Something like the following:
int comedi_pci_auto_config(struct pci_dev *pcidev,
struct comedi_driver *driver,unsigned long context);
--
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-05 17:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-05 12:57 [Outreachy Kernel][PATCH] staging: comedi: comedi_pci.h: prefer a maximum 75 chars per line Bhanusree Pola
2018-10-05 17:56 ` [Outreachy kernel] " Himanshu Jha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.