All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Documentation/media: Remove incorrect statement
@ 2022-04-22  7:50 Dorota Czaplejewicz
  2022-04-28  6:50 ` Hans Verkuil
  0 siblings, 1 reply; 2+ messages in thread
From: Dorota Czaplejewicz @ 2022-04-22  7:50 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, linux-media, linux-kernel, kernel

[-- Attachment #1: Type: text/plain, Size: 1346 bytes --]

Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
---
Hi,

I tried to debug streaming in libcamera, where I stumbled upon this. I asked around on IRC where I was told that this statement in the documentation is wrong, so I'm submitting a removal.

Cheers,
Dorota Czaplejewicz

 Documentation/userspace-api/media/v4l/vidioc-streamon.rst | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/userspace-api/media/v4l/vidioc-streamon.rst b/Documentation/userspace-api/media/v4l/vidioc-streamon.rst
index 0bc86f06947b..1a79313a29fa 100644
--- a/Documentation/userspace-api/media/v4l/vidioc-streamon.rst
+++ b/Documentation/userspace-api/media/v4l/vidioc-streamon.rst
@@ -43,8 +43,7 @@ the capture or output process during streaming
 Capture hardware is disabled and no input buffers are filled (if there
 are any empty buffers in the incoming queue) until ``VIDIOC_STREAMON``
 has been called. Output hardware is disabled and no video signal is
-produced until ``VIDIOC_STREAMON`` has been called. The ioctl will
-succeed when at least one output buffer is in the incoming queue.
+produced until ``VIDIOC_STREAMON`` has been called.
 
 Memory-to-memory devices will not start until ``VIDIOC_STREAMON`` has
 been called for both the capture and output stream types.
-- 
2.34.1


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Documentation/media: Remove incorrect statement
  2022-04-22  7:50 [PATCH] Documentation/media: Remove incorrect statement Dorota Czaplejewicz
@ 2022-04-28  6:50 ` Hans Verkuil
  0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2022-04-28  6:50 UTC (permalink / raw)
  To: Dorota Czaplejewicz, Mauro Carvalho Chehab, linux-media,
	linux-kernel, kernel

Hi Dorota,

On 22/04/2022 09:50, Dorota Czaplejewicz wrote:
> Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
> ---
> Hi,
> 
> I tried to debug streaming in libcamera, where I stumbled upon this. I asked around on IRC where I was told that this statement in the documentation is wrong, so I'm submitting a removal.

For future reference: a patch needs to start with a commit message,
followed by your Signed-off-by, then '---' and the patch itself.

I've taking the paragraph above as the commit message, so no need for
you to do anything here.

Regards,

	Hans

> 
> Cheers,
> Dorota Czaplejewicz
> 
>  Documentation/userspace-api/media/v4l/vidioc-streamon.rst | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Documentation/userspace-api/media/v4l/vidioc-streamon.rst b/Documentation/userspace-api/media/v4l/vidioc-streamon.rst
> index 0bc86f06947b..1a79313a29fa 100644
> --- a/Documentation/userspace-api/media/v4l/vidioc-streamon.rst
> +++ b/Documentation/userspace-api/media/v4l/vidioc-streamon.rst
> @@ -43,8 +43,7 @@ the capture or output process during streaming
>  Capture hardware is disabled and no input buffers are filled (if there
>  are any empty buffers in the incoming queue) until ``VIDIOC_STREAMON``
>  has been called. Output hardware is disabled and no video signal is
> -produced until ``VIDIOC_STREAMON`` has been called. The ioctl will
> -succeed when at least one output buffer is in the incoming queue.
> +produced until ``VIDIOC_STREAMON`` has been called.
>  
>  Memory-to-memory devices will not start until ``VIDIOC_STREAMON`` has
>  been called for both the capture and output stream types.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-28  6:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-22  7:50 [PATCH] Documentation/media: Remove incorrect statement Dorota Czaplejewicz
2022-04-28  6:50 ` Hans Verkuil

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.