* [PATCH] image.h: use uint32_t instead of u32 in android_image_get_dtb*
@ 2020-02-17 10:23 Eugeniu Rosca
2020-02-18 17:41 ` Masahiro Yamada
2020-02-20 11:45 ` Sam Protsenko
0 siblings, 2 replies; 5+ messages in thread
From: Eugeniu Rosca @ 2020-02-17 10:23 UTC (permalink / raw)
To: u-boot
Replace 'u32' by 'uint32_t' in image.h, since the former may lead to
build failures in U-Boot tooling (see [1]).
Avoid using 'uint', since it is not a fixed-width type [2], potentially
leading to a dangerous mismatch between the prototypes and definitions
of the android_image_get_dtb* functions.
This should be the quickest way to overcome the tooling build failure,
with more future-proof solutions being proposed by Yamada-san in [1].
[1] https://patchwork.ozlabs.org/patch/1238245/
[2] Excerpt from https://en.cppreference.com/w/cpp/language/types
-----------8<------------
Type specifier Width in bits by data model
LP32 ILP32 LLP64 LP64
unsigned int 16 32 32 32
-----------8<------------
Cc: Tom Rini <trini@konsulko.com>
Cc: Sam Protsenko <joe.skb7@gmail.com>
Fixes: 7f2531502c74c0 ("image: android: Add routine to get dtbo params")
Fixes: c3bfad825a71ea ("image: android: Add functions for handling dtb field")
Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
---
include/image.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/image.h b/include/image.h
index b316d167d8d7..1341fbed62ba 100644
--- a/include/image.h
+++ b/include/image.h
@@ -1425,9 +1425,9 @@ int android_image_get_ramdisk(const struct andr_img_hdr *hdr,
ulong *rd_data, ulong *rd_len);
int android_image_get_second(const struct andr_img_hdr *hdr,
ulong *second_data, ulong *second_len);
-bool android_image_get_dtbo(ulong hdr_addr, ulong *addr, u32 *size);
-bool android_image_get_dtb_by_index(ulong hdr_addr, u32 index, ulong *addr,
- u32 *size);
+bool android_image_get_dtbo(ulong hdr_addr, ulong *addr, uint32_t *size);
+bool android_image_get_dtb_by_index(ulong hdr_addr, uint32_t index, ulong *addr,
+ uint32_t *size);
ulong android_image_get_end(const struct andr_img_hdr *hdr);
ulong android_image_get_kload(const struct andr_img_hdr *hdr);
ulong android_image_get_kcomp(const struct andr_img_hdr *hdr);
--
2.25.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] image.h: use uint32_t instead of u32 in android_image_get_dtb*
2020-02-17 10:23 [PATCH] image.h: use uint32_t instead of u32 in android_image_get_dtb* Eugeniu Rosca
@ 2020-02-18 17:41 ` Masahiro Yamada
2020-02-20 11:45 ` Sam Protsenko
1 sibling, 0 replies; 5+ messages in thread
From: Masahiro Yamada @ 2020-02-18 17:41 UTC (permalink / raw)
To: u-boot
On Mon, Feb 17, 2020 at 7:24 PM Eugeniu Rosca <erosca@de.adit-jv.com> wrote:
>
> Replace 'u32' by 'uint32_t' in image.h, since the former may lead to
> build failures in U-Boot tooling (see [1]).
>
> Avoid using 'uint', since it is not a fixed-width type [2], potentially
> leading to a dangerous mismatch between the prototypes and definitions
> of the android_image_get_dtb* functions.
>
> This should be the quickest way to overcome the tooling build failure,
> with more future-proof solutions being proposed by Yamada-san in [1].
>
> [1] https://patchwork.ozlabs.org/patch/1238245/
> [2] Excerpt from https://en.cppreference.com/w/cpp/language/types
> -----------8<------------
> Type specifier Width in bits by data model
> LP32 ILP32 LLP64 LP64
> unsigned int 16 32 32 32
> -----------8<------------
>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Sam Protsenko <joe.skb7@gmail.com>
> Fixes: 7f2531502c74c0 ("image: android: Add routine to get dtbo params")
> Fixes: c3bfad825a71ea ("image: android: Add functions for handling dtb field")
> Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> ---
Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] image.h: use uint32_t instead of u32 in android_image_get_dtb*
2020-02-17 10:23 [PATCH] image.h: use uint32_t instead of u32 in android_image_get_dtb* Eugeniu Rosca
2020-02-18 17:41 ` Masahiro Yamada
@ 2020-02-20 11:45 ` Sam Protsenko
2020-03-01 20:57 ` Heinrich Schuchardt
1 sibling, 1 reply; 5+ messages in thread
From: Sam Protsenko @ 2020-02-20 11:45 UTC (permalink / raw)
To: u-boot
Hi Eugeniu,
On Mon, Feb 17, 2020 at 12:24 PM Eugeniu Rosca <erosca@de.adit-jv.com> wrote:
>
> Replace 'u32' by 'uint32_t' in image.h, since the former may lead to
> build failures in U-Boot tooling (see [1]).
>
> Avoid using 'uint', since it is not a fixed-width type [2], potentially
> leading to a dangerous mismatch between the prototypes and definitions
> of the android_image_get_dtb* functions.
>
> This should be the quickest way to overcome the tooling build failure,
> with more future-proof solutions being proposed by Yamada-san in [1].
>
> [1] https://patchwork.ozlabs.org/patch/1238245/
> [2] Excerpt from https://en.cppreference.com/w/cpp/language/types
> -----------8<------------
> Type specifier Width in bits by data model
> LP32 ILP32 LLP64 LP64
> unsigned int 16 32 32 32
> -----------8<------------
>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Sam Protsenko <joe.skb7@gmail.com>
> Fixes: 7f2531502c74c0 ("image: android: Add routine to get dtbo params")
> Fixes: c3bfad825a71ea ("image: android: Add functions for handling dtb field")
> Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> ---
Reviewed-by: Sam Protsenko <joe.skb7@gmail.com>
> include/image.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/image.h b/include/image.h
> index b316d167d8d7..1341fbed62ba 100644
> --- a/include/image.h
> +++ b/include/image.h
> @@ -1425,9 +1425,9 @@ int android_image_get_ramdisk(const struct andr_img_hdr *hdr,
> ulong *rd_data, ulong *rd_len);
> int android_image_get_second(const struct andr_img_hdr *hdr,
> ulong *second_data, ulong *second_len);
> -bool android_image_get_dtbo(ulong hdr_addr, ulong *addr, u32 *size);
> -bool android_image_get_dtb_by_index(ulong hdr_addr, u32 index, ulong *addr,
> - u32 *size);
> +bool android_image_get_dtbo(ulong hdr_addr, ulong *addr, uint32_t *size);
> +bool android_image_get_dtb_by_index(ulong hdr_addr, uint32_t index, ulong *addr,
> + uint32_t *size);
> ulong android_image_get_end(const struct andr_img_hdr *hdr);
> ulong android_image_get_kload(const struct andr_img_hdr *hdr);
> ulong android_image_get_kcomp(const struct andr_img_hdr *hdr);
> --
> 2.25.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] image.h: use uint32_t instead of u32 in android_image_get_dtb*
2020-02-20 11:45 ` Sam Protsenko
@ 2020-03-01 20:57 ` Heinrich Schuchardt
2020-03-09 20:35 ` Eugeniu Rosca
0 siblings, 1 reply; 5+ messages in thread
From: Heinrich Schuchardt @ 2020-03-01 20:57 UTC (permalink / raw)
To: u-boot
On 2/20/20 12:45 PM, Sam Protsenko wrote:
> Hi Eugeniu,
>
> On Mon, Feb 17, 2020 at 12:24 PM Eugeniu Rosca <erosca@de.adit-jv.com> wrote:
>>
>> Replace 'u32' by 'uint32_t' in image.h, since the former may lead to
>> build failures in U-Boot tooling (see [1]).
>>
>> Avoid using 'uint', since it is not a fixed-width type [2], potentially
>> leading to a dangerous mismatch between the prototypes and definitions
>> of the android_image_get_dtb* functions.
>>
>> This should be the quickest way to overcome the tooling build failure,
>> with more future-proof solutions being proposed by Yamada-san in [1].
>>
>> [1] https://patchwork.ozlabs.org/patch/1238245/
>> [2] Excerpt from https://en.cppreference.com/w/cpp/language/types
>> -----------8<------------
>> Type specifier Width in bits by data model
>> LP32 ILP32 LLP64 LP64
>> unsigned int 16 32 32 32
>> -----------8<------------
>>
>> Cc: Tom Rini <trini@konsulko.com>
>> Cc: Sam Protsenko <joe.skb7@gmail.com>
>> Fixes: 7f2531502c74c0 ("image: android: Add routine to get dtbo params")
>> Fixes: c3bfad825a71ea ("image: android: Add functions for handling dtb field")
>> Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
>> Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
>> ---
>
> Reviewed-by: Sam Protsenko <joe.skb7@gmail.com>
uint32_t is defined in glibc's stdint.h and in our include/linux/types.h
(which is included in common.h).
We use image.h in tools/*.c in files which neither include common.h nor
stdint.h. But for USE_HOSTCC=y include/compiler.h includes stdint.h.
BUT changing a function definition in a header and not doing the same in
the C-file looks quite inconsistent to me.
Please, use the same types in both the C-file and in the header.
Best regards
Heinrich
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] image.h: use uint32_t instead of u32 in android_image_get_dtb*
2020-03-01 20:57 ` Heinrich Schuchardt
@ 2020-03-09 20:35 ` Eugeniu Rosca
0 siblings, 0 replies; 5+ messages in thread
From: Eugeniu Rosca @ 2020-03-09 20:35 UTC (permalink / raw)
To: u-boot
To facilitate tracking, this patch has been superseded by:
https://patchwork.ozlabs.org/patch/1250963/
("image.h: isolate android_image_* functions from tooling")
--
Best Regards
Eugeniu Rosca
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-09 20:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-17 10:23 [PATCH] image.h: use uint32_t instead of u32 in android_image_get_dtb* Eugeniu Rosca
2020-02-18 17:41 ` Masahiro Yamada
2020-02-20 11:45 ` Sam Protsenko
2020-03-01 20:57 ` Heinrich Schuchardt
2020-03-09 20:35 ` Eugeniu Rosca
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.