All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>,
	"mcgrof@kernel.org" <mcgrof@kernel.org>
Cc: "mwilck@suse.com" <mwilck@suse.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"agk@redhat.com" <agk@redhat.com>, "hare@suse.de" <hare@suse.de>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"yuchao0@huawei.com" <yuchao0@huawei.com>,
	"ghe@suse.com" <ghe@suse.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"jaegeuk@kernel.org" <jaegeuk@kernel.org>,
	"tchvatal@suse.com" <tchvatal@suse.com>,
	"zren@suse.com" <zren@suse.com>
Subject: Re: [PATCH] dm-zoned-tools: add zoned disk udev rules for scheduler / dmsetup
Date: Thu, 14 Jun 2018 16:19:23 +0000	[thread overview]
Message-ID: <64d7d5386d6171a9a551f22db86524cf7a595af5.camel@wdc.com> (raw)
In-Reply-To: <20180614001147.1545-1-mcgrof@kernel.org>

T24gV2VkLCAyMDE4LTA2LTEzIGF0IDE3OjExIC0wNzAwLCBMdWlzIFIuIFJvZHJpZ3VleiB3cm90
ZToNCj4gVGhpcyB0cmllcyB0byBwdXQgYSBiaXQgb2YgdGhpcyB0cmliYWwga25vd2xlZGdlIGlu
dG8gYW4gaW5pdGlhbCB1ZGV2DQo+IHJ1bGUgZm9yIGRldmVsb3BtZW50IHdpdGggdGhlIGhvcGVz
IExpbnV4IGRpc3RyaWJ1dGlvbnMgY2FuIGxhdGVyDQo+IGRlcGxveS4gVGhyZWUgcnVsZSBhcmUg
YWRkZWQuIE9uZSBydWxlIGlzIG9wdGlvbmFsIGZvciBub3csIGl0IHNob3VsZCBiZQ0KPiBleHRl
bmRlZCBsYXRlciB0byBiZSBtb3JlIGRpc3RyaWJ1dGlvbi1mcmllbmRseSBhbmQgdGhlbiBJIHRo
aW5rIHRoaXMNCj4gbWF5IGJlIHJlYWR5IGZvciBjb25zaWRlcmF0aW9uIGZvciBpbnRlZ3JhdGlv
biBvbiBkaXN0cmlidXRpb25zLg0KPiANCj4gMSkgc2NoZWR1bGVyIHNldHVwDQo+IDIpIGJhY2ts
aXN0IGYyZnMgZGV2aWNlcw0KPiAzKSBydW4gZG1zZXR1cCBmb3IgdGhlIHJlc3Qgb2YgZGV2aWNl
cw0KDQpIZWxsbyBMdWlzLA0KDQpJIHRoaW5rIGl0IGlzIHdyb25nIHRvIHBhY2thZ2UgdGhlIHpv
bmVkIGJsb2NrIGRldmljZSBzY2hlZHVsZXIgcnVsZSBpbiB0aGUNCmRtLXpvbmVkLXRvb2xzIHBh
Y2thZ2UuIFRoYXQgdWRldiBydWxlIHNob3VsZCBiZSBhY3RpdmF0ZWQgd2hldGhlciBvciBub3Qg
dGhlDQpkbS16b25lZC10b29scyBwYWNrYWdlIGhhcyBiZWVuIGluc3RhbGxlZC4gSGF2ZSB5b3Ug
Y29uc2lkZXJlZCB0byBzdWJtaXQgdGhlDQp6b25lZCBibG9jayBkZXZpY2Ugc2NoZWR1bGVyIHJ1
bGUgdG8gdGhlIHN5c3RlbWQgcHJvamVjdCBzaW5jZSB0b2RheSB0aGF0DQpwcm9qZWN0IGluY2x1
ZGVzIGFsbCBiYXNlIHVkZXYgcnVsZXM/DQoNCj4gKyMgWm9uZWQgZGlza3MgY2FuIG9ubHkgd29y
ayB3aXRoIHRoZSBkZWFkbGluZSBvciBtcS1kZWFkbGluZSBzY2hlZHVsZXIuIFRoaXMgaXMNCj4g
KyMgbWFuZGF0ZWQgZm9yIGFsbCBTTVIgZHJpdmVzIHNpbmNlIHY0LjE2LiBJdCBoYXMgYmVlbiBk
ZXRlcm1pbmVkIHRoaXMgbXVzdCBiZQ0KPiArIyBkb25lIHRocm91Z2ggYSB1ZGV2IHJ1bGUsIGFu
ZCB0aGUga2VybmVsIHNob3VsZCBub3Qgc2V0IHRoaXMgdXAgZm9yIGRpc2tzLg0KPiArIyBUaGlz
IG1hZ2ljIHdpbGwgaGF2ZSB0byBsaXZlIGZvciAqYWxsKiB6b25lZCBkaXNrcy4NCj4gKyMgWFhY
OiB3aGF0IGFib3V0IGRpc3RyaWJ1dGlvbnMgdGhhdCB3YW50IG1xLWRlYWRsaW5lID8gUHJvYmFi
bHkgZWFzeSBmb3Igbm93DQo+ICsjICAgICAgdG8gYXNzdW1lIGRlYWRsaW5lIGFuZCBsYXRlciBo
YXZlIGEgbWFwcGluZyBmaWxlIHRvIGVuYWJsZQ0KPiArIyAgICAgIG1xLWRlYWRsaW5lIGZvciBz
cGVjaWZpYyBzZXJpYWwgZGV2aWNlcz8NCj4gK0FDVElPTj09ImFkZHxjaGFuZ2UiLCBLRVJORUw9
PSJzZCpbITAtOV0iLCBBVFRSU3txdWV1ZS96b25lZH09PSJob3N0LW1hbmFnZWQiLCBcDQo+ICsJ
QVRUUntxdWV1ZS9zY2hlZHVsZXJ9PSJkZWFkbGluZSINCg0KSSB0aGluayBpdCBpcyB3cm9uZyB0
byBsaW1pdCB0aGlzIHJ1bGUgdG8gU0NTSSBkaXNrcyBvbmx5LiBXb3JrIGlzIG9uZ29pbmcgdG8N
CmFkZCB6b25lZCBibG9jayBkZXZpY2Ugc3VwcG9ydCB0byB0aGUgbnVsbF9ibGsgZHJpdmVyLiBU
aGF0IGlzIGEgYmxvY2sgZHJpdmVyDQphbmQgbm90IGEgU0NTSSBkcml2ZXIuIEkgdGhpbmsgdGhl
IGFib3ZlIHVkZXYgcnVsZSBzaG91bGQgYXBwbHkgdG8gdGhhdCBibG9jaw0KZHJpdmVyIHRvby4N
Cg0KUmVnYXJkaW5nIGJsay1tcSwgZnJvbSB0aGUgbXEtZGVhZGxpbmUgc291cmNlIGNvZGU6DQoJ
LmVsZXZhdG9yX2FsaWFzID0gImRlYWRsaW5lIiwNCg0KSW4gb3RoZXIgd29yZHMsIHRoZSBuYW1l
ICJkZWFkbGluZSIgc2hvdWxkIHdvcmsgYm90aCBmb3IgbGVnYWN5IGFuZCBmb3IgYmxrLW1xDQpi
bG9jayBkZXZpY2VzLg0KDQpUaGFua3MsDQoNCkJhcnQuDQoNCg0K

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>,
	"mcgrof@kernel.org" <mcgrof@kernel.org>
Cc: "mwilck@suse.com" <mwilck@suse.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"agk@redhat.com" <agk@redhat.com>, "hare@suse.de" <hare@suse.de>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"yuchao0@huawei.com" <yuchao0@huawei.com>,
	"ghe@suse.com" <ghe@suse.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"jaegeuk@kernel.org" <jaegeuk@kernel.org>,
	"tchvatal@suse.com" <tchvatal@suse.com>,
	"zren@suse.com" <zren@suse.com>
Subject: Re: [PATCH] dm-zoned-tools: add zoned disk udev rules for scheduler / dmsetup
Date: Thu, 14 Jun 2018 16:19:23 +0000	[thread overview]
Message-ID: <64d7d5386d6171a9a551f22db86524cf7a595af5.camel@wdc.com> (raw)
In-Reply-To: <20180614001147.1545-1-mcgrof@kernel.org>

On Wed, 2018-06-13 at 17:11 -0700, Luis R. Rodriguez wrote:
> This tries to put a bit of this tribal knowledge into an initial udev
> rule for development with the hopes Linux distributions can later
> deploy. Three rule are added. One rule is optional for now, it should be
> extended later to be more distribution-friendly and then I think this
> may be ready for consideration for integration on distributions.
> 
> 1) scheduler setup
> 2) backlist f2fs devices
> 3) run dmsetup for the rest of devices

Hello Luis,

I think it is wrong to package the zoned block device scheduler rule in the
dm-zoned-tools package. That udev rule should be activated whether or not the
dm-zoned-tools package has been installed. Have you considered to submit the
zoned block device scheduler rule to the systemd project since today that
project includes all base udev rules?

> +# Zoned disks can only work with the deadline or mq-deadline scheduler. This is
> +# mandated for all SMR drives since v4.16. It has been determined this must be
> +# done through a udev rule, and the kernel should not set this up for disks.
> +# This magic will have to live for *all* zoned disks.
> +# XXX: what about distributions that want mq-deadline ? Probably easy for now
> +#      to assume deadline and later have a mapping file to enable
> +#      mq-deadline for specific serial devices?
> +ACTION=="add|change", KERNEL=="sd*[!0-9]", ATTRS{queue/zoned}=="host-managed", \
> +	ATTR{queue/scheduler}="deadline"

I think it is wrong to limit this rule to SCSI disks only. Work is ongoing to
add zoned block device support to the null_blk driver. That is a block driver
and not a SCSI driver. I think the above udev rule should apply to that block
driver too.

Regarding blk-mq, from the mq-deadline source code:
	.elevator_alias = "deadline",

In other words, the name "deadline" should work both for legacy and for blk-mq
block devices.

Thanks,

Bart.



  parent reply	other threads:[~2018-06-14 16:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14  0:11 [PATCH] dm-zoned-tools: add zoned disk udev rules for scheduler / dmsetup Luis R. Rodriguez
2018-06-14 10:01 ` Damien Le Moal
2018-06-14 10:01   ` Damien Le Moal
2018-06-14 13:39   ` Bart Van Assche
2018-06-14 13:39     ` Bart Van Assche
2018-06-14 13:42     ` Christoph Hellwig
2018-06-15 11:07       ` Martin Wilck
2018-06-15 11:07         ` Martin Wilck
2018-06-14 12:38 ` Mike Snitzer
2018-06-14 16:23   ` Bart Van Assche
2018-06-14 16:23     ` Bart Van Assche
2018-06-14 17:37   ` Luis R. Rodriguez
2018-06-14 17:46     ` Luis R. Rodriguez
2018-06-14 17:58     ` Mike Snitzer
2018-06-15  9:59       ` Damien Le Moal
2018-06-15  9:59         ` Damien Le Moal
2018-06-15 14:50         ` Mike Snitzer
2018-06-15  9:00   ` Damien Le Moal
2018-06-15  9:00     ` Damien Le Moal
2018-06-14 16:19 ` Bart Van Assche [this message]
2018-06-14 16:19   ` [PATCH] " Bart Van Assche
2018-06-14 17:44   ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64d7d5386d6171a9a551f22db86524cf7a595af5.camel@wdc.com \
    --to=bart.vanassche@wdc.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=ghe@suse.com \
    --cc=hare@suse.de \
    --cc=jaegeuk@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=mwilck@suse.com \
    --cc=tchvatal@suse.com \
    --cc=yuchao0@huawei.com \
    --cc=zren@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.