[PATCH] libxenstat: avoid build race

[PATCH] libxenstat: avoid build race

[Jan Beulich]

Olaf reported observing

xenstat_qmp.c:26:10: fatal error: _paths.h: No such file or directory
.../tools/libs/stat/../../../tools/Rules.mk:153: xenstat_qmp.opic] Error 1

Obviously _paths.h, when included by any of the sources, needs to be
created in advance of compiling any of them, not just the non-PIC ones.

Reported-by: Olaf Hering <olaf@aepfle.de>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
A similar issue (at the time of the report) in the building of
libxenstore was addressed by Jürgen's 9af5e2b31b4e ("tools/libs/store:
don't use symbolic links for external files").

--- a/tools/libs/stat/Makefile
+++ b/tools/libs/stat/Makefile
@@ -30,7 +30,7 @@ include $(XEN_ROOT)/tools/libs/libs.mk
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
-$(LIB_OBJS): _paths.h
+$(LIB_OBJS) $(PIC_OBJS): _paths.h
 
 PYLIB=bindings/swig/python/_xenstat.so
 PYMOD=bindings/swig/python/xenstat.py

Re: [PATCH] libxenstat: avoid build race

[Bertrand Marquis]

Hi,

> On 17 Nov 2020, at 09:42, Jan Beulich <jbeulich@suse.com> wrote:
> 
> Olaf reported observing
> 
> xenstat_qmp.c:26:10: fatal error: _paths.h: No such file or directory
> .../tools/libs/stat/../../../tools/Rules.mk:153: xenstat_qmp.opic] Error 1
> 
> Obviously _paths.h, when included by any of the sources, needs to be
> created in advance of compiling any of them, not just the non-PIC ones.
> 
> Reported-by: Olaf Hering <olaf@aepfle.de>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> A similar issue (at the time of the report) in the building of
> libxenstore was addressed by Jürgen's 9af5e2b31b4e ("tools/libs/store:
> don't use symbolic links for external files").
> 
> --- a/tools/libs/stat/Makefile
> +++ b/tools/libs/stat/Makefile
> @@ -30,7 +30,7 @@ include $(XEN_ROOT)/tools/libs/libs.mk
> 
> include $(XEN_ROOT)/tools/libs/libs.mk
> 
> -$(LIB_OBJS): _paths.h
> +$(LIB_OBJS) $(PIC_OBJS): _paths.h
> 
> PYLIB=bindings/swig/python/_xenstat.so
> PYMOD=bindings/swig/python/xenstat.py
> 

Ping: [PATCH] libxenstat: avoid build race

[Jan Beulich]

On 18.11.2020 15:27, Bertrand Marquis wrote:
>> On 17 Nov 2020, at 09:42, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> Olaf reported observing
>>
>> xenstat_qmp.c:26:10: fatal error: _paths.h: No such file or directory
>> .../tools/libs/stat/../../../tools/Rules.mk:153: xenstat_qmp.opic] Error 1
>>
>> Obviously _paths.h, when included by any of the sources, needs to be
>> created in advance of compiling any of them, not just the non-PIC ones.
>>
>> Reported-by: Olaf Hering <olaf@aepfle.de>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Ping? (I guess this one is again simple enough that I should
time out waiting by the middle of the week.)

Jan

>> ---
>> A similar issue (at the time of the report) in the building of
>> libxenstore was addressed by Jürgen's 9af5e2b31b4e ("tools/libs/store:
>> don't use symbolic links for external files").
>>
>> --- a/tools/libs/stat/Makefile
>> +++ b/tools/libs/stat/Makefile
>> @@ -30,7 +30,7 @@ include $(XEN_ROOT)/tools/libs/libs.mk
>>
>> include $(XEN_ROOT)/tools/libs/libs.mk
>>
>> -$(LIB_OBJS): _paths.h
>> +$(LIB_OBJS) $(PIC_OBJS): _paths.h
>>
>> PYLIB=bindings/swig/python/_xenstat.so
>> PYMOD=bindings/swig/python/xenstat.py
>>
> 

Re: Ping: [PATCH] libxenstat: avoid build race

[Wei Liu]

On Mon, Dec 07, 2020 at 04:25:41PM +0100, Jan Beulich wrote:
> On 18.11.2020 15:27, Bertrand Marquis wrote:
> >> On 17 Nov 2020, at 09:42, Jan Beulich <jbeulich@suse.com> wrote:
> >>
> >> Olaf reported observing
> >>
> >> xenstat_qmp.c:26:10: fatal error: _paths.h: No such file or directory
> >> .../tools/libs/stat/../../../tools/Rules.mk:153: xenstat_qmp.opic] Error 1
> >>
> >> Obviously _paths.h, when included by any of the sources, needs to be
> >> created in advance of compiling any of them, not just the non-PIC ones.
> >>
> >> Reported-by: Olaf Hering <olaf@aepfle.de>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> 
> Ping? (I guess this one is again simple enough that I should
> time out waiting by the middle of the week.)

Acked-by: Wei Liu <wl@xen.org>