All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Michael Zaidman <michael.zaidman@gmail.com>, lkp@intel.com
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	linux-kernel@vger.kernel.org, jikos@kernel.org,
	dan.carpenter@oracle.com, linux-input@vger.kernel.org
Subject: Re: [PATCH v2] HID: ft260: fix format type warning in ft260_word_show()
Date: Mon, 10 May 2021 09:41:57 -0700	[thread overview]
Message-ID: <6a589bf720c5420e09bcc3c40b812bf6822d3a3d.camel@perches.com> (raw)
In-Reply-To: <20210510163029.2217-1-michael.zaidman@gmail.com>

On Mon, 2021-05-10 at 19:30 +0300, Michael Zaidman wrote:
> Fixes: 6a82582d9fa4 ("HID: ft260: add usb hid to i2c host bridge driver")
> 
> Fix warning reported by static analysis when built with W=1 for arm64 by
> clang version 13.0.0
> 
> > > drivers/hid/hid-ft260.c:794:44: warning: format specifies type 'short' but
>    the argument has type 'int' [-Wformat]
[]
> diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c
[]
> @@ -791,7 +791,7 @@ static int ft260_word_show(struct hid_device *hdev, int id, u8 *cfg, int len,
>  	if (ret != len && ret >= 0)
>  		return -EIO;
>  
> 
> -	return scnprintf(buf, PAGE_SIZE, "%hi\n", le16_to_cpu(*field));
> +	return scnprintf(buf, PAGE_SIZE, "%d\n", le16_to_cpu(*field));
>  }

This is likely a clang defect and not an actual problem.
If you are going to convert one of these, convert both.



WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2] HID: ft260: fix format type warning in ft260_word_show()
Date: Mon, 10 May 2021 09:41:57 -0700	[thread overview]
Message-ID: <6a589bf720c5420e09bcc3c40b812bf6822d3a3d.camel@perches.com> (raw)
In-Reply-To: <20210510163029.2217-1-michael.zaidman@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

On Mon, 2021-05-10 at 19:30 +0300, Michael Zaidman wrote:
> Fixes: 6a82582d9fa4 ("HID: ft260: add usb hid to i2c host bridge driver")
> 
> Fix warning reported by static analysis when built with W=1 for arm64 by
> clang version 13.0.0
> 
> > > drivers/hid/hid-ft260.c:794:44: warning: format specifies type 'short' but
>    the argument has type 'int' [-Wformat]
[]
> diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c
[]
> @@ -791,7 +791,7 @@ static int ft260_word_show(struct hid_device *hdev, int id, u8 *cfg, int len,
>  	if (ret != len && ret >= 0)
>  		return -EIO;
>  
> 
> -	return scnprintf(buf, PAGE_SIZE, "%hi\n", le16_to_cpu(*field));
> +	return scnprintf(buf, PAGE_SIZE, "%d\n", le16_to_cpu(*field));
>  }

This is likely a clang defect and not an actual problem.
If you are going to convert one of these, convert both.


  reply	other threads:[~2021-05-10 16:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 22:47 drivers/hid/hid-ft260.c:794:44: warning: format specifies type 'short' but the argument has type 'int' kernel test robot
2021-05-05 22:47 ` kernel test robot
2021-05-06 11:55 ` Michael Zaidman
2021-05-06 11:55   ` Michael Zaidman
2021-05-07 10:00   ` [kbuild-all] " Chen, Rong A
2021-05-07 10:00     ` Chen, Rong A
2021-05-09 18:25     ` [kbuild-all] " Michael Zaidman
2021-05-09 18:25       ` Michael Zaidman
2021-05-09 19:32 ` [PATCH] HID: ft260: fix format type warning in ft260_word_show() Michael Zaidman
2021-05-09 19:32   ` Michael Zaidman
2021-05-09 20:39   ` Joe Perches
2021-05-09 20:39     ` Joe Perches
2021-05-10  9:17     ` Michael Zaidman
2021-05-10  9:17       ` Michael Zaidman
2021-05-10  9:52       ` Joe Perches
2021-05-10  9:52         ` Joe Perches
2021-05-10 10:15         ` Dan Carpenter
2021-05-10 10:15           ` Dan Carpenter
2021-05-10 10:22           ` Dan Carpenter
2021-05-10 10:22             ` Dan Carpenter
2021-05-10 12:51         ` Michael Zaidman
2021-05-10 12:51           ` Michael Zaidman
2021-05-10 16:30 ` [PATCH v2] " Michael Zaidman
2021-05-10 16:30   ` Michael Zaidman
2021-05-10 16:41   ` Joe Perches [this message]
2021-05-10 16:41     ` Joe Perches
2021-05-10 16:34 ` [PATCH v3] " Michael Zaidman
2021-05-10 16:34   ` Michael Zaidman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a589bf720c5420e09bcc3c40b812bf6822d3a3d.camel@perches.com \
    --to=joe@perches.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=dan.carpenter@oracle.com \
    --cc=jikos@kernel.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=michael.zaidman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.