* [PATCH for-5.1] Makefile: Remove config-devices.mak on "make clean"
@ 2020-07-17 15:25 Peter Maydell
2020-07-17 15:30 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2020-07-17 15:25 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Philippe Mathieu-Daudé
The config-devices.mak files are generated by "make", and so they
should be deleted by "make clean".
(This is different from config-host.mak and config-all-disas.mak,
which are created by "configure" and so only deleted by
"make distclen".)
If we don't delete these files on "make clean", then the build
tree is left in a state where it has the config-devices.mak
file but not the config-devices.mak.d file, and make will not
realize that it needs to rebuild config-devices.mak if, for
instance, hw/sd/Kconfig changes.
NB: config-all-devices.mak is also generated by "make", but we
already remove it on "make clean".
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
I didn't remove the existing 'rm -f $(SUBDIR_DEVICES_MAK)'
from the 'distclean' rules on the basis that config-all-devices.mak
is explicitly removed in both 'distclean' and 'clean', despite
'distclean' depending on 'clean'...
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 32345c610ee..c2120d8d48d 100644
--- a/Makefile
+++ b/Makefile
@@ -775,6 +775,7 @@ clean: recurse-clean
rm -f storage-daemon/qapi/qapi-gen-timestamp
rm -rf qga/qapi-generated
rm -f config-all-devices.mak
+ rm -f $(SUBDIR_DEVICES_MAK)
VERSION ?= $(shell cat VERSION)
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH for-5.1] Makefile: Remove config-devices.mak on "make clean"
2020-07-17 15:25 [PATCH for-5.1] Makefile: Remove config-devices.mak on "make clean" Peter Maydell
@ 2020-07-17 15:30 ` Philippe Mathieu-Daudé
2020-07-20 10:07 ` Peter Maydell
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-07-17 15:30 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: Paolo Bonzini
On 7/17/20 5:25 PM, Peter Maydell wrote:
> The config-devices.mak files are generated by "make", and so they
> should be deleted by "make clean".
>
> (This is different from config-host.mak and config-all-disas.mak,
> which are created by "configure" and so only deleted by
> "make distclen".)
typo "distclean"
>
> If we don't delete these files on "make clean", then the build
> tree is left in a state where it has the config-devices.mak
> file but not the config-devices.mak.d file, and make will not
> realize that it needs to rebuild config-devices.mak if, for
> instance, hw/sd/Kconfig changes.
>
> NB: config-all-devices.mak is also generated by "make", but we
> already remove it on "make clean".
>
Suggested-by: Paolo Bonzini <pbonzini@redhat.com> ?
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I didn't remove the existing 'rm -f $(SUBDIR_DEVICES_MAK)'
> from the 'distclean' rules on the basis that config-all-devices.mak
> is explicitly removed in both 'distclean' and 'clean', despite
> 'distclean' depending on 'clean'...
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 32345c610ee..c2120d8d48d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -775,6 +775,7 @@ clean: recurse-clean
> rm -f storage-daemon/qapi/qapi-gen-timestamp
> rm -rf qga/qapi-generated
> rm -f config-all-devices.mak
> + rm -f $(SUBDIR_DEVICES_MAK)
>
> VERSION ?= $(shell cat VERSION)
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH for-5.1] Makefile: Remove config-devices.mak on "make clean"
2020-07-17 15:30 ` Philippe Mathieu-Daudé
@ 2020-07-20 10:07 ` Peter Maydell
0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2020-07-20 10:07 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: Paolo Bonzini, QEMU Developers
On Fri, 17 Jul 2020 at 16:30, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 7/17/20 5:25 PM, Peter Maydell wrote:
> > The config-devices.mak files are generated by "make", and so they
> > should be deleted by "make clean".
> >
> > (This is different from config-host.mak and config-all-disas.mak,
> > which are created by "configure" and so only deleted by
> > "make distclen".)
>
> typo "distclean"
>
> >
> > If we don't delete these files on "make clean", then the build
> > tree is left in a state where it has the config-devices.mak
> > file but not the config-devices.mak.d file, and make will not
> > realize that it needs to rebuild config-devices.mak if, for
> > instance, hw/sd/Kconfig changes.
> >
> > NB: config-all-devices.mak is also generated by "make", but we
> > already remove it on "make clean".
> >
>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com> ?
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Applied to master with the commit-message fixes so I could merge
the i2c pullreq.
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH for-5.1] Makefile: Remove config-devices.mak on "make clean"
2020-10-12 15:33 [PATCH 00/10] target/arm: Various v8.1M minor features Peter Maydell
@ 2020-10-12 15:33 ` Peter Maydell
0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2020-10-12 15:33 UTC (permalink / raw)
To: qemu-arm, qemu-devel; +Cc: Richard Henderson
The config-devices.mak files are generated by "make", and so they
should be deleted by "make clean".
(This is different from config-host.mak and config-all-disas.mak,
which are created by "configure" and so only deleted by
"make distclen".)
If we don't delete these files on "make clean", then the build
tree is left in a state where it has the config-devices.mak
file but not the config-devices.mak.d file, and make will not
realize that it needs to rebuild config-devices.mak if, for
instance, hw/sd/Kconfig changes.
NB: config-all-devices.mak is also generated by "make", but we
already remove it on "make clean".
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
I didn't remove the existing 'rm -f $(SUBDIR_DEVICES_MAK)'
from the 'distclean' rules on the basis that config-all-devices.mak
is explicitly removed in both 'distclean' and 'clean', despite
'distclean' depending on 'clean'...
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 32345c610ee..c2120d8d48d 100644
--- a/Makefile
+++ b/Makefile
@@ -775,6 +775,7 @@ clean: recurse-clean
rm -f storage-daemon/qapi/qapi-gen-timestamp
rm -rf qga/qapi-generated
rm -f config-all-devices.mak
+ rm -f $(SUBDIR_DEVICES_MAK)
VERSION ?= $(shell cat VERSION)
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-12 15:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-17 15:25 [PATCH for-5.1] Makefile: Remove config-devices.mak on "make clean" Peter Maydell
2020-07-17 15:30 ` Philippe Mathieu-Daudé
2020-07-20 10:07 ` Peter Maydell
2020-10-12 15:33 [PATCH 00/10] target/arm: Various v8.1M minor features Peter Maydell
2020-10-12 15:33 ` [PATCH for-5.1] Makefile: Remove config-devices.mak on "make clean" Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.