From: "Wangtao (Kevin, Kirin)" <kevin.wangtao@hisilicon.com> To: Daniel Lezcano <daniel.lezcano@linaro.org>, <edubezval@gmail.com> Cc: <rui.zhang@intel.com>, <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <sunzhaosheng@hisilicon.com>, <gengyanping@hisilicon.com>, Kevin Wangtao <kevin.wangtao@linaro.org> Subject: Re: [PATCH] thermal/drivers/hisi: disable multi alarm support for hi3660 SoC Date: Thu, 19 Oct 2017 09:31:24 +0800 [thread overview] Message-ID: <6f39a5ed-0db6-4600-19d0-f9e9c5c43b1f@hisilicon.com> (raw) In-Reply-To: <9685721b-4593-029b-b8e8-d721526b7119@linaro.org> 在 2017/10/18 23:54, Daniel Lezcano 写道: > On 18/10/2017 11:15, Tao Wang wrote: >> From: Kevin Wangtao <kevin.wangtao@linaro.org> >> >> multi alarm interrupt forced a re-trigger of power_allocator_throttle >> which changes the PID's actual sampling rate, this isn't optimal for >> IPA, it is best to disable multi alarm support now and sort out this >> issue later. >> >> Signed-off-by: Kevin Wangtao <kevin.wangtao@linaro.org> > > Did you test the series with this change? Yes > >> --- >> drivers/thermal/hisi_thermal.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c >> index 133238a..3b74c12 100644 >> --- a/drivers/thermal/hisi_thermal.c >> +++ b/drivers/thermal/hisi_thermal.c >> @@ -360,7 +360,6 @@ static int hi3660_thermal_enable_sensor(struct hisi_thermal_data *data) >> >> /* set interrupt threshold */ >> value = hi3660_thermal_temp_to_step(sensor->thres_temp[0]); >> - value |= hi3660_thermal_temp_to_step(sensor->thres_temp[1]) << 10; >> hi3660_thermal_alarm_set(data->regs, sensor->id, value); >> >> /* enable interrupt */ >> > >
WARNING: multiple messages have this Message-ID (diff)
From: "Wangtao (Kevin, Kirin)" <kevin.wangtao@hisilicon.com> To: Daniel Lezcano <daniel.lezcano@linaro.org>, edubezval@gmail.com Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, sunzhaosheng@hisilicon.com, gengyanping@hisilicon.com, Kevin Wangtao <kevin.wangtao@linaro.org> Subject: Re: [PATCH] thermal/drivers/hisi: disable multi alarm support for hi3660 SoC Date: Thu, 19 Oct 2017 09:31:24 +0800 [thread overview] Message-ID: <6f39a5ed-0db6-4600-19d0-f9e9c5c43b1f@hisilicon.com> (raw) In-Reply-To: <9685721b-4593-029b-b8e8-d721526b7119@linaro.org> 在 2017/10/18 23:54, Daniel Lezcano 写道: > On 18/10/2017 11:15, Tao Wang wrote: >> From: Kevin Wangtao <kevin.wangtao@linaro.org> >> >> multi alarm interrupt forced a re-trigger of power_allocator_throttle >> which changes the PID's actual sampling rate, this isn't optimal for >> IPA, it is best to disable multi alarm support now and sort out this >> issue later. >> >> Signed-off-by: Kevin Wangtao <kevin.wangtao@linaro.org> > > Did you test the series with this change? Yes > >> --- >> drivers/thermal/hisi_thermal.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c >> index 133238a..3b74c12 100644 >> --- a/drivers/thermal/hisi_thermal.c >> +++ b/drivers/thermal/hisi_thermal.c >> @@ -360,7 +360,6 @@ static int hi3660_thermal_enable_sensor(struct hisi_thermal_data *data) >> >> /* set interrupt threshold */ >> value = hi3660_thermal_temp_to_step(sensor->thres_temp[0]); >> - value |= hi3660_thermal_temp_to_step(sensor->thres_temp[1]) << 10; >> hi3660_thermal_alarm_set(data->regs, sensor->id, value); >> >> /* enable interrupt */ >> > >
next prev parent reply other threads:[~2017-10-19 1:34 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-10 18:02 [GIT PULL] thermal: new material for hikey for 4.15 Daniel Lezcano 2017-10-10 18:02 ` [PATCH 01/25] thermal/drivers/hisi: Fix missing interrupt enablement Daniel Lezcano 2017-10-10 18:02 ` [PATCH 02/25] thermal/drivers/hisi: Remove the multiple sensors support Daniel Lezcano 2017-10-17 3:54 ` Eduardo Valentin 2017-10-17 12:28 ` Daniel Lezcano 2017-10-17 18:25 ` Eduardo Valentin 2017-10-17 19:03 ` Daniel Lezcano 2017-10-17 21:07 ` Eduardo Valentin 2017-10-17 21:10 ` Daniel Lezcano 2017-10-18 1:48 ` Leo Yan 2017-10-18 15:51 ` Eduardo Valentin 2017-10-18 16:23 ` Daniel Lezcano 2017-10-18 1:49 ` Wangtao (Kevin, Kirin) 2017-10-18 1:49 ` Wangtao (Kevin, Kirin) 2017-10-10 18:02 ` [PATCH 03/25] thermal/drivers/hisi: Fix kernel panic on alarm interrupt Daniel Lezcano 2017-10-10 18:02 ` [PATCH 04/25] thermal/drivers/hisi: Simplify the temperature/step computation Daniel Lezcano 2017-10-10 18:02 ` [PATCH 05/25] thermal/drivers/hisi: Fix multiple alarm interrupts firing Daniel Lezcano 2017-10-10 18:02 ` [PATCH 06/25] thermal/drivers/hisi: Remove pointless lock Daniel Lezcano 2017-10-10 18:02 ` [PATCH 07/25] thermal/drivers/hisi: Encapsulate register writes into helpers Daniel Lezcano 2017-10-10 18:02 ` [PATCH 08/25] thermal/drivers/hisi: Fix configuration register setting Daniel Lezcano 2017-10-17 4:22 ` Eduardo Valentin 2017-10-10 18:02 ` [PATCH 09/25] thermal/drivers/hisi: Remove costly sensor inspection Daniel Lezcano 2017-10-10 18:02 ` [PATCH 10/25] thermal/drivers/hisi: Rename and remove unused field Daniel Lezcano 2017-10-10 18:02 ` [PATCH 11/25] thermal/drivers/hisi: Convert long to int Daniel Lezcano 2017-10-10 18:02 ` [PATCH 12/25] thermal/drivers/hisi: Remove thermal data back pointer Daniel Lezcano 2017-10-10 18:02 ` [PATCH 13/25] thermal/drivers/hisi: Remove mutex_lock in the code Daniel Lezcano 2017-10-10 18:02 ` [PATCH 14/25] thermal/drivers/generic-iio-adc: Switch tz request to devm version Daniel Lezcano 2017-10-10 18:02 ` [PATCH 15/25] thermal/drivers/step_wise: Fix temperature regulation misbehavior Daniel Lezcano 2017-10-10 18:02 ` [PATCH 16/25] thermal/drivers/qcom-spmi: Use devm_iio_channel_get Daniel Lezcano 2017-10-10 18:02 ` [PATCH 17/25] thermal/drivers/hisi: Move the clk setup in the corresponding functions Daniel Lezcano 2017-10-10 18:02 ` [PATCH 18/25] thermal/drivers/hisi: Use round up step value Daniel Lezcano 2017-10-10 18:02 ` [PATCH 19/25] thermal/drivers/hisi: Put platform code together Daniel Lezcano 2017-10-17 4:37 ` Eduardo Valentin 2017-10-10 18:02 ` [PATCH 20/25] thermal/drivers/hisi: Add platform prefix to function name Daniel Lezcano 2017-10-17 4:36 ` Eduardo Valentin 2017-10-10 18:02 ` [PATCH 21/25] thermal/drivers/hisi: Prepare to add support for other hisi platforms Daniel Lezcano 2017-10-17 4:36 ` Eduardo Valentin 2017-10-10 18:02 ` [PATCH 22/25] thermal/drivers/hisi: Add support for multi temp threshold Daniel Lezcano 2017-10-17 4:38 ` Eduardo Valentin 2017-10-10 18:02 ` [PATCH 23/25] dt-bindings: Document the hi3660 thermal sensor binding Daniel Lezcano 2017-10-10 18:02 ` Daniel Lezcano 2017-10-10 18:02 ` [PATCH 24/25] thermal/drivers/hisi: Add support for hi3660 SoC Daniel Lezcano 2017-10-17 4:39 ` Eduardo Valentin 2017-10-18 9:15 ` [PATCH] thermal/drivers/hisi: disable multi alarm " Tao Wang 2017-10-18 9:15 ` Tao Wang 2017-10-18 15:54 ` Daniel Lezcano 2017-10-19 1:31 ` Wangtao (Kevin, Kirin) [this message] 2017-10-19 1:31 ` Wangtao (Kevin, Kirin) 2017-12-05 2:02 ` Eduardo Valentin 2017-12-05 6:57 ` Daniel Lezcano 2017-10-10 18:02 ` [PATCH 25/25] arm64: dts: Register Hi3660's thermal sensor Daniel Lezcano 2017-10-10 18:02 ` Daniel Lezcano 2017-10-10 18:02 ` Daniel Lezcano 2017-10-13 8:49 ` Wei Xu 2017-10-13 8:49 ` Wei Xu 2017-10-13 8:49 ` Wei Xu 2017-10-16 21:50 ` [PATCH 01/25] thermal/drivers/hisi: Fix missing interrupt enablement Eduardo Valentin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6f39a5ed-0db6-4600-19d0-f9e9c5c43b1f@hisilicon.com \ --to=kevin.wangtao@hisilicon.com \ --cc=daniel.lezcano@linaro.org \ --cc=edubezval@gmail.com \ --cc=gengyanping@hisilicon.com \ --cc=kevin.wangtao@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=rui.zhang@intel.com \ --cc=sunzhaosheng@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.