* [PATCH] vhost/crypto: fix descriptor move
@ 2018-05-09 14:08 Fan Zhang
2018-05-16 6:11 ` Maxime Coquelin
2018-05-16 10:54 ` Maxime Coquelin
0 siblings, 2 replies; 3+ messages in thread
From: Fan Zhang @ 2018-05-09 14:08 UTC (permalink / raw)
To: dev; +Cc: roy.fan.zhang, maxime.coquelin
This patch fixes the redundant descriptor move in the copy mode
of vhost crypto. Originally the redundant descriptor move will
cause the message parsing error.
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
lib/librte_vhost/vhost_crypto.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
index 04ff8cd48..4c256284e 100644
--- a/lib/librte_vhost/vhost_crypto.c
+++ b/lib/librte_vhost/vhost_crypto.c
@@ -853,11 +853,6 @@ prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
op->sym->auth.digest.data = digest_addr;
op->sym->auth.digest.phys_addr = rte_pktmbuf_iova_offset(m_dst,
digest_offset);
- if (unlikely(move_desc(head, &desc,
- chain->para.hash_result_len) < 0)) {
- ret = VIRTIO_CRYPTO_ERR;
- goto error_exit;
- }
break;
default:
ret = VIRTIO_CRYPTO_BADMSG;
--
2.13.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost/crypto: fix descriptor move
2018-05-09 14:08 [PATCH] vhost/crypto: fix descriptor move Fan Zhang
@ 2018-05-16 6:11 ` Maxime Coquelin
2018-05-16 10:54 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2018-05-16 6:11 UTC (permalink / raw)
To: Fan Zhang, dev
Hi Fan,
On 05/09/2018 04:08 PM, Fan Zhang wrote:
> This patch fixes the redundant descriptor move in the copy mode
> of vhost crypto. Originally the redundant descriptor move will
> cause the message parsing error.
As it is a fix, we need to specify which commit it fixes.
In this case it is:
Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
I'll add it when applying, no need to resubmit.
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> lib/librte_vhost/vhost_crypto.c | 5 -----
> 1 file changed, 5 deletions(-)
Reviewed-by: Maxime Coquelin <maxime.coquelin@rehat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost/crypto: fix descriptor move
2018-05-09 14:08 [PATCH] vhost/crypto: fix descriptor move Fan Zhang
2018-05-16 6:11 ` Maxime Coquelin
@ 2018-05-16 10:54 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2018-05-16 10:54 UTC (permalink / raw)
To: Fan Zhang, dev
On 05/09/2018 04:08 PM, Fan Zhang wrote:
> This patch fixes the redundant descriptor move in the copy mode
> of vhost crypto. Originally the redundant descriptor move will
> cause the message parsing error.
>
> Signed-off-by: Fan Zhang<roy.fan.zhang@intel.com>
> ---
> lib/librte_vhost/vhost_crypto.c | 5 -----
> 1 file changed, 5 deletions(-)
Applied to dpdk-next-virtio.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-16 10:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-09 14:08 [PATCH] vhost/crypto: fix descriptor move Fan Zhang
2018-05-16 6:11 ` Maxime Coquelin
2018-05-16 10:54 ` Maxime Coquelin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.