* [Buildroot] [PATCH] package/nodejs: requires gcc 4.9
@ 2019-03-15 9:22 Baruch Siach
2019-03-15 20:46 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Baruch Siach @ 2019-03-15 9:22 UTC (permalink / raw)
To: buildroot
BUILDING.md lists gcc 4.9.4 or newer as build prerequisite. This is
needed for full C++11 support.
https://github.com/nodejs/node/commit/d13a65ad68c429884434cdcd94c52b79a6d69717
Cc: Daniel Price <daniel.price@gmail.com>
Reported-by: Boris-Ben Shapiro <erectcrested@gmail.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/nodejs/Config.in | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
index d2846f8d579d..ed6225b08efb 100644
--- a/package/nodejs/Config.in
+++ b/package/nodejs/Config.in
@@ -7,19 +7,19 @@ config BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
# libuv
depends on BR2_TOOLCHAIN_HAS_SYNC_4
-comment "nodejs needs a toolchain w/ C++, dynamic library, NPTL, gcc >= 4.8, wchar"
+comment "nodejs needs a toolchain w/ C++, dynamic library, NPTL, gcc >= 4.9, wchar"
depends on BR2_USE_MMU
depends on BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
- !BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || !BR2_USE_WCHAR
+ !BR2_HOST_GCC_AT_LEAST_4_9 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || !BR2_USE_WCHAR
config BR2_PACKAGE_NODEJS
bool "nodejs"
depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # libuv
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
- depends on BR2_HOST_GCC_AT_LEAST_4_8
- depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+ depends on BR2_HOST_GCC_AT_LEAST_4_9
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
depends on BR2_USE_WCHAR
# uses fork()
depends on BR2_USE_MMU
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] package/nodejs: requires gcc 4.9
2019-03-15 9:22 [Buildroot] [PATCH] package/nodejs: requires gcc 4.9 Baruch Siach
@ 2019-03-15 20:46 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2019-03-15 20:46 UTC (permalink / raw)
To: buildroot
On Fri, 15 Mar 2019 11:22:04 +0200
Baruch Siach <baruch@tkos.co.il> wrote:
> BUILDING.md lists gcc 4.9.4 or newer as build prerequisite. This is
> needed for full C++11 support.
>
> https://github.com/nodejs/node/commit/d13a65ad68c429884434cdcd94c52b79a6d69717
>
> Cc: Daniel Price <daniel.price@gmail.com>
> Reported-by: Boris-Ben Shapiro <erectcrested@gmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/nodejs/Config.in | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-15 20:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-15 9:22 [Buildroot] [PATCH] package/nodejs: requires gcc 4.9 Baruch Siach
2019-03-15 20:46 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.