All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: lorenzo.pieralisi@arm.com
Cc: linux-pci@vger.kernel.org, linux-imx@nxp.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de,
	Richard Zhu <hongxing.zhu@nxp.com>,
	andrew.smirnov@gmail.com, shawnguo@kernel.org, kw@linux.com,
	bhelgaas@google.com, stefan@agner.ch
Subject: Re: [RESEND v4 1/2] dt-bindings: imx6q-pcie: add one regulator used to power up pcie phy
Date: Thu, 06 May 2021 18:08:24 +0200	[thread overview]
Message-ID: <7900502879b346e18727f956965ace34a146c0f1.camel@pengutronix.de> (raw)
In-Reply-To: <1617091701-6444-2-git-send-email-hongxing.zhu@nxp.com>

Hi Lorenzo,

have those two patches fallen through some crack? AFAICS they are gone
from patchwork, but I also can't find them in any branch in the usual
git repos.

Regards,
Lucas

Am Dienstag, dem 30.03.2021 um 16:08 +0800 schrieb Richard Zhu:
> Both 1.8v and 3.3v power supplies can be used by i.MX8MQ PCIe PHY.
> In default, the PCIE_VPH voltage is suggested to be 1.8v refer to data
> sheet. When PCIE_VPH is supplied by 3.3v in the HW schematic design,
> the VREG_BYPASS bits of GPR registers should be cleared from default
> value 1b'1 to 1b'0. Thus, the internal 3v3 to 1v8 translator would be
> turned on.
> 
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> index de4b2baf91e8..d8971ab99274 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> @@ -38,6 +38,9 @@ Optional properties:
>    The regulator will be enabled when initializing the PCIe host and
>    disabled either as part of the init process or when shutting down the
>    host.
> +- vph-supply: Should specify the regulator in charge of VPH one of the three
> +  PCIe PHY powers. This regulator can be supplied by both 1.8v and 3.3v voltage
> +  supplies.
>  
> 
>  Additional required properties for imx6sx-pcie:
>  - clock names: Must include the following additional entries:



WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de>
To: lorenzo.pieralisi@arm.com
Cc: linux-pci@vger.kernel.org, linux-imx@nxp.com,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,  kernel@pengutronix.de,
	Richard Zhu <hongxing.zhu@nxp.com>,
	 andrew.smirnov@gmail.com, shawnguo@kernel.org, kw@linux.com,
	bhelgaas@google.com,  stefan@agner.ch
Subject: Re: [RESEND v4 1/2] dt-bindings: imx6q-pcie: add one regulator used to power up pcie phy
Date: Thu, 06 May 2021 18:08:24 +0200	[thread overview]
Message-ID: <7900502879b346e18727f956965ace34a146c0f1.camel@pengutronix.de> (raw)
In-Reply-To: <1617091701-6444-2-git-send-email-hongxing.zhu@nxp.com>

Hi Lorenzo,

have those two patches fallen through some crack? AFAICS they are gone
from patchwork, but I also can't find them in any branch in the usual
git repos.

Regards,
Lucas

Am Dienstag, dem 30.03.2021 um 16:08 +0800 schrieb Richard Zhu:
> Both 1.8v and 3.3v power supplies can be used by i.MX8MQ PCIe PHY.
> In default, the PCIE_VPH voltage is suggested to be 1.8v refer to data
> sheet. When PCIE_VPH is supplied by 3.3v in the HW schematic design,
> the VREG_BYPASS bits of GPR registers should be cleared from default
> value 1b'1 to 1b'0. Thus, the internal 3v3 to 1v8 translator would be
> turned on.
> 
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> index de4b2baf91e8..d8971ab99274 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> @@ -38,6 +38,9 @@ Optional properties:
>    The regulator will be enabled when initializing the PCIe host and
>    disabled either as part of the init process or when shutting down the
>    host.
> +- vph-supply: Should specify the regulator in charge of VPH one of the three
> +  PCIe PHY powers. This regulator can be supplied by both 1.8v and 3.3v voltage
> +  supplies.
>  
> 
>  Additional required properties for imx6sx-pcie:
>  - clock names: Must include the following additional entries:



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-05-06 16:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30  8:08 [RESEND v4 0/2] add one regulator used to power up pcie phy Richard Zhu
2021-03-30  8:08 ` Richard Zhu
2021-03-30  8:08 ` [RESEND v4 1/2] dt-bindings: imx6q-pcie: " Richard Zhu
2021-03-30  8:08   ` Richard Zhu
2021-05-06 16:08   ` Lucas Stach [this message]
2021-05-06 16:08     ` Lucas Stach
2021-05-06 21:01     ` Bjorn Helgaas
2021-05-06 21:01       ` Bjorn Helgaas
2021-05-14  8:35       ` [EXT] " Richard Zhu
2021-05-14  8:35         ` Richard Zhu
2021-03-30  8:08 ` [RESEND v4 2/2] PCI: imx: clear vreg bypass when pcie vph voltage is 3v3 Richard Zhu
2021-03-30  8:08   ` Richard Zhu
2021-05-06 21:09   ` Bjorn Helgaas
2021-05-06 21:09     ` Bjorn Helgaas
2021-05-14  8:36     ` [EXT] " Richard Zhu
2021-05-14  8:36       ` Richard Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7900502879b346e18727f956965ace34a146c0f1.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=andrew.smirnov@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=hongxing.zhu@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=kw@linux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=shawnguo@kernel.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.