From: Thor Thayer <thor.thayer@linux.intel.com>
To: Vivek Gautam <vivek.gautam@codeaurora.org>,
dinguyen@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
will.deacon@arm.com, robin.murphy@arm.com, joro@8bytes.org,
aisheng.dong@nxp.com, sboyd@kernel.org
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org
Subject: Re: [PATCHv3 2/2] iommu/arm-smmu: Add SMMU clock
Date: Thu, 4 Oct 2018 16:00:48 -0500 [thread overview]
Message-ID: <793d47b7-cb56-9017-2030-e248921ccab4@linux.intel.com> (raw)
In-Reply-To: <1898b9fb-0523-4de4-741a-a52de5fdab70@codeaurora.org>
Hi Vivek,
On 10/04/2018 01:49 PM, Vivek Gautam wrote:
> Hi Thor,
>
>
> On 10/4/2018 3:58 AM, thor.thayer@linux.intel.com wrote:
>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>
>> Add a clock to the SMMU structure. In the device tree case,
>> check for a clock node and enable the clock if found.
>>
>> This patch is dependent upon the following patches that add
>> a device tree bulk clock function.
>> "[V6, 1/4] clk: bulk: add of_clk_bulk_get()"
>> https://patchwork.kernel.org/patch/10583133/
>> "[V6, 2/4] clk: add new APIs to operation on all available
>> clocks"
>> https://patchwork.kernel.org/patch/10583131/
>> "[V6, 3/4] clk: add managed version of clk_bulk_get_all"
>> https://patchwork.kernel.org/patch/10583139/
>>
>> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
>> ---
>> drivers/iommu/arm-smmu.c | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>
> The clock part is already handled by one of the patch in the
> runtime pm series of arm-smmu [1]. This patch should not be needed.
>
> [1] https://patchwork.kernel.org/patch/10581899/
>
> [...]
>
> Regards
> Vivek
>
Thanks. FYI, I had problems applying [v16,2/5] on [1] but was able to
apply [v17,2/5] cleanly.
The bigger issue is that with your patchset I need to create a new
structure for my variation of the ARM SMMUv2 due to the
of_device_get_match_data() call in arm_smmu_device_dt_probe(). I want to
use the default arm_mmu500 but it doesn't have a clock specified and I
end up with num_clks of 0.
Creating a new smmu_match_data structure for each variant feels wrong
because I have the clock data specified in my device tree. The
of_clk_bulk_get() call handles this nicely but that patchset isn't
getting much attention.
I'll investigate adding the of_clk_bulk_get() call on top of your
patches. This may simplify your patches too since the additional
structures in [v16,5/5] wouldn't be needed.
Thanks,
Thor
[1] git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git - next
WARNING: multiple messages have this Message-ID (diff)
From: thor.thayer@linux.intel.com (Thor Thayer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 2/2] iommu/arm-smmu: Add SMMU clock
Date: Thu, 4 Oct 2018 16:00:48 -0500 [thread overview]
Message-ID: <793d47b7-cb56-9017-2030-e248921ccab4@linux.intel.com> (raw)
In-Reply-To: <1898b9fb-0523-4de4-741a-a52de5fdab70@codeaurora.org>
Hi Vivek,
On 10/04/2018 01:49 PM, Vivek Gautam wrote:
> Hi Thor,
>
>
> On 10/4/2018 3:58 AM, thor.thayer at linux.intel.com wrote:
>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>
>> Add a clock to the SMMU structure. In the device tree case,
>> check for a clock node and enable the clock if found.
>>
>> This patch is dependent upon the following patches that add
>> a device tree bulk clock function.
>> "[V6, 1/4] clk: bulk: add of_clk_bulk_get()"
>> https://patchwork.kernel.org/patch/10583133/
>> "[V6, 2/4] clk: add new APIs to operation on all available
>> clocks"
>> https://patchwork.kernel.org/patch/10583131/
>> "[V6, 3/4] clk: add managed version of clk_bulk_get_all"
>> https://patchwork.kernel.org/patch/10583139/
>>
>> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
>> ---
>> ? drivers/iommu/arm-smmu.c | 20 ++++++++++++++++++++
>> ? 1 file changed, 20 insertions(+)
>
> The clock part is already handled by one of the patch in the
> runtime pm series of arm-smmu [1]. This patch should not be needed.
>
> [1] https://patchwork.kernel.org/patch/10581899/
>
> [...]
>
> Regards
> Vivek
>
Thanks. FYI, I had problems applying [v16,2/5] on [1] but was able to
apply [v17,2/5] cleanly.
The bigger issue is that with your patchset I need to create a new
structure for my variation of the ARM SMMUv2 due to the
of_device_get_match_data() call in arm_smmu_device_dt_probe(). I want to
use the default arm_mmu500 but it doesn't have a clock specified and I
end up with num_clks of 0.
Creating a new smmu_match_data structure for each variant feels wrong
because I have the clock data specified in my device tree. The
of_clk_bulk_get() call handles this nicely but that patchset isn't
getting much attention.
I'll investigate adding the of_clk_bulk_get() call on top of your
patches. This may simplify your patches too since the additional
structures in [v16,5/5] wouldn't be needed.
Thanks,
Thor
[1] git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git - next
next prev parent reply other threads:[~2018-10-04 21:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 22:28 [PATCHv3 0/2] iommu/arm-smmu: Add Stratix10 SMMU Support thor.thayer
2018-10-03 22:28 ` thor.thayer at linux.intel.com
2018-10-03 22:28 ` thor.thayer-VuQAYsv1563Yd54FQh9/CA
2018-10-03 22:28 ` [PATCHv3 1/2] arm64: dts: stratix10: Add Stratix10 SMMU support thor.thayer
2018-10-03 22:28 ` thor.thayer at linux.intel.com
2018-10-03 22:28 ` [PATCHv3 2/2] iommu/arm-smmu: Add SMMU clock thor.thayer
2018-10-03 22:28 ` thor.thayer at linux.intel.com
2018-10-04 18:49 ` Vivek Gautam
2018-10-04 18:49 ` Vivek Gautam
2018-10-04 18:49 ` Vivek Gautam
2018-10-04 21:00 ` Thor Thayer [this message]
2018-10-04 21:00 ` Thor Thayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=793d47b7-cb56-9017-2030-e248921ccab4@linux.intel.com \
--to=thor.thayer@linux.intel.com \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sboyd@kernel.org \
--cc=vivek.gautam@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.