From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: Xin Long <lucien.xin@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Vlad Yasevich <vyasevic@redhat.com>,
Daniel Borkmann <daniel@iogearbox.net>,
David Miller <davem@davemloft.net>,
"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>,
Michael Tuexen <Michael.Tuexen@lurchi.franken.de>,
Eric Dumazet <edumazet@google.com>,
Brenda Butler <bjb@mojatatu.com>,
gabor@mojatatu.com
Subject: Re: send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_packet_transmit
Date: Tue, 25 Oct 2016 07:04:02 -0400 [thread overview]
Message-ID: <7aa1de3e-19c4-91bd-c0d6-a61f32fa6876@mojatatu.com> (raw)
In-Reply-To: <20161025103416.GG2958@localhost.localdomain>
On 16-10-25 06:34 AM, Marcelo Ricardo Leitner wrote:
> On Tue, Oct 25, 2016 at 05:05:41PM +0800, Xin Long wrote:
>>>> in case [1], user can't see the ENOMEM, ENOMEM is more like
>
> Thing is, it may lead to duplicate messages in Application layer, as the
> msg that was errored out may have been actually queued and later
> retransmitted.
>
> That's why I said the recovery steps from this depends on the
> application on top of SCTP, if it can handle such duplicate messages or
> not.
Yes, I was worried about duplicate messages.
Which is a bug on SCTP implementation on Linux, unfortunately. IOW,
transport should take care of duplicates - not the app.
i.e any app change is a workaround which will be unnecessary in newer
kernels.
cheers,
jamal
WARNING: multiple messages have this Message-ID (diff)
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: Xin Long <lucien.xin@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Vlad Yasevich <vyasevic@redhat.com>,
Daniel Borkmann <daniel@iogearbox.net>,
David Miller <davem@davemloft.net>,
"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>,
Michael Tuexen <Michael.Tuexen@lurchi.franken.de>,
Eric Dumazet <edumazet@google.com>,
Brenda Butler <bjb@mojatatu.com>,
gabor@mojatatu.com
Subject: Re: send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_pack
Date: Tue, 25 Oct 2016 11:04:02 +0000 [thread overview]
Message-ID: <7aa1de3e-19c4-91bd-c0d6-a61f32fa6876@mojatatu.com> (raw)
In-Reply-To: <20161025103416.GG2958@localhost.localdomain>
On 16-10-25 06:34 AM, Marcelo Ricardo Leitner wrote:
> On Tue, Oct 25, 2016 at 05:05:41PM +0800, Xin Long wrote:
>>>> in case [1], user can't see the ENOMEM, ENOMEM is more like
>
> Thing is, it may lead to duplicate messages in Application layer, as the
> msg that was errored out may have been actually queued and later
> retransmitted.
>
> That's why I said the recovery steps from this depends on the
> application on top of SCTP, if it can handle such duplicate messages or
> not.
Yes, I was worried about duplicate messages.
Which is a bug on SCTP implementation on Linux, unfortunately. IOW,
transport should take care of duplicates - not the app.
i.e any app change is a workaround which will be unnecessary in newer
kernels.
cheers,
jamal
next prev parent reply other threads:[~2016-10-25 11:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 15:03 send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_packet_t Jamal Hadi Salim
2016-10-23 15:32 ` Fwd: send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_packet_transmit Jamal Hadi Salim
2016-10-23 15:32 ` Fwd: send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_pac Jamal Hadi Salim
2016-10-23 18:20 ` send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_packet_transmit Xin Long
2016-10-23 18:20 ` send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_pack Xin Long
2016-10-23 19:52 ` send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_packet_transmit Jamal Hadi Salim
2016-10-23 19:52 ` send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_pack Jamal Hadi Salim
2016-10-24 6:30 ` send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_packet_transmit Xin Long
2016-10-24 6:30 ` send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_pack Xin Long
2016-10-24 11:48 ` send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_packet_transmit Marcelo Ricardo Leitner
2016-10-24 11:48 ` send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_pack Marcelo Ricardo Leitner
2016-10-24 12:38 ` send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_packet_transmit Jamal Hadi Salim
2016-10-24 12:38 ` send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_pack Jamal Hadi Salim
2016-10-25 9:05 ` send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_packet_transmit Xin Long
2016-10-25 9:05 ` send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_pack Xin Long
2016-10-25 10:34 ` send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_packet_transmit Marcelo Ricardo Leitner
2016-10-25 10:34 ` send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_pack Marcelo Ricardo Leitner
2016-10-25 11:04 ` Jamal Hadi Salim [this message]
2016-10-25 11:04 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7aa1de3e-19c4-91bd-c0d6-a61f32fa6876@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=Michael.Tuexen@lurchi.franken.de \
--cc=bjb@mojatatu.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gabor@mojatatu.com \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.