All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage
@ 2018-09-13  1:13 ` Josh Abraham
  0 siblings, 0 replies; 8+ messages in thread
From: Josh Abraham @ 2018-09-13  1:13 UTC (permalink / raw)
  To: boris.ostrovsky
  Cc: jgross, aams, roger.pau, xen-devel, kernel-janitors,
	linux-kernel, j.abraham1776

This patch removes duplicate macro useage in events_base.c.

It also fixes gcc warning:
variable ‘col’ set but not used [-Wunused-but-set-variable]

Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>
---
 drivers/xen/events/events_base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
index 08e4af04d6f2..e6c1934734b7 100644
--- a/drivers/xen/events/events_base.c
+++ b/drivers/xen/events/events_base.c
@@ -138,7 +138,7 @@ static int set_evtchn_to_irq(unsigned evtchn, unsigned irq)
 		clear_evtchn_to_irq_row(row);
 	}
 
-	evtchn_to_irq[EVTCHN_ROW(evtchn)][EVTCHN_COL(evtchn)] = irq;
+	evtchn_to_irq[row][col] = irq;
 	return 0;
 }
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage
@ 2018-09-13  1:13 ` Josh Abraham
  0 siblings, 0 replies; 8+ messages in thread
From: Josh Abraham @ 2018-09-13  1:13 UTC (permalink / raw)
  To: boris.ostrovsky
  Cc: jgross, aams, roger.pau, xen-devel, kernel-janitors,
	linux-kernel, j.abraham1776

This patch removes duplicate macro useage in events_base.c.

It also fixes gcc warning:
variable ‘col’ set but not used [-Wunused-but-set-variable]

Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>
---
 drivers/xen/events/events_base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
index 08e4af04d6f2..e6c1934734b7 100644
--- a/drivers/xen/events/events_base.c
+++ b/drivers/xen/events/events_base.c
@@ -138,7 +138,7 @@ static int set_evtchn_to_irq(unsigned evtchn, unsigned irq)
 		clear_evtchn_to_irq_row(row);
 	}
 
-	evtchn_to_irq[EVTCHN_ROW(evtchn)][EVTCHN_COL(evtchn)] = irq;
+	evtchn_to_irq[row][col] = irq;
 	return 0;
 }
 
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage
  2018-09-13  1:13 ` Josh Abraham
@ 2018-09-13  5:13   ` Juergen Gross
  -1 siblings, 0 replies; 8+ messages in thread
From: Juergen Gross @ 2018-09-13  5:13 UTC (permalink / raw)
  To: Josh Abraham, boris.ostrovsky
  Cc: aams, roger.pau, xen-devel, kernel-janitors, linux-kernel

On 13/09/18 03:13, Josh Abraham wrote:
> This patch removes duplicate macro useage in events_base.c.
> 
> It also fixes gcc warning:
> variable ‘col’ set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage
@ 2018-09-13  5:13   ` Juergen Gross
  0 siblings, 0 replies; 8+ messages in thread
From: Juergen Gross @ 2018-09-13  5:13 UTC (permalink / raw)
  To: Josh Abraham, boris.ostrovsky
  Cc: aams, roger.pau, xen-devel, kernel-janitors, linux-kernel

On 13/09/18 03:13, Josh Abraham wrote:
> This patch removes duplicate macro useage in events_base.c.
> 
> It also fixes gcc warning:
> variable ‘col’ set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage
  2018-09-13  1:13 ` Josh Abraham
  (?)
  (?)
@ 2018-09-13  5:13 ` Juergen Gross
  -1 siblings, 0 replies; 8+ messages in thread
From: Juergen Gross @ 2018-09-13  5:13 UTC (permalink / raw)
  To: Josh Abraham, boris.ostrovsky
  Cc: xen-devel, kernel-janitors, aams, linux-kernel, roger.pau

On 13/09/18 03:13, Josh Abraham wrote:
> This patch removes duplicate macro useage in events_base.c.
> 
> It also fixes gcc warning:
> variable ‘col’ set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Xen-devel] [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage
  2018-09-13  5:13   ` Juergen Gross
@ 2018-09-13 22:59     ` Boris Ostrovsky
  -1 siblings, 0 replies; 8+ messages in thread
From: Boris Ostrovsky @ 2018-09-13 22:59 UTC (permalink / raw)
  To: Juergen Gross, Josh Abraham
  Cc: xen-devel, kernel-janitors, aams, linux-kernel, roger.pau

On 9/13/18 1:13 AM, Juergen Gross wrote:
> On 13/09/18 03:13, Josh Abraham wrote:
>> This patch removes duplicate macro useage in events_base.c.
>>
>> It also fixes gcc warning:
>> variable ‘col’ set but not used [-Wunused-but-set-variable]
>>
>> Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>

Applied to for-linux-4.19b.

-boris

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Xen-devel] [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage
@ 2018-09-13 22:59     ` Boris Ostrovsky
  0 siblings, 0 replies; 8+ messages in thread
From: Boris Ostrovsky @ 2018-09-13 22:59 UTC (permalink / raw)
  To: Juergen Gross, Josh Abraham
  Cc: xen-devel, kernel-janitors, aams, linux-kernel, roger.pau

On 9/13/18 1:13 AM, Juergen Gross wrote:
> On 13/09/18 03:13, Josh Abraham wrote:
>> This patch removes duplicate macro useage in events_base.c.
>>
>> It also fixes gcc warning:
>> variable ‘col’ set but not used [-Wunused-but-set-variable]
>>
>> Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>

Applied to for-linux-4.19b.

-boris

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage
  2018-09-13  5:13   ` Juergen Gross
  (?)
@ 2018-09-13 22:59   ` Boris Ostrovsky
  -1 siblings, 0 replies; 8+ messages in thread
From: Boris Ostrovsky @ 2018-09-13 22:59 UTC (permalink / raw)
  To: Juergen Gross, Josh Abraham
  Cc: xen-devel, roger.pau, kernel-janitors, linux-kernel, aams

On 9/13/18 1:13 AM, Juergen Gross wrote:
> On 13/09/18 03:13, Josh Abraham wrote:
>> This patch removes duplicate macro useage in events_base.c.
>>
>> It also fixes gcc warning:
>> variable ‘col’ set but not used [-Wunused-but-set-variable]
>>
>> Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>

Applied to for-linux-4.19b.

-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-09-13 22:59 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-13  1:13 [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage Josh Abraham
2018-09-13  1:13 ` Josh Abraham
2018-09-13  5:13 ` Juergen Gross
2018-09-13  5:13   ` Juergen Gross
2018-09-13 22:59   ` Boris Ostrovsky
2018-09-13 22:59   ` [Xen-devel] " Boris Ostrovsky
2018-09-13 22:59     ` Boris Ostrovsky
2018-09-13  5:13 ` Juergen Gross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.