From: Jason Wang <jasowang@redhat.com> To: Halil Pasic <pasic@linux.ibm.com>, Cornelia Huck <cohuck@redhat.com> Cc: "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, sgarzare@redhat.com, eperezma@redhat.com, lulu@redhat.com, tglx@linutronix.de, peterz@infradead.org, paulmck@kernel.org, maz@kernel.org Subject: Re: [PATCH V3 6/9] virtio-ccw: implement synchronize_cbs() Date: Tue, 26 Apr 2022 11:46:08 +0800 [thread overview] Message-ID: <7f459ca6-0564-7206-adb2-6abc01c95a6d@redhat.com> (raw) In-Reply-To: <20220426045050.4697c833.pasic@linux.ibm.com> 在 2022/4/26 10:50, Halil Pasic 写道: >>>> +static void virtio_ccw_synchronize_cbs(struct virtio_device *vdev) >>>> +{ >>>> + struct virtio_ccw_device *vcdev = to_vc_device(vdev); >>>> + struct airq_info *info = vcdev->airq_info; >>>> + >>>> + /* >>>> + * Synchronize with the vring_interrupt() called by >>>> + * virtio_ccw_int_handler(). >>>> + */ >>>> + spin_lock(&vcdev->irq_lock); >>>> + spin_unlock(&vcdev->irq_lock); >>>> + >>>> + if (info) { >>>> + /* >>>> + * Synchronize with the vring_interrupt() with airq indicator >>>> + */ >>>> + write_lock(&info->lock); >>>> + write_unlock(&info->lock); >>>> + } >> I think we can make this an either/or operation (devices will either use >> classic interrupts or adapter interrupts)? > Right, for virtqueue notifications. I second Connie's motion! Will do this. Thanks >
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Halil Pasic <pasic@linux.ibm.com>, Cornelia Huck <cohuck@redhat.com> Cc: paulmck@kernel.org, lulu@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>, peterz@infradead.org, maz@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, eperezma@redhat.com, tglx@linutronix.de Subject: Re: [PATCH V3 6/9] virtio-ccw: implement synchronize_cbs() Date: Tue, 26 Apr 2022 11:46:08 +0800 [thread overview] Message-ID: <7f459ca6-0564-7206-adb2-6abc01c95a6d@redhat.com> (raw) In-Reply-To: <20220426045050.4697c833.pasic@linux.ibm.com> 在 2022/4/26 10:50, Halil Pasic 写道: >>>> +static void virtio_ccw_synchronize_cbs(struct virtio_device *vdev) >>>> +{ >>>> + struct virtio_ccw_device *vcdev = to_vc_device(vdev); >>>> + struct airq_info *info = vcdev->airq_info; >>>> + >>>> + /* >>>> + * Synchronize with the vring_interrupt() called by >>>> + * virtio_ccw_int_handler(). >>>> + */ >>>> + spin_lock(&vcdev->irq_lock); >>>> + spin_unlock(&vcdev->irq_lock); >>>> + >>>> + if (info) { >>>> + /* >>>> + * Synchronize with the vring_interrupt() with airq indicator >>>> + */ >>>> + write_lock(&info->lock); >>>> + write_unlock(&info->lock); >>>> + } >> I think we can make this an either/or operation (devices will either use >> classic interrupts or adapter interrupts)? > Right, for virtqueue notifications. I second Connie's motion! Will do this. Thanks > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-04-26 3:46 UTC|newest] Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-25 2:44 [PATCH V3 0/9] rework on the IRQ hardening of virtio Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-25 2:44 ` [PATCH V3 1/9] virtio: use virtio_device_ready() in virtio_device_restore() Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-28 9:07 ` Cornelia Huck 2022-04-28 9:07 ` Cornelia Huck 2022-04-25 2:44 ` [PATCH V3 2/9] virtio: use virtio_reset_device() when possible Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-28 9:07 ` Cornelia Huck 2022-04-28 9:07 ` Cornelia Huck 2022-04-25 2:44 ` [PATCH V3 3/9] virtio: introduce config op to synchronize vring callbacks Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-28 9:13 ` Cornelia Huck 2022-04-28 9:13 ` Cornelia Huck 2022-04-29 2:08 ` Jason Wang 2022-04-29 2:08 ` Jason Wang 2022-04-29 7:25 ` Cornelia Huck 2022-04-29 7:25 ` Cornelia Huck 2022-05-05 8:15 ` Jason Wang 2022-05-05 8:15 ` Jason Wang 2022-04-25 2:44 ` [PATCH V3 4/9] virtio-pci: implement synchronize_cbs() Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-25 2:44 ` [PATCH V3 5/9] virtio-mmio: " Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-25 2:44 ` [PATCH V3 6/9] virtio-ccw: " Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-25 8:08 ` Michael S. Tsirkin 2022-04-25 8:08 ` Michael S. Tsirkin 2022-04-25 8:54 ` Cornelia Huck 2022-04-25 8:54 ` Cornelia Huck 2022-04-25 13:59 ` Michael S. Tsirkin 2022-04-25 13:59 ` Michael S. Tsirkin 2022-04-26 2:29 ` Halil Pasic 2022-04-26 2:29 ` Halil Pasic 2022-04-26 3:35 ` Michael S. Tsirkin 2022-04-26 3:35 ` Michael S. Tsirkin 2022-04-26 3:38 ` Michael S. Tsirkin 2022-04-26 3:38 ` Michael S. Tsirkin 2022-04-26 3:42 ` Jason Wang 2022-04-26 3:42 ` Jason Wang 2022-04-26 3:53 ` Michael S. Tsirkin 2022-04-26 3:53 ` Michael S. Tsirkin 2022-04-26 3:55 ` Michael S. Tsirkin 2022-04-26 3:55 ` Michael S. Tsirkin 2022-04-26 4:07 ` Jason Wang 2022-04-26 4:07 ` Jason Wang 2022-04-26 6:30 ` Michael S. Tsirkin 2022-04-26 6:30 ` Michael S. Tsirkin 2022-04-27 3:53 ` Jason Wang 2022-04-27 3:53 ` Jason Wang 2022-04-27 6:28 ` Michael S. Tsirkin 2022-04-27 6:28 ` Michael S. Tsirkin 2022-04-27 6:30 ` Michael S. Tsirkin 2022-04-27 6:30 ` Michael S. Tsirkin 2022-04-27 7:57 ` Jason Wang 2022-04-27 7:57 ` Jason Wang 2022-04-27 15:15 ` Michael S. Tsirkin 2022-04-27 15:15 ` Michael S. Tsirkin 2022-04-26 15:47 ` Cornelia Huck 2022-04-26 15:47 ` Cornelia Huck 2022-04-26 16:43 ` Michael S. Tsirkin 2022-04-26 16:43 ` Michael S. Tsirkin 2022-04-27 9:27 ` Cornelia Huck 2022-04-27 9:27 ` Cornelia Huck 2022-04-28 2:43 ` Halil Pasic 2022-04-28 2:43 ` Halil Pasic 2022-04-28 3:04 ` Jason Wang 2022-04-28 3:04 ` Jason Wang 2022-04-28 5:24 ` Michael S. Tsirkin 2022-04-28 5:24 ` Michael S. Tsirkin 2022-04-28 5:51 ` Jason Wang 2022-04-28 5:51 ` Jason Wang 2022-04-28 5:55 ` Michael S. Tsirkin 2022-04-28 5:55 ` Michael S. Tsirkin 2022-04-28 6:02 ` Jason Wang 2022-04-28 6:02 ` Jason Wang 2022-04-28 6:17 ` Michael S. Tsirkin 2022-04-28 6:17 ` Michael S. Tsirkin 2022-04-28 7:42 ` Cornelia Huck 2022-04-28 7:42 ` Cornelia Huck 2022-04-29 2:02 ` Jason Wang 2022-04-29 2:02 ` Jason Wang 2022-04-28 4:12 ` Michael S. Tsirkin 2022-04-28 4:12 ` Michael S. Tsirkin 2022-04-26 2:50 ` Halil Pasic 2022-04-26 2:50 ` Halil Pasic 2022-04-26 3:46 ` Jason Wang [this message] 2022-04-26 3:46 ` Jason Wang [not found] ` <20220426053856.3325-1-hdanton@sina.com> 2022-04-26 5:59 ` Jason Wang 2022-04-25 2:44 ` [PATCH V3 7/9] virtio: allow to unbreak virtqueue Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-25 12:44 ` Cornelia Huck 2022-04-25 12:44 ` Cornelia Huck 2022-04-25 14:04 ` Michael S. Tsirkin 2022-04-25 14:04 ` Michael S. Tsirkin 2022-04-26 3:45 ` Jason Wang 2022-04-26 3:45 ` Jason Wang 2022-04-25 2:44 ` [PATCH V3 8/9] virtio: harden vring IRQ Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-25 2:44 ` [PATCH V3 9/9] virtio: use WARN_ON() to warning illegal status value Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-25 2:49 ` [PATCH V3 0/9] rework on the IRQ hardening of virtio Jason Wang 2022-04-25 2:49 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7f459ca6-0564-7206-adb2-6abc01c95a6d@redhat.com \ --to=jasowang@redhat.com \ --cc=cohuck@redhat.com \ --cc=eperezma@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lulu@redhat.com \ --cc=maz@kernel.org \ --cc=mst@redhat.com \ --cc=pasic@linux.ibm.com \ --cc=paulmck@kernel.org \ --cc=peterz@infradead.org \ --cc=sgarzare@redhat.com \ --cc=tglx@linutronix.de \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.