From: Logan Gunthorpe <logang@deltatee.com> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, linux-pci@vger.kernel.org, "Linux Documentation List" <linux-doc@vger.kernel.org>, "Stephen Bates" <sbates@raithlin.com>, "Christoph Hellwig" <hch@lst.de>, "Bjorn Helgaas" <bhelgaas@google.com>, "Jonathan Corbet" <corbet@lwn.net>, "Ingo Molnar" <mingo@kernel.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, "Marc Zyngier" <marc.zyngier@arm.com>, "Kai-Heng Feng" <kai.heng.feng@canonical.com>, "Frederic Weisbecker" <frederic@kernel.org>, "Dan Williams" <dan.j.williams@intel.com>, "Jérôme Glisse" <jglisse@redhat.com>, "Benjamin Herrenschmidt" <benh@kernel.crashing.org>, "Alex Williamson" <alex.williamson@redhat.com>, "Christian König" <christian.koenig@amd.com> Subject: Re: [PATCH v2 1/3] PCI: Make specifying PCI devices in kernel parameters reusable Date: Fri, 1 Jun 2018 09:46:05 -0600 [thread overview] Message-ID: <806279a8-1faa-7b86-f761-15eb95b10887@deltatee.com> (raw) In-Reply-To: <CAHp75VcQwDGqND8v1RTo4+6Hyf9G5_2w9x9aiVONwKXsTKgJ1Q@mail.gmail.com> On 01/06/18 04:39 AM, Andy Shevchenko wrote: >> - pci=option[,option...] [PCI] various PCI subsystem options: >> + pci=option[,option...] [PCI] various PCI subsystem options. >> + >> + Some options herein operate on a specific device >> + or a set of devices (<pci_dev>). These are >> + specified in one of two formats: > > I would rather to add > > <pci_dev> > > here in the same way as done for options. > It would be easy for people to find a referenced paragraph. Sorry, I don't understand what you are asking. Can you be more specific? >> + >> + [<domain>:]<bus>:<slot>.<func> >> + pci:<vendor>:<device>[:<subvendor>:<subdevice>] >> + >> + Note: the first format specifies a PCI >> + bus/slot/function address which may change >> + if new hardware is inserted, if motherboard >> + firmware changes, or due to changes caused >> + by other kernel parameters. The second format >> + selects devices using IDs from the >> + configuration space which may match multiple >> + devices in the system. > >> +static int pci_dev_str_match(struct pci_dev *dev, const char *p, >> + const char **endptr) > > This change I hope has no functional alteration, so, can be split to a > separate patch. That's all this patch does... Or do you want be to separate out documentation from implementation? That just seems a bit excessive to me. Logan
WARNING: multiple messages have this Message-ID (diff)
From: Logan Gunthorpe <logang@deltatee.com> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, linux-pci@vger.kernel.org, "Linux Documentation List" <linux-doc@vger.kernel.org>, "Stephen Bates" <sbates@raithlin.com>, "Christoph Hellwig" <hch@lst.de>, "Bjorn Helgaas" <bhelgaas@google.com>, "Jonathan Corbet" <corbet@lwn.net>, "Ingo Molnar" <mingo@kernel.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, "Marc Zyngier" <marc.zyngier@arm.com>, "Kai-Heng Feng" <kai.heng.feng@canonical.com>, "Frederic Weisbecker" <frederic@kernel.org>, "Dan Williams" <dan.j.williams@intel.com>, "Jérôme Glisse" <jglisse@redhat.com>, "Benjamin Herrenschmidt" <benh@kernel.crashing.org>, "Alex Williamson" <alex.williamson@redhat.com>, "Christian König" <christian.koenig@amd.com> Subject: Re: [PATCH v2 1/3] PCI: Make specifying PCI devices in kernel parameters reusable Date: Fri, 1 Jun 2018 09:46:05 -0600 [thread overview] Message-ID: <806279a8-1faa-7b86-f761-15eb95b10887@deltatee.com> (raw) In-Reply-To: <CAHp75VcQwDGqND8v1RTo4+6Hyf9G5_2w9x9aiVONwKXsTKgJ1Q@mail.gmail.com> On 01/06/18 04:39 AM, Andy Shevchenko wrote: >> - pci=option[,option...] [PCI] various PCI subsystem options: >> + pci=option[,option...] [PCI] various PCI subsystem options. >> + >> + Some options herein operate on a specific device >> + or a set of devices (<pci_dev>). These are >> + specified in one of two formats: > > I would rather to add > > <pci_dev> > > here in the same way as done for options. > It would be easy for people to find a referenced paragraph. Sorry, I don't understand what you are asking. Can you be more specific? >> + >> + [<domain>:]<bus>:<slot>.<func> >> + pci:<vendor>:<device>[:<subvendor>:<subdevice>] >> + >> + Note: the first format specifies a PCI >> + bus/slot/function address which may change >> + if new hardware is inserted, if motherboard >> + firmware changes, or due to changes caused >> + by other kernel parameters. The second format >> + selects devices using IDs from the >> + configuration space which may match multiple >> + devices in the system. > >> +static int pci_dev_str_match(struct pci_dev *dev, const char *p, >> + const char **endptr) > > This change I hope has no functional alteration, so, can be split to a > separate patch. That's all this patch does... Or do you want be to separate out documentation from implementation? That just seems a bit excessive to me. Logan -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-06-01 15:46 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-31 23:50 [PATCH 0/3] Add parameter for disabling ACS redirection for P2P Logan Gunthorpe 2018-05-31 23:50 ` Logan Gunthorpe 2018-05-31 23:50 ` [PATCH v2 1/3] PCI: Make specifying PCI devices in kernel parameters reusable Logan Gunthorpe 2018-05-31 23:50 ` Logan Gunthorpe 2018-06-01 10:39 ` Andy Shevchenko 2018-06-01 10:39 ` Andy Shevchenko 2018-06-01 10:39 ` Andy Shevchenko 2018-06-01 15:46 ` Logan Gunthorpe [this message] 2018-06-01 15:46 ` Logan Gunthorpe 2018-05-31 23:50 ` [PATCH v2 2/3] PCI: Allow specifying devices using a base bus and path of devfns Logan Gunthorpe 2018-05-31 23:50 ` Logan Gunthorpe 2018-06-01 10:41 ` Andy Shevchenko 2018-06-01 10:41 ` Andy Shevchenko 2018-06-01 10:41 ` Andy Shevchenko 2018-06-01 15:46 ` Logan Gunthorpe 2018-06-01 15:46 ` Logan Gunthorpe 2018-06-01 14:30 ` Alex Williamson 2018-06-01 14:30 ` Alex Williamson 2018-06-01 15:47 ` Logan Gunthorpe 2018-06-01 15:47 ` Logan Gunthorpe 2018-05-31 23:50 ` [PATCH v2 3/3] PCI: Introduce the disable_acs_redir parameter Logan Gunthorpe 2018-05-31 23:50 ` Logan Gunthorpe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=806279a8-1faa-7b86-f761-15eb95b10887@deltatee.com \ --to=logang@deltatee.com \ --cc=alex.williamson@redhat.com \ --cc=andy.shevchenko@gmail.com \ --cc=benh@kernel.crashing.org \ --cc=bhelgaas@google.com \ --cc=christian.koenig@amd.com \ --cc=corbet@lwn.net \ --cc=dan.j.williams@intel.com \ --cc=frederic@kernel.org \ --cc=hch@lst.de \ --cc=jglisse@redhat.com \ --cc=kai.heng.feng@canonical.com \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=mingo@kernel.org \ --cc=paulmck@linux.vnet.ibm.com \ --cc=sbates@raithlin.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.