* [PATCH v2] linux-user/syscall: Constify bitmask_transtbl fcntl/mmap flags_tlb[]
@ 2021-05-17 5:52 Philippe Mathieu-Daudé
2021-05-25 7:50 ` Philippe Mathieu-Daudé
2021-06-05 19:13 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-05-17 5:52 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Bin Meng, Richard Henderson, Laurent Vivier,
Philippe Mathieu-Daudé
Keep bitmask_transtbl in .rodata by marking the arrays const.
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
linux-user/syscall.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 95d79ddc437..64f486743a9 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -365,7 +365,7 @@ _syscall5(int, sys_statx, int, dirfd, const char *, pathname, int, flags,
_syscall2(int, membarrier, int, cmd, int, flags)
#endif
-static bitmask_transtbl fcntl_flags_tbl[] = {
+static const bitmask_transtbl fcntl_flags_tbl[] = {
{ TARGET_O_ACCMODE, TARGET_O_WRONLY, O_ACCMODE, O_WRONLY, },
{ TARGET_O_ACCMODE, TARGET_O_RDWR, O_ACCMODE, O_RDWR, },
{ TARGET_O_CREAT, TARGET_O_CREAT, O_CREAT, O_CREAT, },
@@ -6062,7 +6062,7 @@ static const StructEntry struct_termios_def = {
.print = print_termios,
};
-static bitmask_transtbl mmap_flags_tbl[] = {
+static const bitmask_transtbl mmap_flags_tbl[] = {
{ TARGET_MAP_SHARED, TARGET_MAP_SHARED, MAP_SHARED, MAP_SHARED },
{ TARGET_MAP_PRIVATE, TARGET_MAP_PRIVATE, MAP_PRIVATE, MAP_PRIVATE },
{ TARGET_MAP_FIXED, TARGET_MAP_FIXED, MAP_FIXED, MAP_FIXED },
--
2.26.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] linux-user/syscall: Constify bitmask_transtbl fcntl/mmap flags_tlb[]
2021-05-17 5:52 [PATCH v2] linux-user/syscall: Constify bitmask_transtbl fcntl/mmap flags_tlb[] Philippe Mathieu-Daudé
@ 2021-05-25 7:50 ` Philippe Mathieu-Daudé
2021-06-05 19:13 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-05-25 7:50 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Bin Meng, Richard Henderson, Laurent Vivier
ping? (patch reviewed)
On 5/17/21 7:52 AM, Philippe Mathieu-Daudé wrote:
> Keep bitmask_transtbl in .rodata by marking the arrays const.
>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> linux-user/syscall.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 95d79ddc437..64f486743a9 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -365,7 +365,7 @@ _syscall5(int, sys_statx, int, dirfd, const char *, pathname, int, flags,
> _syscall2(int, membarrier, int, cmd, int, flags)
> #endif
>
> -static bitmask_transtbl fcntl_flags_tbl[] = {
> +static const bitmask_transtbl fcntl_flags_tbl[] = {
> { TARGET_O_ACCMODE, TARGET_O_WRONLY, O_ACCMODE, O_WRONLY, },
> { TARGET_O_ACCMODE, TARGET_O_RDWR, O_ACCMODE, O_RDWR, },
> { TARGET_O_CREAT, TARGET_O_CREAT, O_CREAT, O_CREAT, },
> @@ -6062,7 +6062,7 @@ static const StructEntry struct_termios_def = {
> .print = print_termios,
> };
>
> -static bitmask_transtbl mmap_flags_tbl[] = {
> +static const bitmask_transtbl mmap_flags_tbl[] = {
> { TARGET_MAP_SHARED, TARGET_MAP_SHARED, MAP_SHARED, MAP_SHARED },
> { TARGET_MAP_PRIVATE, TARGET_MAP_PRIVATE, MAP_PRIVATE, MAP_PRIVATE },
> { TARGET_MAP_FIXED, TARGET_MAP_FIXED, MAP_FIXED, MAP_FIXED },
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] linux-user/syscall: Constify bitmask_transtbl fcntl/mmap flags_tlb[]
2021-05-17 5:52 [PATCH v2] linux-user/syscall: Constify bitmask_transtbl fcntl/mmap flags_tlb[] Philippe Mathieu-Daudé
2021-05-25 7:50 ` Philippe Mathieu-Daudé
@ 2021-06-05 19:13 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2021-06-05 19:13 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, Bin Meng, Richard Henderson
Le 17/05/2021 à 07:52, Philippe Mathieu-Daudé a écrit :
> Keep bitmask_transtbl in .rodata by marking the arrays const.
>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> linux-user/syscall.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 95d79ddc437..64f486743a9 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -365,7 +365,7 @@ _syscall5(int, sys_statx, int, dirfd, const char *, pathname, int, flags,
> _syscall2(int, membarrier, int, cmd, int, flags)
> #endif
>
> -static bitmask_transtbl fcntl_flags_tbl[] = {
> +static const bitmask_transtbl fcntl_flags_tbl[] = {
> { TARGET_O_ACCMODE, TARGET_O_WRONLY, O_ACCMODE, O_WRONLY, },
> { TARGET_O_ACCMODE, TARGET_O_RDWR, O_ACCMODE, O_RDWR, },
> { TARGET_O_CREAT, TARGET_O_CREAT, O_CREAT, O_CREAT, },
> @@ -6062,7 +6062,7 @@ static const StructEntry struct_termios_def = {
> .print = print_termios,
> };
>
> -static bitmask_transtbl mmap_flags_tbl[] = {
> +static const bitmask_transtbl mmap_flags_tbl[] = {
> { TARGET_MAP_SHARED, TARGET_MAP_SHARED, MAP_SHARED, MAP_SHARED },
> { TARGET_MAP_PRIVATE, TARGET_MAP_PRIVATE, MAP_PRIVATE, MAP_PRIVATE },
> { TARGET_MAP_FIXED, TARGET_MAP_FIXED, MAP_FIXED, MAP_FIXED },
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-05 19:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-17 5:52 [PATCH v2] linux-user/syscall: Constify bitmask_transtbl fcntl/mmap flags_tlb[] Philippe Mathieu-Daudé
2021-05-25 7:50 ` Philippe Mathieu-Daudé
2021-06-05 19:13 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.