* [PATCH] sunrpc: xprtrdma: Remove repeated struct declaration
@ 2021-04-01 9:56 Wan Jiabing
2021-04-01 13:32 ` Chuck Lever III
0 siblings, 1 reply; 3+ messages in thread
From: Wan Jiabing @ 2021-04-01 9:56 UTC (permalink / raw)
To: bfields, chuck.lever, linux-nfs; +Cc: kael_w, Wan Jiabing
struct rpcrdma_req is declared twice. One is declared at 216th line.
The blew one is not needed. Remove the duplicate.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
net/sunrpc/xprtrdma/xprt_rdma.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h
index fe3be985e239..11e5fbfc642c 100644
--- a/net/sunrpc/xprtrdma/xprt_rdma.h
+++ b/net/sunrpc/xprtrdma/xprt_rdma.h
@@ -239,7 +239,6 @@ struct rpcrdma_frwr {
};
};
-struct rpcrdma_req;
struct rpcrdma_mr {
struct list_head mr_list;
struct rpcrdma_req *mr_req;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sunrpc: xprtrdma: Remove repeated struct declaration
2021-04-01 9:56 [PATCH] sunrpc: xprtrdma: Remove repeated struct declaration Wan Jiabing
@ 2021-04-01 13:32 ` Chuck Lever III
0 siblings, 0 replies; 3+ messages in thread
From: Chuck Lever III @ 2021-04-01 13:32 UTC (permalink / raw)
To: Wan Jiabing, Anna Schumaker; +Cc: Bruce Fields, Linux NFS Mailing List, kael_w
Hi -
> On Apr 1, 2021, at 5:56 AM, Wan Jiabing <wanjiabing@vivo.com> wrote:
>
> struct rpcrdma_req is declared twice. One is declared at 216th line.
> The blew one is not needed. Remove the duplicate.
s/blew/below/
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Thanks! This one goes to Anna.
> ---
> net/sunrpc/xprtrdma/xprt_rdma.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h
> index fe3be985e239..11e5fbfc642c 100644
> --- a/net/sunrpc/xprtrdma/xprt_rdma.h
> +++ b/net/sunrpc/xprtrdma/xprt_rdma.h
> @@ -239,7 +239,6 @@ struct rpcrdma_frwr {
> };
> };
>
> -struct rpcrdma_req;
> struct rpcrdma_mr {
> struct list_head mr_list;
> struct rpcrdma_req *mr_req;
> --
> 2.25.1
>
--
Chuck Lever
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] sunrpc: xprtrdma: Remove repeated struct declaration
@ 2021-04-01 9:31 Wan Jiabing
0 siblings, 0 replies; 3+ messages in thread
From: Wan Jiabing @ 2021-04-01 9:31 UTC (permalink / raw)
To: linux-kernel; +Cc: kael_w, Wan Jiabing
struct rpcrdma_req is declared twice. One is declared at 216th line.
The blew one is not needed. Remove the duplicate.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
net/sunrpc/xprtrdma/xprt_rdma.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h
index fe3be985e239..11e5fbfc642c 100644
--- a/net/sunrpc/xprtrdma/xprt_rdma.h
+++ b/net/sunrpc/xprtrdma/xprt_rdma.h
@@ -239,7 +239,6 @@ struct rpcrdma_frwr {
};
};
-struct rpcrdma_req;
struct rpcrdma_mr {
struct list_head mr_list;
struct rpcrdma_req *mr_req;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-01 18:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01 9:56 [PATCH] sunrpc: xprtrdma: Remove repeated struct declaration Wan Jiabing
2021-04-01 13:32 ` Chuck Lever III
-- strict thread matches above, loose matches on Subject: below --
2021-04-01 9:31 Wan Jiabing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.