From: Neil Armstrong <narmstrong@baylibre.com>
To: Vyacheslav <adeep@lexina.in>, Kevin Hilman <khilman@baylibre.com>
Cc: linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] arm64: dts: meson-axg: add support for JetHub D1
Date: Tue, 7 Sep 2021 09:09:08 +0200 [thread overview]
Message-ID: <83730df2-5104-bfff-949e-4499e0c2612a@baylibre.com> (raw)
In-Reply-To: <c6430622-5857-877c-6293-fc101500a6e6@lexina.in>
Hi,
On 06/09/2021 17:07, Vyacheslav wrote:
> 06.09.2021 15:26, Neil Armstrong пишет:
>> On 04/09/2021 16:27, Vyacheslav Bocharov wrote:
>>> JetHome Jethub D1 (http://jethome.ru/jethub-d1) is a home automation
>>> controller with the following features:
>>>
>>> +
>>> +&spicc1 {
>>> + status = "okay";
>>> +};
>> Why enabling it without pinctrl properties ?
>
> spiccwas planned for use during the development of the device, but in fact it is not currently used. Pins exist on expand pad.
>
> Its better to add pinctrl as below or leave spicc1 disabled?
As you want, if the HW is present and functional, usually it's enabled in the DT.
Neil
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
> index bc10f3357c09..ecffc90d9884 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
> @@ -313,6 +313,8 @@ &usb {
>
> &spicc1 {
> status = "okay";
> + pinctrl-0 = <&spi1_x_pins>, <&spi1_ss0_x_pins>;
> + pinctrl-names = "default";
> };
>
> &gpio {
>
>
> --
>
> Vyacheslav
>
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Vyacheslav <adeep@lexina.in>, Kevin Hilman <khilman@baylibre.com>
Cc: linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] arm64: dts: meson-axg: add support for JetHub D1
Date: Tue, 7 Sep 2021 09:09:08 +0200 [thread overview]
Message-ID: <83730df2-5104-bfff-949e-4499e0c2612a@baylibre.com> (raw)
In-Reply-To: <c6430622-5857-877c-6293-fc101500a6e6@lexina.in>
Hi,
On 06/09/2021 17:07, Vyacheslav wrote:
> 06.09.2021 15:26, Neil Armstrong пишет:
>> On 04/09/2021 16:27, Vyacheslav Bocharov wrote:
>>> JetHome Jethub D1 (http://jethome.ru/jethub-d1) is a home automation
>>> controller with the following features:
>>>
>>> +
>>> +&spicc1 {
>>> + status = "okay";
>>> +};
>> Why enabling it without pinctrl properties ?
>
> spiccwas planned for use during the development of the device, but in fact it is not currently used. Pins exist on expand pad.
>
> Its better to add pinctrl as below or leave spicc1 disabled?
As you want, if the HW is present and functional, usually it's enabled in the DT.
Neil
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
> index bc10f3357c09..ecffc90d9884 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
> @@ -313,6 +313,8 @@ &usb {
>
> &spicc1 {
> status = "okay";
> + pinctrl-0 = <&spi1_x_pins>, <&spi1_ss0_x_pins>;
> + pinctrl-names = "default";
> };
>
> &gpio {
>
>
> --
>
> Vyacheslav
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Vyacheslav <adeep@lexina.in>, Kevin Hilman <khilman@baylibre.com>
Cc: linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] arm64: dts: meson-axg: add support for JetHub D1
Date: Tue, 7 Sep 2021 09:09:08 +0200 [thread overview]
Message-ID: <83730df2-5104-bfff-949e-4499e0c2612a@baylibre.com> (raw)
In-Reply-To: <c6430622-5857-877c-6293-fc101500a6e6@lexina.in>
Hi,
On 06/09/2021 17:07, Vyacheslav wrote:
> 06.09.2021 15:26, Neil Armstrong пишет:
>> On 04/09/2021 16:27, Vyacheslav Bocharov wrote:
>>> JetHome Jethub D1 (http://jethome.ru/jethub-d1) is a home automation
>>> controller with the following features:
>>>
>>> +
>>> +&spicc1 {
>>> + status = "okay";
>>> +};
>> Why enabling it without pinctrl properties ?
>
> spiccwas planned for use during the development of the device, but in fact it is not currently used. Pins exist on expand pad.
>
> Its better to add pinctrl as below or leave spicc1 disabled?
As you want, if the HW is present and functional, usually it's enabled in the DT.
Neil
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
> index bc10f3357c09..ecffc90d9884 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
> @@ -313,6 +313,8 @@ &usb {
>
> &spicc1 {
> status = "okay";
> + pinctrl-0 = <&spi1_x_pins>, <&spi1_ss0_x_pins>;
> + pinctrl-names = "default";
> };
>
> &gpio {
>
>
> --
>
> Vyacheslav
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-07 7:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 14:27 [PATCH v3 0/4] arm64: meson: add support for JetHub D1/H1 Vyacheslav Bocharov
2021-09-04 14:27 ` Vyacheslav Bocharov
2021-09-04 14:27 ` Vyacheslav Bocharov
2021-09-04 14:27 ` [PATCH v3 1/4] dt-bindings: arm: amlogic: add bindings for Jethub D1/H1 Vyacheslav Bocharov
2021-09-04 14:27 ` Vyacheslav Bocharov
2021-09-04 14:27 ` Vyacheslav Bocharov
2021-09-06 12:24 ` Neil Armstrong
2021-09-06 12:24 ` Neil Armstrong
2021-09-06 12:24 ` Neil Armstrong
2021-09-04 14:27 ` [PATCH v3 2/4] dt-bindings: vendor-prefixes: add jethome prefix Vyacheslav Bocharov
2021-09-04 14:27 ` Vyacheslav Bocharov
2021-09-04 14:27 ` Vyacheslav Bocharov
2021-09-04 14:27 ` [PATCH v3 3/4] arm64: dts: meson-gxl: add support for JetHub H1 Vyacheslav Bocharov
2021-09-04 14:27 ` Vyacheslav Bocharov
2021-09-04 14:27 ` Vyacheslav Bocharov
2021-09-06 12:27 ` Neil Armstrong
2021-09-06 12:27 ` Neil Armstrong
2021-09-06 12:27 ` Neil Armstrong
2021-09-04 14:27 ` [PATCH v3 4/4] arm64: dts: meson-axg: add support for JetHub D1 Vyacheslav Bocharov
2021-09-04 14:27 ` Vyacheslav Bocharov
2021-09-04 14:27 ` Vyacheslav Bocharov
2021-09-06 12:26 ` Neil Armstrong
2021-09-06 12:26 ` Neil Armstrong
2021-09-06 12:26 ` Neil Armstrong
2021-09-06 16:17 ` Vyacheslav
2021-09-06 16:17 ` Vyacheslav
2021-09-06 16:17 ` Vyacheslav
[not found] ` <c6430622-5857-877c-6293-fc101500a6e6@lexina.in>
2021-09-07 7:09 ` Neil Armstrong [this message]
2021-09-07 7:09 ` Neil Armstrong
2021-09-07 7:09 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83730df2-5104-bfff-949e-4499e0c2612a@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=adeep@lexina.in \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.