* [PATCH] power: supply: twl4030-charger: make twl4030_bci_property_is_writeable static
@ 2017-05-03 10:33 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2017-05-03 10:33 UTC (permalink / raw)
To: H . Nikolaus Schaller, Sebastian Reichel, linux-pm
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function twl4030_bci_property_is_writeable can be made static
as it does not need to be in global scope.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/power/supply/twl4030_charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/twl4030_charger.c b/drivers/power/supply/twl4030_charger.c
index abd10f6861ae..2f82d0e9ec1b 100644
--- a/drivers/power/supply/twl4030_charger.c
+++ b/drivers/power/supply/twl4030_charger.c
@@ -943,7 +943,7 @@ static int twl4030_bci_set_property(struct power_supply *psy,
return 0;
}
-int twl4030_bci_property_is_writeable(struct power_supply *psy,
+static int twl4030_bci_property_is_writeable(struct power_supply *psy,
enum power_supply_property psp)
{
switch (psp) {
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] power: supply: twl4030-charger: make twl4030_bci_property_is_writeable static
@ 2017-05-03 10:33 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2017-05-03 10:33 UTC (permalink / raw)
To: H . Nikolaus Schaller, Sebastian Reichel, linux-pm
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function twl4030_bci_property_is_writeable can be made static
as it does not need to be in global scope.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/power/supply/twl4030_charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/twl4030_charger.c b/drivers/power/supply/twl4030_charger.c
index abd10f6861ae..2f82d0e9ec1b 100644
--- a/drivers/power/supply/twl4030_charger.c
+++ b/drivers/power/supply/twl4030_charger.c
@@ -943,7 +943,7 @@ static int twl4030_bci_set_property(struct power_supply *psy,
return 0;
}
-int twl4030_bci_property_is_writeable(struct power_supply *psy,
+static int twl4030_bci_property_is_writeable(struct power_supply *psy,
enum power_supply_property psp)
{
switch (psp) {
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] power: supply: twl4030-charger: make twl4030_bci_property_is_writeable static
2017-05-03 10:33 ` Colin King
@ 2017-05-03 12:25 ` H. Nikolaus Schaller
-1 siblings, 0 replies; 6+ messages in thread
From: H. Nikolaus Schaller @ 2017-05-03 12:25 UTC (permalink / raw)
To: Colin King, Sebastian Reichel
Cc: Linux PM mailing list, kernel-janitors, LKML
Hi Colin,
> Am 03.05.2017 um 12:33 schrieb Colin King <colin.king@canonical.com>:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The function twl4030_bci_property_is_writeable can be made static
> as it does not need to be in global scope.
Indeed. Have tested and it still works.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/power/supply/twl4030_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/twl4030_charger.c b/drivers/power/supply/twl4030_charger.c
> index abd10f6861ae..2f82d0e9ec1b 100644
> --- a/drivers/power/supply/twl4030_charger.c
> +++ b/drivers/power/supply/twl4030_charger.c
> @@ -943,7 +943,7 @@ static int twl4030_bci_set_property(struct power_supply *psy,
> return 0;
> }
>
> -int twl4030_bci_property_is_writeable(struct power_supply *psy,
> +static int twl4030_bci_property_is_writeable(struct power_supply *psy,
> enum power_supply_property psp)
> {
> switch (psp) {
> --
> 2.11.0
>
Thanks and BR,
Nikolaus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] power: supply: twl4030-charger: make twl4030_bci_property_is_writeable static
@ 2017-05-03 12:25 ` H. Nikolaus Schaller
0 siblings, 0 replies; 6+ messages in thread
From: H. Nikolaus Schaller @ 2017-05-03 12:25 UTC (permalink / raw)
To: Colin King, Sebastian Reichel
Cc: Linux PM mailing list, kernel-janitors, LKML
Hi Colin,
> Am 03.05.2017 um 12:33 schrieb Colin King <colin.king@canonical.com>:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The function twl4030_bci_property_is_writeable can be made static
> as it does not need to be in global scope.
Indeed. Have tested and it still works.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/power/supply/twl4030_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/twl4030_charger.c b/drivers/power/supply/twl4030_charger.c
> index abd10f6861ae..2f82d0e9ec1b 100644
> --- a/drivers/power/supply/twl4030_charger.c
> +++ b/drivers/power/supply/twl4030_charger.c
> @@ -943,7 +943,7 @@ static int twl4030_bci_set_property(struct power_supply *psy,
> return 0;
> }
>
> -int twl4030_bci_property_is_writeable(struct power_supply *psy,
> +static int twl4030_bci_property_is_writeable(struct power_supply *psy,
> enum power_supply_property psp)
> {
> switch (psp) {
> --
> 2.11.0
>
Thanks and BR,
Nikolaus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] power: supply: twl4030-charger: make twl4030_bci_property_is_writeable static
2017-05-03 10:33 ` Colin King
@ 2017-05-04 15:22 ` Sebastian Reichel
-1 siblings, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2017-05-04 15:22 UTC (permalink / raw)
To: Colin King; +Cc: H . Nikolaus Schaller, linux-pm, kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
Hi,
On Wed, May 03, 2017 at 11:33:57AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function twl4030_bci_property_is_writeable can be made static
> as it does not need to be in global scope.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] power: supply: twl4030-charger: make twl4030_bci_property_is_writeable static
@ 2017-05-04 15:22 ` Sebastian Reichel
0 siblings, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2017-05-04 15:22 UTC (permalink / raw)
To: Colin King; +Cc: H . Nikolaus Schaller, linux-pm, kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
Hi,
On Wed, May 03, 2017 at 11:33:57AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function twl4030_bci_property_is_writeable can be made static
> as it does not need to be in global scope.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-05-04 15:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-03 10:33 [PATCH] power: supply: twl4030-charger: make twl4030_bci_property_is_writeable static Colin King
2017-05-03 10:33 ` Colin King
2017-05-03 12:25 ` H. Nikolaus Schaller
2017-05-03 12:25 ` H. Nikolaus Schaller
2017-05-04 15:22 ` Sebastian Reichel
2017-05-04 15:22 ` Sebastian Reichel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.