All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] qemu-doc: Get rid of "vlan=X" example in the documentation
@ 2018-01-15  7:40 Thomas Huth
  2018-01-16  6:20 ` Jason Wang
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2018-01-15  7:40 UTC (permalink / raw)
  To: qemu-devel, Jason Wang; +Cc: qemu-trivial

The vlan concept is marked as deprecated, so we should not use
this for examples in the documentation anymore.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 qemu-options.hx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 130016c..d0c8b06 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2257,8 +2257,8 @@ qemu-system-i386 linux.img -net nic -net tap
 #launch a QEMU instance with two NICs, each one connected
 #to a TAP device
 qemu-system-i386 linux.img \
-                 -net nic,vlan=0 -net tap,vlan=0,ifname=tap0 \
-                 -net nic,vlan=1 -net tap,vlan=1,ifname=tap1
+        -netdev tap,id=nd0,ifname=tap0 -device e1000,netdev=nd0 \
+        -netdev tap,id=nd1,ifname=tap1 -device rtl8139,netdev=nd1
 @end example
 
 @example
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] qemu-doc: Get rid of "vlan=X" example in the documentation
  2018-01-15  7:40 [Qemu-devel] [PATCH] qemu-doc: Get rid of "vlan=X" example in the documentation Thomas Huth
@ 2018-01-16  6:20 ` Jason Wang
  0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2018-01-16  6:20 UTC (permalink / raw)
  To: Thomas Huth, qemu-devel; +Cc: qemu-trivial



On 2018年01月15日 15:40, Thomas Huth wrote:
> The vlan concept is marked as deprecated, so we should not use
> this for examples in the documentation anymore.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   qemu-options.hx | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 130016c..d0c8b06 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2257,8 +2257,8 @@ qemu-system-i386 linux.img -net nic -net tap
>   #launch a QEMU instance with two NICs, each one connected
>   #to a TAP device
>   qemu-system-i386 linux.img \
> -                 -net nic,vlan=0 -net tap,vlan=0,ifname=tap0 \
> -                 -net nic,vlan=1 -net tap,vlan=1,ifname=tap1
> +        -netdev tap,id=nd0,ifname=tap0 -device e1000,netdev=nd0 \
> +        -netdev tap,id=nd1,ifname=tap1 -device rtl8139,netdev=nd1
>   @end example
>   
>   @example

Applied.

Thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-16  6:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-15  7:40 [Qemu-devel] [PATCH] qemu-doc: Get rid of "vlan=X" example in the documentation Thomas Huth
2018-01-16  6:20 ` Jason Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.