All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: iwd 1.23 crashes in eapol_handle_pkt_1_of_4()
@ 2022-02-03 11:35 
  0 siblings, 0 replies; 6+ messages in thread
From:  @ 2022-02-03 11:35 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]

Toke Høiland-Jørgensen <toke(a)toke.dk> writes:

> Denis Kenzior <denkenz(a)gmail.com> writes:
>
>> Hi Toke,
>>
>> On 2/2/22 06:05, Toke Høiland-Jørgensen wrote:
>>> Hi
>>> 
>>> Since updating to iwd 1.23 (from Arch packages), I've started seeing
>>> periodic crashes. I rebuilt iwd with debug symbols enabled and got the
>>> following backtrace out of 'coredumpctl gdb':
>>> 
>>
>> *hangs his head in shame*.  So I think we screwed up the same macro 2x now.
>
> Heh, yeah, did see there was a commit touching that macro, but didn't
> look closer.
>
>> Can you please try the patch I just sent out?
>
> Can do - thanks! Did a build with it incorporated and am running that
> now. Usually crashes once every hour (with striking regularity); will
> leave it running overnight and see if the crashes are gone by tomorrow
> :)

Alright, so no crashes - thanks for the swift fix!

And just for future reference, in case anyone else runs into the same
issue: The crashes were initially taking the kernel down with them,
which has now also been fixed:
https://lore.kernel.org/r/20220201130951.22093-1-johannes(a)sipsolutions.net

-Toke

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: iwd 1.23 crashes in eapol_handle_pkt_1_of_4()
@ 2022-02-02 22:03 
  0 siblings, 0 replies; 6+ messages in thread
From:  @ 2022-02-02 22:03 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

Denis Kenzior <denkenz(a)gmail.com> writes:

> Hi Toke,
>
> On 2/2/22 06:05, Toke Høiland-Jørgensen wrote:
>> Hi
>> 
>> Since updating to iwd 1.23 (from Arch packages), I've started seeing
>> periodic crashes. I rebuilt iwd with debug symbols enabled and got the
>> following backtrace out of 'coredumpctl gdb':
>> 
>
> *hangs his head in shame*.  So I think we screwed up the same macro 2x now.

Heh, yeah, did see there was a commit touching that macro, but didn't
look closer.

> Can you please try the patch I just sent out?

Can do - thanks! Did a build with it incorporated and am running that
now. Usually crashes once every hour (with striking regularity); will
leave it running overnight and see if the crashes are gone by tomorrow :)

-Toke

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: iwd 1.23 crashes in eapol_handle_pkt_1_of_4()
@ 2022-02-02 17:16 Denis Kenzior
  0 siblings, 0 replies; 6+ messages in thread
From: Denis Kenzior @ 2022-02-02 17:16 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi Toke,

On 2/2/22 06:05, Toke Høiland-Jørgensen wrote:
> Hi
> 
> Since updating to iwd 1.23 (from Arch packages), I've started seeing
> periodic crashes. I rebuilt iwd with debug symbols enabled and got the
> following backtrace out of 'coredumpctl gdb':
> 

*hangs his head in shame*.  So I think we screwed up the same macro 2x now.

Can you please try the patch I just sent out?

Regards,
-Denis

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: iwd 1.23 crashes in eapol_handle_pkt_1_of_4()
@ 2022-02-02 15:05 
  0 siblings, 0 replies; 6+ messages in thread
From:  @ 2022-02-02 15:05 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Diederik de Haas <didi.debian(a)cknow.org> writes:

> On 2 February 2022 13:05:56 CET Toke Høiland-Jørgensen wrote:
>> Since updating to iwd 1.23 (from Arch packages), I've started seeing
>> periodic crashes. 
>> 
>> Does anyone have any ideas? :)
>
> According to https://bugs.debian.org/1004607, iwd 1.23 needs a newer version 
> of ELL (version 0.48), so maybe you need to upgrade ELL too?

Nope, that's not it - already running ell v0.48 :)

-Toke

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: iwd 1.23 crashes in eapol_handle_pkt_1_of_4()
@ 2022-02-02 13:04 Diederik de Haas
  0 siblings, 0 replies; 6+ messages in thread
From: Diederik de Haas @ 2022-02-02 13:04 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

On 2 February 2022 13:05:56 CET Toke Høiland-Jørgensen wrote:
> Since updating to iwd 1.23 (from Arch packages), I've started seeing
> periodic crashes. 
> 
> Does anyone have any ideas? :)

According to https://bugs.debian.org/1004607, iwd 1.23 needs a newer version 
of ELL (version 0.48), so maybe you need to upgrade ELL too?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* iwd 1.23 crashes in eapol_handle_pkt_1_of_4()
@ 2022-02-02 12:05 
  0 siblings, 0 replies; 6+ messages in thread
From:  @ 2022-02-02 12:05 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 2404 bytes --]

Hi

Since updating to iwd 1.23 (from Arch packages), I've started seeing
periodic crashes. I rebuilt iwd with debug symbols enabled and got the
following backtrace out of 'coredumpctl gdb':

Core was generated by `/usr/lib/iwd/iwd'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00005555f0ba8b3d in eapol_handle_ptk_1_of_4 (sm=sm(a)entry=0x5555f2b4a920, ek=0x5555f2b62588, ek(a)entry=0x16, unencrypted=unencrypted(a)entry=false) at src/eapol.c:1236
1236				handshake_event(sm->handshake,
(gdb) bt
#0  0x00005555f0ba8b3d in eapol_handle_ptk_1_of_4 (sm=sm(a)entry=0x5555f2b4a920, ek=0x5555f2b62588, ek(a)entry=0x16, unencrypted=unencrypted(a)entry=false) at src/eapol.c:1236
#1  0x00005555f0bab118 in eapol_key_handle (unencrypted=<optimized out>, frame=<optimized out>, sm=0x5555f2b4a920) at src/eapol.c:2343
#2  eapol_rx_packet (proto=<optimized out>, from=<optimized out>, frame=<optimized out>, unencrypted=<optimized out>, user_data=0x5555f2b4a920) at src/eapol.c:2665
#3  0x00005555f0bac497 in __eapol_rx_packet (ifindex=62, src=src(a)entry=0x5555f2b62574 "x\212 J\207\267", proto=proto(a)entry=34958, frame=frame(a)entry=0x5555f2b62588 "\002\003", 
    len=len(a)entry=121, noencrypt=noencrypt(a)entry=false) at src/eapol.c:3017
#4  0x00005555f0b8c617 in netdev_control_port_frame_event (netdev=0x5555f2b64450, msg=0x5555f2b62588) at src/netdev.c:5574
#5  netdev_unicast_notify (msg=msg(a)entry=0x5555f2b619a0, user_data=<optimized out>) at src/netdev.c:5613
#6  0x00007f60084c9a51 in dispatch_unicast_watches (msg=0x5555f2b619a0, id=<optimized out>, genl=0x5555f2b3fc80) at ell/genl.c:954
#7  process_unicast (nlmsg=0x7fff61abeac0, genl=0x5555f2b3fc80) at ell/genl.c:973
#8  received_data (io=<optimized out>, user_data=0x5555f2b3fc80) at ell/genl.c:1098
#9  0x00007f60084c61bd in io_callback (fd=<optimized out>, events=1, user_data=0x5555f2b3fd20) at ell/io.c:120
#10 0x00007f60084c536d in l_main_iterate (timeout=<optimized out>) at ell/main.c:478
#11 0x00007f60084c543e in l_main_run () at ell/main.c:525
#12 l_main_run () at ell/main.c:507
#13 0x00007f60084c5670 in l_main_run_with_signal (callback=callback(a)entry=0x5555f0b89150 <signal_handler>, user_data=user_data(a)entry=0x0) at ell/main.c:647
#14 0x00005555f0b886a4 in main (argc=<optimized out>, argv=<optimized out>) at src/main.c:532

Does anyone have any ideas? :)

Thanks!

-Toke

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-02-03 11:35 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-03 11:35 iwd 1.23 crashes in eapol_handle_pkt_1_of_4() 
  -- strict thread matches above, loose matches on Subject: below --
2022-02-02 22:03 
2022-02-02 17:16 Denis Kenzior
2022-02-02 15:05 
2022-02-02 13:04 Diederik de Haas
2022-02-02 12:05 

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.