From: Kalle Valo <kvalo@qca.qualcomm.com> To: Michal Kazior <michal.kazior@tieto.com> Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org> Subject: Re: [PATCH 1/3] ath10k: prevent HTC from being used after stopping Date: Fri, 19 Jul 2013 14:04:03 +0300 [thread overview] Message-ID: <8761w64xr0.fsf@kamboji.qca.qualcomm.com> (raw) In-Reply-To: <1374129193-3533-2-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 18 Jul 2013 08:33:11 +0200") Michal Kazior <michal.kazior@tieto.com> writes: > It was possible to submit new HTC commands > after/while HTC stopped. This led to memory > corruption in some rare cases. > > Signed-off-by: Michal Kazior <michal.kazior@tieto.com> [...] > @@ -957,7 +955,6 @@ void ath10k_htc_stop(struct ath10k_htc *htc) > } > > ath10k_hif_stop(htc->ar); > - ath10k_htc_reset_endpoint_states(htc); > } Is this on purpose? I can't fit it to the description. -- Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com> To: Michal Kazior <michal.kazior@tieto.com> Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH 1/3] ath10k: prevent HTC from being used after stopping Date: Fri, 19 Jul 2013 14:04:03 +0300 [thread overview] Message-ID: <8761w64xr0.fsf@kamboji.qca.qualcomm.com> (raw) In-Reply-To: <1374129193-3533-2-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 18 Jul 2013 08:33:11 +0200") Michal Kazior <michal.kazior@tieto.com> writes: > It was possible to submit new HTC commands > after/while HTC stopped. This led to memory > corruption in some rare cases. > > Signed-off-by: Michal Kazior <michal.kazior@tieto.com> [...] > @@ -957,7 +955,6 @@ void ath10k_htc_stop(struct ath10k_htc *htc) > } > > ath10k_hif_stop(htc->ar); > - ath10k_htc_reset_endpoint_states(htc); > } Is this on purpose? I can't fit it to the description. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2013-07-19 11:04 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-18 6:33 [PATCH 0/3] ath10k: fixes Michal Kazior 2013-07-18 6:33 ` Michal Kazior 2013-07-18 6:33 ` [PATCH 1/3] ath10k: prevent HTC from being used after stopping Michal Kazior 2013-07-18 6:33 ` Michal Kazior 2013-07-19 11:04 ` Kalle Valo [this message] 2013-07-19 11:04 ` Kalle Valo 2013-07-19 11:08 ` Michal Kazior 2013-07-19 11:08 ` Michal Kazior 2013-07-19 11:44 ` Kalle Valo 2013-07-19 11:44 ` Kalle Valo 2013-07-18 6:33 ` [PATCH 2/3] ath10k: fix memleak in mac setup Michal Kazior 2013-07-18 6:33 ` Michal Kazior 2013-07-18 6:33 ` [PATCH 3/3] ath10k: fix rts/fragmentation threshold setup Michal Kazior 2013-07-18 6:33 ` Michal Kazior 2013-07-19 11:07 ` [PATCH 0/3] ath10k: fixes Kalle Valo 2013-07-19 11:07 ` Kalle Valo 2013-07-19 11:10 ` Michal Kazior 2013-07-19 11:10 ` Michal Kazior 2013-07-19 11:43 ` Kalle Valo 2013-07-19 11:43 ` Kalle Valo 2013-07-22 12:13 ` [PATCH v2 0/4] " Michal Kazior 2013-07-22 12:13 ` Michal Kazior 2013-07-22 12:13 ` [PATCH v2 1/4] ath10k: prevent HTC from being used after stopping Michal Kazior 2013-07-22 12:13 ` Michal Kazior 2013-07-22 12:13 ` [PATCH v2 2/4] ath10k: don't reset HTC endpoints unnecessarily Michal Kazior 2013-07-22 12:13 ` Michal Kazior 2013-07-23 8:46 ` Kalle Valo 2013-07-23 8:46 ` Kalle Valo 2013-07-22 12:13 ` [PATCH v2 3/4] ath10k: fix memleak in mac setup Michal Kazior 2013-07-22 12:13 ` Michal Kazior 2013-07-22 12:13 ` [PATCH v2 4/4] ath10k: fix rts/fragmentation threshold setup Michal Kazior 2013-07-22 12:13 ` Michal Kazior 2013-07-23 8:47 ` [PATCH v2 0/4] ath10k: fixes Kalle Valo 2013-07-23 8:47 ` Kalle Valo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8761w64xr0.fsf@kamboji.qca.qualcomm.com \ --to=kvalo@qca.qualcomm.com \ --cc=ath10k@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ --cc=michal.kazior@tieto.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.