* [PATCH] ASoC: add missing compile rule for max98371
@ 2017-09-01 4:33 Kuninori Morimoto
2017-09-01 7:27 ` Takashi Iwai
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Kuninori Morimoto @ 2017-09-01 4:33 UTC (permalink / raw)
To: Mark Brown; +Cc: Linux-ALSA, Simon
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
It is still using old driver style, this patch also
fixup it.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
sound/soc/codecs/Makefile | 1 +
sound/soc/codecs/max98371.c | 14 ++++++++------
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile
index 12dc2f7..d93318e 100644
--- a/sound/soc/codecs/Makefile
+++ b/sound/soc/codecs/Makefile
@@ -322,6 +322,7 @@ obj-$(CONFIG_SND_SOC_MAX98088) += snd-soc-max98088.o
obj-$(CONFIG_SND_SOC_MAX98090) += snd-soc-max98090.o
obj-$(CONFIG_SND_SOC_MAX98095) += snd-soc-max98095.o
obj-$(CONFIG_SND_SOC_MAX98357A) += snd-soc-max98357a.o
+obj-$(CONFIG_SND_SOC_MAX98371) += snd-soc-max98371.o
obj-$(CONFIG_SND_SOC_MAX9867) += snd-soc-max9867.o
obj-$(CONFIG_SND_SOC_MAX98925) += snd-soc-max98925.o
obj-$(CONFIG_SND_SOC_MAX98926) += snd-soc-max98926.o
diff --git a/sound/soc/codecs/max98371.c b/sound/soc/codecs/max98371.c
index 781be9ba..7bc2a17 100644
--- a/sound/soc/codecs/max98371.c
+++ b/sound/soc/codecs/max98371.c
@@ -349,12 +349,14 @@ static int max98371_dai_hw_params(struct snd_pcm_substream *substream,
};
static const struct snd_soc_codec_driver max98371_codec = {
- .controls = max98371_snd_controls,
- .num_controls = ARRAY_SIZE(max98371_snd_controls),
- .dapm_routes = max98371_audio_map,
- .num_dapm_routes = ARRAY_SIZE(max98371_audio_map),
- .dapm_widgets = max98371_dapm_widgets,
- .num_dapm_widgets = ARRAY_SIZE(max98371_dapm_widgets),
+ .component_driver = {
+ .controls = max98371_snd_controls,
+ .num_controls = ARRAY_SIZE(max98371_snd_controls),
+ .dapm_routes = max98371_audio_map,
+ .num_dapm_routes = ARRAY_SIZE(max98371_audio_map),
+ .dapm_widgets = max98371_dapm_widgets,
+ .num_dapm_widgets = ARRAY_SIZE(max98371_dapm_widgets),
+ },
};
static const struct regmap_config max98371_regmap = {
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: add missing compile rule for max98371
2017-09-01 4:33 [PATCH] ASoC: add missing compile rule for max98371 Kuninori Morimoto
@ 2017-09-01 7:27 ` Takashi Iwai
2017-09-01 7:44 ` Kuninori Morimoto
2017-09-01 10:21 ` Mark Brown
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Takashi Iwai @ 2017-09-01 7:27 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Linux-ALSA, Mark Brown, Simon
On Fri, 01 Sep 2017 06:33:01 +0200,
Kuninori Morimoto wrote:
>
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> It is still using old driver style, this patch also
> fixup it.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> sound/soc/codecs/Makefile | 1 +
> sound/soc/codecs/max98371.c | 14 ++++++++------
> 2 files changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile
> index 12dc2f7..d93318e 100644
> --- a/sound/soc/codecs/Makefile
> +++ b/sound/soc/codecs/Makefile
> @@ -322,6 +322,7 @@ obj-$(CONFIG_SND_SOC_MAX98088) += snd-soc-max98088.o
> obj-$(CONFIG_SND_SOC_MAX98090) += snd-soc-max98090.o
> obj-$(CONFIG_SND_SOC_MAX98095) += snd-soc-max98095.o
> obj-$(CONFIG_SND_SOC_MAX98357A) += snd-soc-max98357a.o
> +obj-$(CONFIG_SND_SOC_MAX98371) += snd-soc-max98371.o
> obj-$(CONFIG_SND_SOC_MAX9867) += snd-soc-max9867.o
> obj-$(CONFIG_SND_SOC_MAX98925) += snd-soc-max98925.o
> obj-$(CONFIG_SND_SOC_MAX98926) += snd-soc-max98926.o
This part doesn't match with the patch description.
You're trying to revive the dead driver build.
Ditto for sirf-audio-codec, too.
thanks,
Takashi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: add missing compile rule for max98371
2017-09-01 7:27 ` Takashi Iwai
@ 2017-09-01 7:44 ` Kuninori Morimoto
2017-09-01 8:14 ` Takashi Iwai
0 siblings, 1 reply; 7+ messages in thread
From: Kuninori Morimoto @ 2017-09-01 7:44 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Linux-ALSA, Mark Brown, Simon
Hi Takashi
> > diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile
> > index 12dc2f7..d93318e 100644
> > --- a/sound/soc/codecs/Makefile
> > +++ b/sound/soc/codecs/Makefile
> > @@ -322,6 +322,7 @@ obj-$(CONFIG_SND_SOC_MAX98088) += snd-soc-max98088.o
> > obj-$(CONFIG_SND_SOC_MAX98090) += snd-soc-max98090.o
> > obj-$(CONFIG_SND_SOC_MAX98095) += snd-soc-max98095.o
> > obj-$(CONFIG_SND_SOC_MAX98357A) += snd-soc-max98357a.o
> > +obj-$(CONFIG_SND_SOC_MAX98371) += snd-soc-max98371.o
> > obj-$(CONFIG_SND_SOC_MAX9867) += snd-soc-max9867.o
> > obj-$(CONFIG_SND_SOC_MAX98925) += snd-soc-max98925.o
> > obj-$(CONFIG_SND_SOC_MAX98926) += snd-soc-max98926.o
>
> This part doesn't match with the patch description.
> You're trying to revive the dead driver build.
> Ditto for sirf-audio-codec, too.
Oops ?
But, there is max98371.c on my tree? sirf too
I'm using different branch ?
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: add missing compile rule for max98371
2017-09-01 7:44 ` Kuninori Morimoto
@ 2017-09-01 8:14 ` Takashi Iwai
0 siblings, 0 replies; 7+ messages in thread
From: Takashi Iwai @ 2017-09-01 8:14 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Linux-ALSA, Mark Brown, Simon
On Fri, 01 Sep 2017 09:44:47 +0200,
Kuninori Morimoto wrote:
>
>
> Hi Takashi
>
> > > diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile
> > > index 12dc2f7..d93318e 100644
> > > --- a/sound/soc/codecs/Makefile
> > > +++ b/sound/soc/codecs/Makefile
> > > @@ -322,6 +322,7 @@ obj-$(CONFIG_SND_SOC_MAX98088) += snd-soc-max98088.o
> > > obj-$(CONFIG_SND_SOC_MAX98090) += snd-soc-max98090.o
> > > obj-$(CONFIG_SND_SOC_MAX98095) += snd-soc-max98095.o
> > > obj-$(CONFIG_SND_SOC_MAX98357A) += snd-soc-max98357a.o
> > > +obj-$(CONFIG_SND_SOC_MAX98371) += snd-soc-max98371.o
> > > obj-$(CONFIG_SND_SOC_MAX9867) += snd-soc-max9867.o
> > > obj-$(CONFIG_SND_SOC_MAX98925) += snd-soc-max98925.o
> > > obj-$(CONFIG_SND_SOC_MAX98926) += snd-soc-max98926.o
> >
> > This part doesn't match with the patch description.
> > You're trying to revive the dead driver build.
> > Ditto for sirf-audio-codec, too.
>
> Oops ?
> But, there is max98371.c on my tree? sirf too
> I'm using different branch ?
It's been there but never built. At least, your patch indicates
that.
Takashi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: add missing compile rule for max98371
2017-09-01 4:33 [PATCH] ASoC: add missing compile rule for max98371 Kuninori Morimoto
2017-09-01 7:27 ` Takashi Iwai
@ 2017-09-01 10:21 ` Mark Brown
2017-09-01 10:47 ` Applied "ASoC: add missing compile rule for max98371" to the asoc tree Mark Brown
2017-09-01 11:11 ` Mark Brown
3 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2017-09-01 10:21 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Linux-ALSA, Simon
[-- Attachment #1.1: Type: text/plain, Size: 406 bytes --]
On Fri, Sep 01, 2017 at 04:33:01AM +0000, Kuninori Morimoto wrote:
> It is still using old driver style, this patch also
> fixup it.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> sound/soc/codecs/Makefile | 1 +
> sound/soc/codecs/max98371.c | 14 ++++++++------
The changes in the body of the driver should really be split out and
explained separately.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Applied "ASoC: add missing compile rule for max98371" to the asoc tree
2017-09-01 4:33 [PATCH] ASoC: add missing compile rule for max98371 Kuninori Morimoto
2017-09-01 7:27 ` Takashi Iwai
2017-09-01 10:21 ` Mark Brown
@ 2017-09-01 10:47 ` Mark Brown
2017-09-01 11:11 ` Mark Brown
3 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2017-09-01 10:47 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: alsa-devel, Mark Brown, Simon
The patch
ASoC: add missing compile rule for max98371
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From a3dcadd220b4572f9baaad5f3c0c00044273c961 Mon Sep 17 00:00:00 2001
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: Fri, 1 Sep 2017 04:33:01 +0000
Subject: [PATCH] ASoC: add missing compile rule for max98371
It is still using old driver style, this patch also
fixup it.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/Makefile | 1 +
sound/soc/codecs/max98371.c | 14 ++++++++------
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile
index 1755a54e3dc9..b4d576dab48a 100644
--- a/sound/soc/codecs/Makefile
+++ b/sound/soc/codecs/Makefile
@@ -320,6 +320,7 @@ obj-$(CONFIG_SND_SOC_MAX98088) += snd-soc-max98088.o
obj-$(CONFIG_SND_SOC_MAX98090) += snd-soc-max98090.o
obj-$(CONFIG_SND_SOC_MAX98095) += snd-soc-max98095.o
obj-$(CONFIG_SND_SOC_MAX98357A) += snd-soc-max98357a.o
+obj-$(CONFIG_SND_SOC_MAX98371) += snd-soc-max98371.o
obj-$(CONFIG_SND_SOC_MAX9867) += snd-soc-max9867.o
obj-$(CONFIG_SND_SOC_MAX98925) += snd-soc-max98925.o
obj-$(CONFIG_SND_SOC_MAX98926) += snd-soc-max98926.o
diff --git a/sound/soc/codecs/max98371.c b/sound/soc/codecs/max98371.c
index 781be9ba8dba..7bc2a17c1e94 100644
--- a/sound/soc/codecs/max98371.c
+++ b/sound/soc/codecs/max98371.c
@@ -349,12 +349,14 @@ static struct snd_soc_dai_driver max98371_dai[] = {
};
static const struct snd_soc_codec_driver max98371_codec = {
- .controls = max98371_snd_controls,
- .num_controls = ARRAY_SIZE(max98371_snd_controls),
- .dapm_routes = max98371_audio_map,
- .num_dapm_routes = ARRAY_SIZE(max98371_audio_map),
- .dapm_widgets = max98371_dapm_widgets,
- .num_dapm_widgets = ARRAY_SIZE(max98371_dapm_widgets),
+ .component_driver = {
+ .controls = max98371_snd_controls,
+ .num_controls = ARRAY_SIZE(max98371_snd_controls),
+ .dapm_routes = max98371_audio_map,
+ .num_dapm_routes = ARRAY_SIZE(max98371_audio_map),
+ .dapm_widgets = max98371_dapm_widgets,
+ .num_dapm_widgets = ARRAY_SIZE(max98371_dapm_widgets),
+ },
};
static const struct regmap_config max98371_regmap = {
--
2.14.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Applied "ASoC: add missing compile rule for max98371" to the asoc tree
2017-09-01 4:33 [PATCH] ASoC: add missing compile rule for max98371 Kuninori Morimoto
` (2 preceding siblings ...)
2017-09-01 10:47 ` Applied "ASoC: add missing compile rule for max98371" to the asoc tree Mark Brown
@ 2017-09-01 11:11 ` Mark Brown
3 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2017-09-01 11:11 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: alsa-devel, Mark Brown, Simon
The patch
ASoC: add missing compile rule for max98371
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From b21f0522ee376ddbea54fab47ff36f687f2a438b Mon Sep 17 00:00:00 2001
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: Fri, 1 Sep 2017 04:33:01 +0000
Subject: [PATCH] ASoC: add missing compile rule for max98371
It is still using old driver style, this patch also
fixup it.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/Makefile | 1 +
sound/soc/codecs/max98371.c | 14 ++++++++------
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile
index 1755a54e3dc9..b4d576dab48a 100644
--- a/sound/soc/codecs/Makefile
+++ b/sound/soc/codecs/Makefile
@@ -320,6 +320,7 @@ obj-$(CONFIG_SND_SOC_MAX98088) += snd-soc-max98088.o
obj-$(CONFIG_SND_SOC_MAX98090) += snd-soc-max98090.o
obj-$(CONFIG_SND_SOC_MAX98095) += snd-soc-max98095.o
obj-$(CONFIG_SND_SOC_MAX98357A) += snd-soc-max98357a.o
+obj-$(CONFIG_SND_SOC_MAX98371) += snd-soc-max98371.o
obj-$(CONFIG_SND_SOC_MAX9867) += snd-soc-max9867.o
obj-$(CONFIG_SND_SOC_MAX98925) += snd-soc-max98925.o
obj-$(CONFIG_SND_SOC_MAX98926) += snd-soc-max98926.o
diff --git a/sound/soc/codecs/max98371.c b/sound/soc/codecs/max98371.c
index 781be9ba8dba..7bc2a17c1e94 100644
--- a/sound/soc/codecs/max98371.c
+++ b/sound/soc/codecs/max98371.c
@@ -349,12 +349,14 @@ static struct snd_soc_dai_driver max98371_dai[] = {
};
static const struct snd_soc_codec_driver max98371_codec = {
- .controls = max98371_snd_controls,
- .num_controls = ARRAY_SIZE(max98371_snd_controls),
- .dapm_routes = max98371_audio_map,
- .num_dapm_routes = ARRAY_SIZE(max98371_audio_map),
- .dapm_widgets = max98371_dapm_widgets,
- .num_dapm_widgets = ARRAY_SIZE(max98371_dapm_widgets),
+ .component_driver = {
+ .controls = max98371_snd_controls,
+ .num_controls = ARRAY_SIZE(max98371_snd_controls),
+ .dapm_routes = max98371_audio_map,
+ .num_dapm_routes = ARRAY_SIZE(max98371_audio_map),
+ .dapm_widgets = max98371_dapm_widgets,
+ .num_dapm_widgets = ARRAY_SIZE(max98371_dapm_widgets),
+ },
};
static const struct regmap_config max98371_regmap = {
--
2.14.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-09-01 11:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-01 4:33 [PATCH] ASoC: add missing compile rule for max98371 Kuninori Morimoto
2017-09-01 7:27 ` Takashi Iwai
2017-09-01 7:44 ` Kuninori Morimoto
2017-09-01 8:14 ` Takashi Iwai
2017-09-01 10:21 ` Mark Brown
2017-09-01 10:47 ` Applied "ASoC: add missing compile rule for max98371" to the asoc tree Mark Brown
2017-09-01 11:11 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.