From: "Huang\, Ying" <ying.huang@intel.com>
To: Michal Hocko <mhocko@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tim Chen <tim.c.chen@linux.intel.com>, "Huang\,
Ying" <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: kernel BUG at mm/swap_slots.c:270
Date: Mon, 20 Mar 2017 09:25:50 +0800 [thread overview]
Message-ID: <87d1dcd9i9.fsf@yhuang-dev.intel.com> (raw)
In-Reply-To: <20170319140447.GA12414@dhcp22.suse.cz> (Michal Hocko's message of "Sun, 19 Mar 2017 10:04:47 -0400")
Hi,
Michal Hocko <mhocko@kernel.org> writes:
> On Sat 18-03-17 09:57:18, Linus Torvalds wrote:
>> Tim at al,
>> I got this on my desktop at shutdown:
>>
>> ------------[ cut here ]------------
>> kernel BUG at mm/swap_slots.c:270!
>> invalid opcode: 0000 [#1] SMP
>> CPU: 5 PID: 1745 Comm: (sd-pam) Not tainted 4.11.0-rc1-00243-g24c534bb161b #1
>> Hardware name: System manufacturer System Product Name/Z170-K, BIOS
>> 1803 05/06/2016
>> RIP: 0010:free_swap_slot+0xba/0xd0
>> Call Trace:
>> swap_free+0x36/0x40
>> do_swap_page+0x360/0x6d0
>> __handle_mm_fault+0x880/0x1080
>> handle_mm_fault+0xd0/0x240
>> __do_page_fault+0x232/0x4d0
>> do_page_fault+0x20/0x70
>> page_fault+0x22/0x30
>> ---[ end trace aefc9ede53e0ab21 ]---
>>
>> so there seems to be something screwy in the new swap_slots code.
>
> I am travelling (LSFMM) so I didn't get to look at this more thoroughly
> but it seems like a race because enable_swap_slots_cache is called at
> the very end of the swapon and we could have already created a swap
> entry for a page by that time I guess.
>
>> Any ideas? I'm not finding other reports of this, but I'm also not
>> seeing why it should BUG_ON(). The "use_swap_slot_cache" thing very
>> much checks whether swap_slot_cache_initialized has been set, so the
>> BUG_ON() just seems like garbage. But please take a look.
>
> I guess you are right. I cannot speak of the original intention but it
> seems Tim wanted to be careful to not see unexpected swap entry when
> the swap wasn't initialized yet. I would just drop the BUG_ON and bail
> out when the slot cache hasn't been initialized yet.
Yes. The BUG_ON() is problematic. The initialization of swap slot
cache may fail too, if so, we should still allow using swap without slot
cache. Will send out a fixing patch ASAP.
Best Regards,
Huang, Ying
WARNING: multiple messages have this Message-ID (diff)
From: "Huang\, Ying" <ying.huang@intel.com>
To: Michal Hocko <mhocko@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tim Chen <tim.c.chen@linux.intel.com>,
"Huang, Ying" <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: kernel BUG at mm/swap_slots.c:270
Date: Mon, 20 Mar 2017 09:25:50 +0800 [thread overview]
Message-ID: <87d1dcd9i9.fsf@yhuang-dev.intel.com> (raw)
In-Reply-To: <20170319140447.GA12414@dhcp22.suse.cz> (Michal Hocko's message of "Sun, 19 Mar 2017 10:04:47 -0400")
Hi,
Michal Hocko <mhocko@kernel.org> writes:
> On Sat 18-03-17 09:57:18, Linus Torvalds wrote:
>> Tim at al,
>> I got this on my desktop at shutdown:
>>
>> ------------[ cut here ]------------
>> kernel BUG at mm/swap_slots.c:270!
>> invalid opcode: 0000 [#1] SMP
>> CPU: 5 PID: 1745 Comm: (sd-pam) Not tainted 4.11.0-rc1-00243-g24c534bb161b #1
>> Hardware name: System manufacturer System Product Name/Z170-K, BIOS
>> 1803 05/06/2016
>> RIP: 0010:free_swap_slot+0xba/0xd0
>> Call Trace:
>> swap_free+0x36/0x40
>> do_swap_page+0x360/0x6d0
>> __handle_mm_fault+0x880/0x1080
>> handle_mm_fault+0xd0/0x240
>> __do_page_fault+0x232/0x4d0
>> do_page_fault+0x20/0x70
>> page_fault+0x22/0x30
>> ---[ end trace aefc9ede53e0ab21 ]---
>>
>> so there seems to be something screwy in the new swap_slots code.
>
> I am travelling (LSFMM) so I didn't get to look at this more thoroughly
> but it seems like a race because enable_swap_slots_cache is called at
> the very end of the swapon and we could have already created a swap
> entry for a page by that time I guess.
>
>> Any ideas? I'm not finding other reports of this, but I'm also not
>> seeing why it should BUG_ON(). The "use_swap_slot_cache" thing very
>> much checks whether swap_slot_cache_initialized has been set, so the
>> BUG_ON() just seems like garbage. But please take a look.
>
> I guess you are right. I cannot speak of the original intention but it
> seems Tim wanted to be careful to not see unexpected swap entry when
> the swap wasn't initialized yet. I would just drop the BUG_ON and bail
> out when the slot cache hasn't been initialized yet.
Yes. The BUG_ON() is problematic. The initialization of swap slot
cache may fail too, if so, we should still allow using swap without slot
cache. Will send out a fixing patch ASAP.
Best Regards,
Huang, Ying
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-20 1:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-18 16:57 kernel BUG at mm/swap_slots.c:270 Linus Torvalds
2017-03-18 16:57 ` Linus Torvalds
2017-03-19 14:04 ` Michal Hocko
2017-03-19 14:04 ` Michal Hocko
2017-03-20 1:25 ` Huang, Ying [this message]
2017-03-20 1:25 ` Huang, Ying
2017-03-20 14:15 ` Tim Chen
2017-03-20 14:15 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1dcd9i9.fsf@yhuang-dev.intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.