* [PATCH] net: dsa: mv88e6xxx: Move forward declaration to where it is needed
@ 2017-02-08 0:40 Andrew Lunn
2017-02-08 14:38 ` Vivien Didelot
2017-02-08 19:46 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Lunn @ 2017-02-08 0:40 UTC (permalink / raw)
To: David Miller; +Cc: Vivien Didelot, netdev, Andrew Lunn
Move it out from the middle for the #defines to just before it is
needed.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
index c284e7f1f294..6713776ad26b 100644
--- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
+++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
@@ -660,8 +660,6 @@ enum mv88e6xxx_cap {
MV88E6XXX_FLAGS_MULTI_CHIP | \
MV88E6XXX_FLAGS_PVT)
-struct mv88e6xxx_ops;
-
#define MV88E6XXX_FLAGS_FAMILY_6390 \
(MV88E6XXX_FLAG_EEE | \
MV88E6XXX_FLAG_GLOBAL2 | \
@@ -672,6 +670,8 @@ struct mv88e6xxx_ops;
MV88E6XXX_FLAGS_MULTI_CHIP | \
MV88E6XXX_FLAGS_PVT)
+struct mv88e6xxx_ops;
+
struct mv88e6xxx_info {
enum mv88e6xxx_family family;
u16 prod_num;
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: Move forward declaration to where it is needed
2017-02-08 0:40 [PATCH] net: dsa: mv88e6xxx: Move forward declaration to where it is needed Andrew Lunn
@ 2017-02-08 14:38 ` Vivien Didelot
2017-02-08 19:46 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Vivien Didelot @ 2017-02-08 14:38 UTC (permalink / raw)
To: Andrew Lunn, David Miller; +Cc: netdev, Andrew Lunn
Hi Andrew,
Andrew Lunn <andrew@lunn.ch> writes:
> Move it out from the middle for the #defines to just before it is
> needed.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Thanks,
Vivien
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: Move forward declaration to where it is needed
2017-02-08 0:40 [PATCH] net: dsa: mv88e6xxx: Move forward declaration to where it is needed Andrew Lunn
2017-02-08 14:38 ` Vivien Didelot
@ 2017-02-08 19:46 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-02-08 19:46 UTC (permalink / raw)
To: andrew; +Cc: vivien.didelot, netdev
From: Andrew Lunn <andrew@lunn.ch>
Date: Wed, 8 Feb 2017 01:40:01 +0100
> Move it out from the middle for the #defines to just before it is
> needed.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
This looks like net-next material to me, but this patch doesn't apply there.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-08 19:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-08 0:40 [PATCH] net: dsa: mv88e6xxx: Move forward declaration to where it is needed Andrew Lunn
2017-02-08 14:38 ` Vivien Didelot
2017-02-08 19:46 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.