All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2,1/1] package/uacme: ualpn needs libopenssl
@ 2022-08-15 16:01 Fabrice Fontaine
  2022-08-15 19:31 ` [Buildroot] [PATCH v2, 1/1] " Yann E. MORIN
  0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Fontaine @ 2022-08-15 16:01 UTC (permalink / raw)
  To: buildroot; +Cc: Fabrice Fontaine, Nicola Di Lieto

ualpn is not compatible with libressl as stated by upstream in
https://github.com/ndilieto/uacme/commit/32546c7caa1626bbef860cf81e53d10e29fca5cb
resulting in the following build failure:

ualpn.c: In function 'ssl_client_hello_cb':
ualpn.c:2038:16: error: 'SSL_CLIENT_HELLO_RETRY' undeclared (first use in this function); did you mean 'SSL_F_CLIENT_HELLO'?
 2038 |         return SSL_CLIENT_HELLO_RETRY;
      |                ^~~~~~~~~~~~~~~~~~~~~~
      |                SSL_F_CLIENT_HELLO

Fixes:
 - http://autobuild.buildroot.org/results/d7d49cfce6f99c59e99c8e15399164fd5ecacc21

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2 (after review of Yann E. Morin):
 - Invert openssl and mbedtls order to avoid a build failure if libressl
   and mbedtls are enabled at the same time

 package/uacme/Config.in | 2 ++
 package/uacme/uacme.mk  | 6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/package/uacme/Config.in b/package/uacme/Config.in
index 796f54754e..2c6864871c 100644
--- a/package/uacme/Config.in
+++ b/package/uacme/Config.in
@@ -21,6 +21,8 @@ config BR2_PACKAGE_UACME_UALPN
 	bool "enable ualpn"
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_LIBEV
+	select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL \
+		if !(BR2_PACKAGE_GNUTLS || BR2_PACKAGE_MBEDTLS)
 	help
 	  Build and install ualpn, the transparent proxying tls-alpn-01
 	  challenge responder.
diff --git a/package/uacme/uacme.mk b/package/uacme/uacme.mk
index 2be96d534e..84e0105762 100644
--- a/package/uacme/uacme.mk
+++ b/package/uacme/uacme.mk
@@ -18,12 +18,12 @@ UACME_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'
 ifeq ($(BR2_PACKAGE_GNUTLS),y)
 UACME_CONF_OPTS += --with-gnutls
 UACME_DEPENDENCIES += gnutls
-else ifeq ($(BR2_PACKAGE_OPENSSL),y)
-UACME_CONF_OPTS += --with-openssl
-UACME_DEPENDENCIES += openssl
 else ifeq ($(BR2_PACKAGE_MBEDTLS),y)
 UACME_CONF_OPTS += --with-mbedtls
 UACME_DEPENDENCIES += mbedtls
+else ifeq ($(BR2_PACKAGE_OPENSSL),y)
+UACME_CONF_OPTS += --with-openssl
+UACME_DEPENDENCIES += openssl
 endif
 
 ifeq ($(BR2_PACKAGE_UACME_UALPN),y)
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v2, 1/1] package/uacme: ualpn needs libopenssl
  2022-08-15 16:01 [Buildroot] [PATCH v2,1/1] package/uacme: ualpn needs libopenssl Fabrice Fontaine
@ 2022-08-15 19:31 ` Yann E. MORIN
  2022-09-16 21:51   ` Peter Korsgaard
  0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2022-08-15 19:31 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Nicola Di Lieto, buildroot

Fabrice, All,

On 2022-08-15 18:01 +0200, Fabrice Fontaine spake thusly:
> ualpn is not compatible with libressl as stated by upstream in
> https://github.com/ndilieto/uacme/commit/32546c7caa1626bbef860cf81e53d10e29fca5cb
> resulting in the following build failure:
> 
> ualpn.c: In function 'ssl_client_hello_cb':
> ualpn.c:2038:16: error: 'SSL_CLIENT_HELLO_RETRY' undeclared (first use in this function); did you mean 'SSL_F_CLIENT_HELLO'?
>  2038 |         return SSL_CLIENT_HELLO_RETRY;
>       |                ^~~~~~~~~~~~~~~~~~~~~~
>       |                SSL_F_CLIENT_HELLO
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/d7d49cfce6f99c59e99c8e15399164fd5ecacc21
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Yann E. Morin):
>  - Invert openssl and mbedtls order to avoid a build failure if libressl
>    and mbedtls are enabled at the same time

I've split that in two patches:
    package/uacme: fix crypto backend preference order
    package/uacme: ualpn needs libopenssl

... and wrote an analysis and a rationale for the first one.

Applied to master, thanks.

Regards,
Yann E. MORIN.

>  package/uacme/Config.in | 2 ++
>  package/uacme/uacme.mk  | 6 +++---
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/package/uacme/Config.in b/package/uacme/Config.in
> index 796f54754e..2c6864871c 100644
> --- a/package/uacme/Config.in
> +++ b/package/uacme/Config.in
> @@ -21,6 +21,8 @@ config BR2_PACKAGE_UACME_UALPN
>  	bool "enable ualpn"
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	select BR2_PACKAGE_LIBEV
> +	select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL \
> +		if !(BR2_PACKAGE_GNUTLS || BR2_PACKAGE_MBEDTLS)
>  	help
>  	  Build and install ualpn, the transparent proxying tls-alpn-01
>  	  challenge responder.
> diff --git a/package/uacme/uacme.mk b/package/uacme/uacme.mk
> index 2be96d534e..84e0105762 100644
> --- a/package/uacme/uacme.mk
> +++ b/package/uacme/uacme.mk
> @@ -18,12 +18,12 @@ UACME_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'
>  ifeq ($(BR2_PACKAGE_GNUTLS),y)
>  UACME_CONF_OPTS += --with-gnutls
>  UACME_DEPENDENCIES += gnutls
> -else ifeq ($(BR2_PACKAGE_OPENSSL),y)
> -UACME_CONF_OPTS += --with-openssl
> -UACME_DEPENDENCIES += openssl
>  else ifeq ($(BR2_PACKAGE_MBEDTLS),y)
>  UACME_CONF_OPTS += --with-mbedtls
>  UACME_DEPENDENCIES += mbedtls
> +else ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +UACME_CONF_OPTS += --with-openssl
> +UACME_DEPENDENCIES += openssl
>  endif
>  
>  ifeq ($(BR2_PACKAGE_UACME_UALPN),y)
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v2, 1/1] package/uacme: ualpn needs libopenssl
  2022-08-15 19:31 ` [Buildroot] [PATCH v2, 1/1] " Yann E. MORIN
@ 2022-09-16 21:51   ` Peter Korsgaard
  0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-09-16 21:51 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: buildroot, Fabrice Fontaine, Nicola Di Lieto

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Fabrice, All,
 > On 2022-08-15 18:01 +0200, Fabrice Fontaine spake thusly:
 >> ualpn is not compatible with libressl as stated by upstream in
 >> https://github.com/ndilieto/uacme/commit/32546c7caa1626bbef860cf81e53d10e29fca5cb
 >> resulting in the following build failure:
 >> 
 >> ualpn.c: In function 'ssl_client_hello_cb':
 >> ualpn.c:2038:16: error: 'SSL_CLIENT_HELLO_RETRY' undeclared (first
 >> use in this function); did you mean 'SSL_F_CLIENT_HELLO'?
 >> 2038 |         return SSL_CLIENT_HELLO_RETRY;
 >> |                ^~~~~~~~~~~~~~~~~~~~~~
 >> |                SSL_F_CLIENT_HELLO
 >> 
 >> Fixes:
 >> - http://autobuild.buildroot.org/results/d7d49cfce6f99c59e99c8e15399164fd5ecacc21
 >> 
 >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 >> ---
 >> Changes v1 -> v2 (after review of Yann E. Morin):
 >> - Invert openssl and mbedtls order to avoid a build failure if libressl
 >> and mbedtls are enabled at the same time

 > I've split that in two patches:
 >     package/uacme: fix crypto backend preference order
 >     package/uacme: ualpn needs libopenssl

 > ... and wrote an analysis and a rationale for the first one.

Committed (both) to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-16 21:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-15 16:01 [Buildroot] [PATCH v2,1/1] package/uacme: ualpn needs libopenssl Fabrice Fontaine
2022-08-15 19:31 ` [Buildroot] [PATCH v2, 1/1] " Yann E. MORIN
2022-09-16 21:51   ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.