From: John Ogness <john.ogness@linutronix.de>
To: kernel test robot <lkp@intel.com>, Petr Mladek <pmladek@suse.com>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
Peter Zijlstra <peterz@infradead.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrea Parri <parri.andrea@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Paul McKenney <paulmck@kernel.org>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/4] printk: use the lockless ringbuffer
Date: Wed, 08 Jul 2020 15:24:20 +0206 [thread overview]
Message-ID: <87r1tmcfhf.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <202007080356.fSb8SLZk%lkp@intel.com>
Fix prepared for for v5.
On 2020-07-08, kernel test robot <lkp@intel.com> wrote:
>>> kernel/printk/printk.c:1146:10: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat]
> new_descs_size);
> ^~~~~~~~~~~~~~
> include/linux/printk.h:338:33: note: expanded from macro 'pr_err'
> printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
> ~~~ ^~~~~~~~~~~
> 1 warning generated.
Reported-by: kernel test robot <lkp@intel.com>
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index de8d54be4115..0b1337f4188c 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -1142,7 +1142,7 @@ void __init setup_log_buf(int early)
new_descs_size = new_descs_count * sizeof(struct prb_desc);
new_descs = memblock_alloc(new_descs_size, LOG_ALIGN);
if (unlikely(!new_descs)) {
- pr_err("log_buf_len: %lu desc bytes not available\n",
+ pr_err("log_buf_len: %zu desc bytes not available\n",
new_descs_size);
memblock_free(__pa(new_dict_buf), new_log_buf_len);
memblock_free(__pa(new_log_buf), new_log_buf_len);
WARNING: multiple messages have this Message-ID (diff)
From: John Ogness <john.ogness@linutronix.de>
To: kernel test robot <lkp@intel.com>, Petr Mladek <pmladek@suse.com>
Cc: Andrea Parri <parri.andrea@gmail.com>,
kbuild-all@lists.01.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Paul McKenney <paulmck@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
clang-built-linux@googlegroups.com,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v4 4/4] printk: use the lockless ringbuffer
Date: Wed, 08 Jul 2020 15:24:20 +0206 [thread overview]
Message-ID: <87r1tmcfhf.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <202007080356.fSb8SLZk%lkp@intel.com>
Fix prepared for for v5.
On 2020-07-08, kernel test robot <lkp@intel.com> wrote:
>>> kernel/printk/printk.c:1146:10: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat]
> new_descs_size);
> ^~~~~~~~~~~~~~
> include/linux/printk.h:338:33: note: expanded from macro 'pr_err'
> printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
> ~~~ ^~~~~~~~~~~
> 1 warning generated.
Reported-by: kernel test robot <lkp@intel.com>
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index de8d54be4115..0b1337f4188c 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -1142,7 +1142,7 @@ void __init setup_log_buf(int early)
new_descs_size = new_descs_count * sizeof(struct prb_desc);
new_descs = memblock_alloc(new_descs_size, LOG_ALIGN);
if (unlikely(!new_descs)) {
- pr_err("log_buf_len: %lu desc bytes not available\n",
+ pr_err("log_buf_len: %zu desc bytes not available\n",
new_descs_size);
memblock_free(__pa(new_dict_buf), new_log_buf_len);
memblock_free(__pa(new_log_buf), new_log_buf_len);
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: John Ogness <john.ogness@linutronix.de>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v4 4/4] printk: use the lockless ringbuffer
Date: Wed, 08 Jul 2020 15:24:20 +0206 [thread overview]
Message-ID: <87r1tmcfhf.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <202007080356.fSb8SLZk%lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]
Fix prepared for for v5.
On 2020-07-08, kernel test robot <lkp@intel.com> wrote:
>>> kernel/printk/printk.c:1146:10: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat]
> new_descs_size);
> ^~~~~~~~~~~~~~
> include/linux/printk.h:338:33: note: expanded from macro 'pr_err'
> printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
> ~~~ ^~~~~~~~~~~
> 1 warning generated.
Reported-by: kernel test robot <lkp@intel.com>
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index de8d54be4115..0b1337f4188c 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -1142,7 +1142,7 @@ void __init setup_log_buf(int early)
new_descs_size = new_descs_count * sizeof(struct prb_desc);
new_descs = memblock_alloc(new_descs_size, LOG_ALIGN);
if (unlikely(!new_descs)) {
- pr_err("log_buf_len: %lu desc bytes not available\n",
+ pr_err("log_buf_len: %zu desc bytes not available\n",
new_descs_size);
memblock_free(__pa(new_dict_buf), new_log_buf_len);
memblock_free(__pa(new_log_buf), new_log_buf_len);
next prev parent reply other threads:[~2020-07-08 13:18 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 14:59 [PATCH v4 0/4] printk: replace ringbuffer John Ogness
2020-07-07 14:59 ` John Ogness
2020-07-07 14:59 ` [PATCH v4 1/4] crash: add VMCOREINFO macro to define offset in a struct declared by typedef John Ogness
2020-07-07 14:59 ` John Ogness
2020-07-07 14:59 ` [PATCH v4 2/4] printk: add lockless ringbuffer John Ogness
2020-07-07 14:59 ` John Ogness
2020-07-07 14:59 ` [PATCH v4 3/4] Revert "printk: lock/unlock console only for new logbuf entries" John Ogness
2020-07-07 14:59 ` John Ogness
2020-07-08 14:34 ` Petr Mladek
2020-07-08 14:34 ` Petr Mladek
2020-07-09 1:20 ` Sergey Senozhatsky
2020-07-09 1:20 ` Sergey Senozhatsky
2020-07-07 14:59 ` [PATCH v4 4/4] printk: use the lockless ringbuffer John Ogness
2020-07-07 14:59 ` John Ogness
2020-07-07 19:25 ` kernel test robot
2020-07-07 19:25 ` kernel test robot
2020-07-07 19:25 ` kernel test robot
2020-07-08 13:18 ` John Ogness [this message]
2020-07-08 13:18 ` John Ogness
2020-07-08 13:18 ` John Ogness
2020-07-08 14:35 ` Petr Mladek
2020-07-08 14:35 ` Petr Mladek
2020-07-08 19:24 ` kernel test robot
2020-07-08 19:24 ` kernel test robot
2020-07-08 19:24 ` kernel test robot
2020-07-09 7:14 ` [printk] 18a2dc6982: ltp.kmsg01.fail kernel test robot
2020-07-09 7:14 ` kernel test robot
2020-07-09 8:33 ` Sergey Senozhatsky
2020-07-09 8:33 ` Sergey Senozhatsky
2020-07-09 10:14 ` John Ogness
2020-07-09 10:14 ` John Ogness
2020-07-09 10:59 ` Petr Mladek
2020-07-09 10:59 ` Petr Mladek
2020-07-09 11:13 ` Petr Mladek
2020-07-09 11:13 ` Petr Mladek
2020-07-09 11:17 ` John Ogness
2020-07-09 11:17 ` John Ogness
2020-07-09 12:25 ` Petr Mladek
2020-07-09 12:25 ` Petr Mladek
2020-07-09 13:07 ` Sergey Senozhatsky
2020-07-09 13:07 ` Sergey Senozhatsky
2020-07-09 14:41 ` Petr Mladek
2020-07-09 14:41 ` Petr Mladek
2020-07-08 15:20 ` [PATCH v4 0/4] printk: replace ringbuffer Petr Mladek
2020-07-08 15:20 ` Petr Mladek
2020-07-09 7:03 ` John Ogness
2020-07-09 7:03 ` John Ogness
2020-07-10 9:11 ` Petr Mladek
2020-07-10 9:11 ` Petr Mladek
2020-07-10 9:52 ` John Ogness
2020-07-10 9:52 ` John Ogness
2020-07-10 14:15 ` Petr Mladek
2020-07-10 14:15 ` Petr Mladek
2020-07-14 2:56 ` Sergey Senozhatsky
2020-07-14 2:56 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1tmcfhf.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=clang-built-linux@googlegroups.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=parri.andrea@gmail.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.