* [PATCH] usb: net: Add support for u-blox LARA-R6 modules family
@ 2021-06-28 14:35 Marco De Marco
2021-06-28 20:37 ` Bjørn Mork
2021-06-29 15:29 ` [PATCH] " Marco De Marco
0 siblings, 2 replies; 4+ messages in thread
From: Marco De Marco @ 2021-06-28 14:35 UTC (permalink / raw)
To: johan, linux-usb, bjorn, netdev
Support for u-blox LARA-R6 modules family.
Signed-off-by: Marco De Marco <marco.demarco@posteo.net>
---
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index d08e1de26..cb92c7c1e 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1115,6 +1115,7 @@ static const struct usb_device_id products[] = {
{QMI_FIXED_INTF(0x05c6, 0x9083, 3)},
{QMI_FIXED_INTF(0x05c6, 0x9084, 4)},
{QMI_FIXED_INTF(0x05c6, 0x90b2, 3)}, /* ublox R410M */
+ {QMI_QUIRK_SET_DTR(0x05c6, 0x90fA, 3)}, /* ublox R6XX */
{QMI_FIXED_INTF(0x05c6, 0x920d, 0)},
{QMI_FIXED_INTF(0x05c6, 0x920d, 5)},
{QMI_QUIRK_SET_DTR(0x05c6, 0x9625, 4)}, /* YUGA CLM920-NC5 */
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index aeaa3756f..05d0379c9 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -238,6 +238,7 @@ static void option_instat_callback(struct urb *urb);
#define QUECTEL_PRODUCT_UC15 0x9090
/* These u-blox products use Qualcomm's vendor ID */
#define UBLOX_PRODUCT_R410M 0x90b2
+#define UBLOX_PRODUCT_R6XX 0x90FA
/* These Yuga products use Qualcomm's vendor ID */
#define YUGA_PRODUCT_CLM920_NC5 0x9625
@@ -1101,6 +1102,8 @@ static const struct usb_device_id option_ids[] = {
/* u-blox products using Qualcomm vendor ID */
{ USB_DEVICE(QUALCOMM_VENDOR_ID, UBLOX_PRODUCT_R410M),
.driver_info = RSVD(1) | RSVD(3) },
+ { USB_DEVICE(QUALCOMM_VENDOR_ID, UBLOX_PRODUCT_R6XX),
+ .driver_info = RSVD(3) },
/* Quectel products using Quectel vendor ID */
{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC21, 0xff, 0xff, 0xff),
.driver_info = NUMEP2 },
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: net: Add support for u-blox LARA-R6 modules family
2021-06-28 14:35 [PATCH] usb: net: Add support for u-blox LARA-R6 modules family Marco De Marco
@ 2021-06-28 20:37 ` Bjørn Mork
2021-06-29 15:29 ` [PATCH] " Marco De Marco
1 sibling, 0 replies; 4+ messages in thread
From: Bjørn Mork @ 2021-06-28 20:37 UTC (permalink / raw)
To: Marco De Marco; +Cc: johan, linux-usb, netdev
Marco De Marco <marco.demarco@posteo.net> writes:
> Support for u-blox LARA-R6 modules family.
Thanks. But please split this in separate patches for net and usb.
Different subsystems with different trees and maintainers.
And while you are at it: Use lower case hex digits. In general:
Always try to follow the style of nearby code.
Bjørn
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: Add support for u-blox LARA-R6 modules family
2021-06-28 14:35 [PATCH] usb: net: Add support for u-blox LARA-R6 modules family Marco De Marco
2021-06-28 20:37 ` Bjørn Mork
@ 2021-06-29 15:29 ` Marco De Marco
2021-06-30 6:20 ` Bjørn Mork
1 sibling, 1 reply; 4+ messages in thread
From: Marco De Marco @ 2021-06-29 15:29 UTC (permalink / raw)
To: bjorn, netdev
Support for u-blox LARA-R6 modules family - QMI wan interface.
Signed-off-by: Marco De Marco <marco.demarco@posteo.net>
---
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index d08e1de26..cb92c7c1e 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1115,6 +1115,7 @@ static const struct usb_device_id products[] = {
{QMI_FIXED_INTF(0x05c6, 0x9083, 3)},
{QMI_FIXED_INTF(0x05c6, 0x9084, 4)},
{QMI_FIXED_INTF(0x05c6, 0x90b2, 3)}, /* ublox R410M */
+ {QMI_QUIRK_SET_DTR(0x05c6, 0x90fa, 3)}, /* ublox R6XX */
{QMI_FIXED_INTF(0x05c6, 0x920d, 0)},
{QMI_FIXED_INTF(0x05c6, 0x920d, 5)},
{QMI_QUIRK_SET_DTR(0x05c6, 0x9625, 4)}, /* YUGA CLM920-NC5 */
On lunedì 28 giugno 2021 16:35:56 CEST you wrote:
> Support for u-blox LARA-R6 modules family.
>
> Signed-off-by: Marco De Marco <marco.demarco@posteo.net>
>
> ---
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index d08e1de26..cb92c7c1e 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1115,6 +1115,7 @@ static const struct usb_device_id products[] = {
> {QMI_FIXED_INTF(0x05c6, 0x9083, 3)},
> {QMI_FIXED_INTF(0x05c6, 0x9084, 4)},
> {QMI_FIXED_INTF(0x05c6, 0x90b2, 3)}, /* ublox R410M */
> + {QMI_QUIRK_SET_DTR(0x05c6, 0x90fA, 3)}, /* ublox R6XX */
> {QMI_FIXED_INTF(0x05c6, 0x920d, 0)},
> {QMI_FIXED_INTF(0x05c6, 0x920d, 5)},
> {QMI_QUIRK_SET_DTR(0x05c6, 0x9625, 4)}, /* YUGA CLM920-NC5 */
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index aeaa3756f..05d0379c9 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -238,6 +238,7 @@ static void option_instat_callback(struct urb *urb);
> #define QUECTEL_PRODUCT_UC15 0x9090
> /* These u-blox products use Qualcomm's vendor ID */
> #define UBLOX_PRODUCT_R410M 0x90b2
> +#define UBLOX_PRODUCT_R6XX 0x90FA
> /* These Yuga products use Qualcomm's vendor ID */
> #define YUGA_PRODUCT_CLM920_NC5 0x9625
>
> @@ -1101,6 +1102,8 @@ static const struct usb_device_id option_ids[] = {
> /* u-blox products using Qualcomm vendor ID */
> { USB_DEVICE(QUALCOMM_VENDOR_ID, UBLOX_PRODUCT_R410M),
> .driver_info = RSVD(1) | RSVD(3) },
> + { USB_DEVICE(QUALCOMM_VENDOR_ID, UBLOX_PRODUCT_R6XX),
> + .driver_info = RSVD(3) },
> /* Quectel products using Quectel vendor ID */
> { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC21,
> 0xff, 0xff, 0xff), .driver_info = NUMEP2 },
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: Add support for u-blox LARA-R6 modules family
2021-06-29 15:29 ` [PATCH] " Marco De Marco
@ 2021-06-30 6:20 ` Bjørn Mork
0 siblings, 0 replies; 4+ messages in thread
From: Bjørn Mork @ 2021-06-30 6:20 UTC (permalink / raw)
To: Marco De Marco; +Cc: netdev
Marco De Marco <marco.demarco@posteo.net> writes:
> Support for u-blox LARA-R6 modules family - QMI wan interface.
>
> Signed-off-by: Marco De Marco <marco.demarco@posteo.net>
Acked-by: Bjørn Mork <bjorn@mork.no>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-30 6:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-28 14:35 [PATCH] usb: net: Add support for u-blox LARA-R6 modules family Marco De Marco
2021-06-28 20:37 ` Bjørn Mork
2021-06-29 15:29 ` [PATCH] " Marco De Marco
2021-06-30 6:20 ` Bjørn Mork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.