From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Pawel Laszczak <pawell@cadence.com>,
Roger Quadros <rogerq@ti.com>,
"devicetree\@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"mark.rutland\@arm.com" <mark.rutland@arm.com>,
"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
"hdegoede\@redhat.com" <hdegoede@redhat.com>,
"heikki.krogerus\@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"andy.shevchenko\@gmail.com" <andy.shevchenko@gmail.com>,
"robh+dt\@kernel.org" <robh+dt@kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jbergsagel\@ti.com" <jbergsagel@ti.com>,
"nsekhar\@ti.com" <nsekhar@ti.com>, "nm\@ti.com" <nm@ti.com>,
Suresh Punnoose <sureshp@cadence.com>,
"peter.chen\@nxp.com" <peter.chen@nxp.com>,
Rahul Kumar <kurahul@cadence.com>
Subject: RE: [PATCH v4 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer.
Date: Thu, 21 Feb 2019 09:14:30 +0200 [thread overview]
Message-ID: <87va1dbokp.fsf@linux.intel.com> (raw)
In-Reply-To: <BYAPR07MB470939C6F100336BAF6C41BFDD7D0@BYAPR07MB4709.namprd07.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]
Hi,
(please break your emails at 80-columns)
Pawel Laszczak <pawell@cadence.com> writes:
>>> One more thing. Workaround has implemented algorithm that decide for which
>>> endpoint it should be enabled. e.g for composite device MSC+NCM+ACM it
>>> should work only for ACM OUT endpoint.
>>>
>>
>>If ACM driver didn't queue the request for ACM OUT endpoint, why does the
>>controller accept the data at all?
>>
>>I didn't understand why we need a workaround for this. It should be standard
>>behaviour to NAK data if function driver didn't request for all endpoints.
>
> Yes, I agree with you. Controller shouldn’t accept such packet. As I know this
> behavior will be fixed in RTL.
>
> But I assume that some older version of this controller are one the market,
> and driver should work correct with them.
>
> In the feature this workaround can be limited only to selected controllers.
>
> Even now I assume that it can be enabled/disabled by module parameter.
no module parameters, please. Use revision detection in runtime.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Pawel Laszczak <pawell@cadence.com>,
Roger Quadros <rogerq@ti.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jbergsagel@ti.com" <jbergsagel@ti.com>,
"nsekhar@ti.com" <nsekhar@ti.com>, "nm@ti.com" <nm@ti.com>,
Suresh Punnoose <sureshp@cadence.com>,
"peter.chen@nxp.com" <peter.chen@nxp.com>,
Rahul Kumar <kurahul@cadence.com>
Subject: RE: [PATCH v4 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer.
Date: Thu, 21 Feb 2019 09:14:30 +0200 [thread overview]
Message-ID: <87va1dbokp.fsf@linux.intel.com> (raw)
In-Reply-To: <BYAPR07MB470939C6F100336BAF6C41BFDD7D0@BYAPR07MB4709.namprd07.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]
Hi,
(please break your emails at 80-columns)
Pawel Laszczak <pawell@cadence.com> writes:
>>> One more thing. Workaround has implemented algorithm that decide for which
>>> endpoint it should be enabled. e.g for composite device MSC+NCM+ACM it
>>> should work only for ACM OUT endpoint.
>>>
>>
>>If ACM driver didn't queue the request for ACM OUT endpoint, why does the
>>controller accept the data at all?
>>
>>I didn't understand why we need a workaround for this. It should be standard
>>behaviour to NAK data if function driver didn't request for all endpoints.
>
> Yes, I agree with you. Controller shouldn’t accept such packet. As I know this
> behavior will be fixed in RTL.
>
> But I assume that some older version of this controller are one the market,
> and driver should work correct with them.
>
> In the feature this workaround can be limited only to selected controllers.
>
> Even now I assume that it can be enabled/disabled by module parameter.
no module parameters, please. Use revision detection in runtime.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Pawel Laszczak <pawell@cadence.com>,
Roger Quadros <rogerq@ti.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jbergsagel@ti.com" <jbergsagel@ti.com>,
"nsekhar@ti.com" <nsekhar@ti.com>, "nm@ti.com" <nm@ti.com>,
Suresh Punnoose <sureshp@cadence.com>,
"peter.chen@nxp.com" <peter.chen@nxp.com>,
Rahul Kumar <kurahul@cadence.com>
Subject: [v4,6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer.
Date: Thu, 21 Feb 2019 09:14:30 +0200 [thread overview]
Message-ID: <87va1dbokp.fsf@linux.intel.com> (raw)
Hi,
(please break your emails at 80-columns)
Pawel Laszczak <pawell@cadence.com> writes:
>>> One more thing. Workaround has implemented algorithm that decide for which
>>> endpoint it should be enabled. e.g for composite device MSC+NCM+ACM it
>>> should work only for ACM OUT endpoint.
>>>
>>
>>If ACM driver didn't queue the request for ACM OUT endpoint, why does the
>>controller accept the data at all?
>>
>>I didn't understand why we need a workaround for this. It should be standard
>>behaviour to NAK data if function driver didn't request for all endpoints.
>
> Yes, I agree with you. Controller shouldn’t accept such packet. As I know this
> behavior will be fixed in RTL.
>
> But I assume that some older version of this controller are one the market,
> and driver should work correct with them.
>
> In the feature this workaround can be limited only to selected controllers.
>
> Even now I assume that it can be enabled/disabled by module parameter.
no module parameters, please. Use revision detection in runtime.
next prev parent reply other threads:[~2019-02-21 7:14 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 19:45 [PATCH v4 0/6] Introduced new Cadence USBSS DRD Driver Pawel Laszczak
2019-02-14 19:45 ` Pawel Laszczak
2019-02-14 19:45 ` [PATCH v4 1/6] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2019-02-14 19:45 ` [v4,1/6] " Pawel Laszczak
2019-02-14 19:45 ` [PATCH v4 1/6] " Pawel Laszczak
2019-02-18 16:46 ` Rob Herring
2019-02-18 16:46 ` [v4,1/6] " Rob Herring
2019-02-18 16:46 ` [PATCH v4 1/6] " Rob Herring
2019-02-14 19:45 ` [PATCH v4 2/6] usb:common Separated decoding functions from dwc3 driver Pawel Laszczak
2019-02-14 19:45 ` [v4,2/6] " Pawel Laszczak
2019-02-14 19:45 ` [PATCH v4 2/6] " Pawel Laszczak
2019-02-19 13:14 ` Greg KH
2019-02-19 13:14 ` [v4,2/6] " Greg Kroah-Hartman
2019-02-20 6:28 ` [PATCH v4 2/6] " Pawel Laszczak
2019-02-20 6:28 ` [v4,2/6] " Pawel Laszczak
2019-02-14 19:45 ` [PATCH v4 3/6] usb:common Patch simplify usb_decode_set_clear_feature function Pawel Laszczak
2019-02-14 19:45 ` [v4,3/6] " Pawel Laszczak
2019-02-14 19:45 ` [PATCH v4 3/6] " Pawel Laszczak
2019-02-14 19:45 ` [PATCH v4 4/6] usb:common Simplify usb_decode_get_set_descriptor function Pawel Laszczak
2019-02-14 19:45 ` [v4,4/6] " Pawel Laszczak
2019-02-14 19:45 ` [PATCH v4 4/6] " Pawel Laszczak
2019-02-14 19:45 ` [PATCH v4 5/6] usb:cdns3 Add Cadence USB3 DRD Driver Pawel Laszczak
2019-02-14 19:45 ` [v4,5/6] " Pawel Laszczak
2019-02-14 19:45 ` [PATCH v4 5/6] " Pawel Laszczak
2019-02-15 9:57 ` Chunfeng Yun
2019-02-15 9:57 ` [v4,5/6] " Chunfeng Yun
2019-02-15 9:57 ` [PATCH v4 5/6] " Chunfeng Yun
2019-03-04 11:01 ` Pawel Laszczak
2019-03-04 11:01 ` [v4,5/6] " Pawel Laszczak
2019-03-04 11:01 ` [PATCH v4 5/6] " Pawel Laszczak
2019-03-04 12:46 ` Pawel Laszczak
2019-03-04 12:46 ` [v4,5/6] " Pawel Laszczak
2019-03-04 12:46 ` [PATCH v4 5/6] " Pawel Laszczak
2019-03-05 1:42 ` Chunfeng Yun
2019-03-05 1:42 ` [v4,5/6] " Chunfeng Yun
2019-03-05 1:42 ` [PATCH v4 5/6] " Chunfeng Yun
2019-02-19 13:24 ` Greg KH
2019-02-19 13:24 ` [v4,5/6] " Greg Kroah-Hartman
2019-03-04 9:23 ` [PATCH v4 5/6] " Pawel Laszczak
2019-03-04 9:23 ` [v4,5/6] " Pawel Laszczak
2019-02-20 13:04 ` [PATCH v4 5/6] " Roger Quadros
2019-02-20 13:04 ` [v4,5/6] " Roger Quadros
2019-02-20 13:04 ` [PATCH v4 5/6] " Roger Quadros
2019-03-07 5:37 ` Pawel Laszczak
2019-03-07 5:37 ` [v4,5/6] " Pawel Laszczak
2019-03-11 11:53 ` [PATCH v4 5/6] " Roger Quadros
2019-03-11 11:53 ` [v4,5/6] " Roger Quadros
2019-03-28 6:05 ` [PATCH v4 5/6] " Pawel Laszczak
2019-03-28 6:05 ` [v4,5/6] " Pawel Laszczak
2019-02-21 9:22 ` [PATCH v4 5/6] " Peter Chen
2019-02-21 9:22 ` [v4,5/6] " Peter Chen
2019-02-21 9:22 ` [PATCH v4 5/6] " Peter Chen
2019-03-07 9:52 ` Pawel Laszczak
2019-03-07 9:52 ` [v4,5/6] " Pawel Laszczak
2019-03-12 3:44 ` [PATCH v4 5/6] " Peter Chen
2019-03-12 3:44 ` [v4,5/6] " Peter Chen
2019-03-28 8:26 ` [PATCH v4 5/6] " Pawel Laszczak
2019-02-14 19:45 ` [PATCH v4 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer Pawel Laszczak
2019-02-14 19:45 ` [v4,6/6] " Pawel Laszczak
2019-02-14 19:45 ` [PATCH v4 6/6] " Pawel Laszczak
2019-02-20 10:24 ` Roger Quadros
2019-02-20 10:24 ` [v4,6/6] " Roger Quadros
2019-02-20 10:24 ` [PATCH v4 6/6] " Roger Quadros
2019-02-20 11:18 ` Pawel Laszczak
2019-02-20 11:18 ` [v4,6/6] " Pawel Laszczak
2019-02-20 13:17 ` [PATCH v4 6/6] " Roger Quadros
2019-02-20 13:17 ` [v4,6/6] " Roger Quadros
2019-02-20 15:50 ` [PATCH v4 6/6] " Pawel Laszczak
2019-02-20 15:50 ` [v4,6/6] " Pawel Laszczak
2019-02-21 7:14 ` Felipe Balbi [this message]
2019-02-21 7:14 ` Felipe Balbi
2019-02-21 7:14 ` [PATCH v4 6/6] " Felipe Balbi
2019-03-04 10:25 ` Roger Quadros
2019-03-04 10:25 ` [v4,6/6] " Roger Quadros
2019-03-07 7:06 ` [PATCH v4 6/6] " Pawel Laszczak
2019-03-07 7:06 ` [v4,6/6] " Pawel Laszczak
2019-03-07 9:13 ` [PATCH v4 6/6] " Roger Quadros
2019-03-07 9:13 ` [v4,6/6] " Roger Quadros
2019-03-11 8:15 ` [PATCH v4 6/6] " Peter Chen
2019-03-11 8:15 ` [v4,6/6] " Peter Chen
2019-03-11 8:15 ` [PATCH v4 6/6] " Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va1dbokp.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jbergsagel@ti.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=sureshp@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.