All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] davfs2: new package
@ 2018-06-22 13:33 Roman Gorbenkov
  2018-06-22 13:33 ` [Buildroot] [PATCH 2/2] DEVELOPERS: add myself to package/davfs2 Roman Gorbenkov
  2018-06-24  9:27 ` [Buildroot] [PATCH 1/2] davfs2: new package Peter Korsgaard
  0 siblings, 2 replies; 4+ messages in thread
From: Roman Gorbenkov @ 2018-06-22 13:33 UTC (permalink / raw)
  To: buildroot

davfs2 is a Linux file system driver that allows to
mount a WebDAV resource. WebDAV is an extension to HTTP/1.1
that allows remote collaborative authoring of Web resources.

Signed-off-by: Roman Gorbenkov <roman.gorbenkov@ens2m.org>
---
 package/Config.in          |  1 +
 package/davfs2/Config.in   | 17 +++++++++++++++++
 package/davfs2/davfs2.hash |  5 +++++
 package/davfs2/davfs2.mk   | 19 +++++++++++++++++++
 4 files changed, 42 insertions(+)
 create mode 100644 package/davfs2/Config.in
 create mode 100644 package/davfs2/davfs2.hash
 create mode 100644 package/davfs2/davfs2.mk

diff --git a/package/Config.in b/package/Config.in
index a5ecfecbf9..c8e35fd99e 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -175,6 +175,7 @@ menu "Filesystem and flash utilities"
 	source "package/cpio/Config.in"
 	source "package/cramfs/Config.in"
 	source "package/curlftpfs/Config.in"
+	source "package/davfs2/Config.in"
 	source "package/dosfstools/Config.in"
 	source "package/e2fsprogs/Config.in"
 	source "package/e2tools/Config.in"
diff --git a/package/davfs2/Config.in b/package/davfs2/Config.in
new file mode 100644
index 0000000000..9a2e20586c
--- /dev/null
+++ b/package/davfs2/Config.in
@@ -0,0 +1,17 @@
+comment "DAVFS2 needs a toolchain w/ regular stack smashing protection support"
+	depends on !BR2_TOOLCHAIN_BUILDROOT_USE_SSP || !BR2_SSP_REGULAR
+
+config BR2_PACKAGE_DAVFS2
+	bool "davfs2"
+	depends on BR2_TOOLCHAIN_BUILDROOT_USE_SSP
+	depends on BR2_SSP_REGULAR
+	select BR2_PACKAGE_NEON
+	select BR2_PACKAGE_NEON_XML
+	help
+	  davfs2 is a Linux file system driver that allows to
+	  mount a WebDAV resource. WebDAV is an extension to HTTP/1.1
+	  that allows remote collaborative authoring of Web resources.
+	  To use davfs2 via /etc/fstab, FEATURE_MOUNT_HELPERS
+	  must be selected in busybox configuration.
+
+	  http://savannah.nongnu.org/projects/davfs2
diff --git a/package/davfs2/davfs2.hash b/package/davfs2/davfs2.hash
new file mode 100644
index 0000000000..97ce80bfe0
--- /dev/null
+++ b/package/davfs2/davfs2.hash
@@ -0,0 +1,5 @@
+# Calculated based on the hash above
+#Locally calculated
+sha256 c9c4e0f0912a782386216b2147eb9c36c47f193b8fcf3d637719e0b9fe7c96e0  davfs2-1.5.4.tar.gz
+#License file, locally calculated
+sha256 0ae0485a5bd37a63e63603596417e4eb0e653334fa6c7f932ca3a0e85d4af227  COPYING
diff --git a/package/davfs2/davfs2.mk b/package/davfs2/davfs2.mk
new file mode 100644
index 0000000000..da5ea530a0
--- /dev/null
+++ b/package/davfs2/davfs2.mk
@@ -0,0 +1,19 @@
+################################################################################
+#
+# davfs2
+#
+################################################################################
+
+DAVFS2_VERSION = 1.5.4
+DAVFS2_SITE = http://download.savannah.nongnu.org/releases/davfs2/davfs2-$(DAVFS2_VERSION).tar.gz
+DAVFS2_LICENSE = GPL-3.0+
+DAVFS2_LICENSE_FILES = COPYING
+
+DAVFS2_DEPENDENCIES = neon
+
+DAVFS2_AUTORECONF = YES
+
+DAVFS2_CONF_ENV += \
+    ac_cv_path_NEON_CONFIG=$(STAGING_DIR)/usr/bin/neon-config
+
+$(eval $(autotools-package))
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] DEVELOPERS: add myself to package/davfs2
  2018-06-22 13:33 [Buildroot] [PATCH 1/2] davfs2: new package Roman Gorbenkov
@ 2018-06-22 13:33 ` Roman Gorbenkov
  2018-06-24  9:34   ` Peter Korsgaard
  2018-06-24  9:27 ` [Buildroot] [PATCH 1/2] davfs2: new package Peter Korsgaard
  1 sibling, 1 reply; 4+ messages in thread
From: Roman Gorbenkov @ 2018-06-22 13:33 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Roman Gorbenkov <roman.gorbenkov@ens2m.org>
---
 DEVELOPERS | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/DEVELOPERS b/DEVELOPERS
index d22ac527fa..85b341e7ce 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1664,6 +1664,9 @@ F:	package/chocolate-doom/
 F:	package/irssi/
 F:	package/vnstat/
 
+N:	Roman Gorbenkov <roman.gorbenkov@ens2m.org>
+F:	package/davfs2/
+
 N:	Romain Naour <romain.naour@gmail.com>
 F:	package/aubio/
 F:	package/bullet/
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/2] davfs2: new package
  2018-06-22 13:33 [Buildroot] [PATCH 1/2] davfs2: new package Roman Gorbenkov
  2018-06-22 13:33 ` [Buildroot] [PATCH 2/2] DEVELOPERS: add myself to package/davfs2 Roman Gorbenkov
@ 2018-06-24  9:27 ` Peter Korsgaard
  1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2018-06-24  9:27 UTC (permalink / raw)
  To: buildroot

>>>>> "Roman" == Roman Gorbenkov <roman.gorbenkov@ens2m.org> writes:

 > davfs2 is a Linux file system driver that allows to
 > mount a WebDAV resource. WebDAV is an extension to HTTP/1.1
 > that allows remote collaborative authoring of Web resources.

 > Signed-off-by: Roman Gorbenkov <roman.gorbenkov@ens2m.org>
 > ---
 >  package/Config.in          |  1 +
 >  package/davfs2/Config.in   | 17 +++++++++++++++++
 >  package/davfs2/davfs2.hash |  5 +++++
 >  package/davfs2/davfs2.mk   | 19 +++++++++++++++++++
 >  4 files changed, 42 insertions(+)
 >  create mode 100644 package/davfs2/Config.in
 >  create mode 100644 package/davfs2/davfs2.hash
 >  create mode 100644 package/davfs2/davfs2.mk

 > diff --git a/package/Config.in b/package/Config.in
 > index a5ecfecbf9..c8e35fd99e 100644
 > --- a/package/Config.in
 > +++ b/package/Config.in
 > @@ -175,6 +175,7 @@ menu "Filesystem and flash utilities"
 >  	source "package/cpio/Config.in"
 >  	source "package/cramfs/Config.in"
 >  	source "package/curlftpfs/Config.in"
 > +	source "package/davfs2/Config.in"
 >  	source "package/dosfstools/Config.in"
 >  	source "package/e2fsprogs/Config.in"
 >  	source "package/e2tools/Config.in"
 > diff --git a/package/davfs2/Config.in b/package/davfs2/Config.in
 > new file mode 100644
 > index 0000000000..9a2e20586c
 > --- /dev/null
 > +++ b/package/davfs2/Config.in
 > @@ -0,0 +1,17 @@
 > +comment "DAVFS2 needs a toolchain w/ regular stack smashing protection support"
 > +	depends on !BR2_TOOLCHAIN_BUILDROOT_USE_SSP || !BR2_SSP_REGULAR

DAVFS2 should be in lower case. This dependency is kind of annoying, and
is also because src/Makefile.am hardcodes -fstack-protector-strong, so
I've instead added a patch to drop this. Buildroot will pass the correct
-fstack-protector-* arguments if so configured.

> +config BR2_PACKAGE_DAVFS2
 > +	bool "davfs2"
 > +	depends on BR2_TOOLCHAIN_BUILDROOT_USE_SSP
 > +	depends on BR2_SSP_REGULAR
 > +	select BR2_PACKAGE_NEON
 > +	select BR2_PACKAGE_NEON_XML

It uses fork() so it should depend on BR2_USE_MMU.

It uses error.h which doesn't exist on musl, so it should depend on
!BR2_TOOLCHAIN_USES_MUSL (and show a comment when musl is used).

Please consider testing with ./utils/test-pkg to verify such things.

 > +++ b/package/davfs2/davfs2.hash
 > @@ -0,0 +1,5 @@
 > +# Calculated based on the hash above

? Dropped.

> +#Locally calculated
 > +sha256 c9c4e0f0912a782386216b2147eb9c36c47f193b8fcf3d637719e0b9fe7c96e0  davfs2-1.5.4.tar.gz
 > +#License file, locally calculated
 > +sha256 0ae0485a5bd37a63e63603596417e4eb0e653334fa6c7f932ca3a0e85d4af227  COPYING

Nit: We normally have a space between '#' and the text. Fixed.

> diff --git a/package/davfs2/davfs2.mk b/package/davfs2/davfs2.mk
 > new file mode 100644
 > index 0000000000..da5ea530a0
 > --- /dev/null
 > +++ b/package/davfs2/davfs2.mk
 > @@ -0,0 +1,19 @@
 > +################################################################################
 > +#
 > +# davfs2
 > +#
 > +################################################################################
 > +
 > +DAVFS2_VERSION = 1.5.4
 > +DAVFS2_SITE = http://download.savannah.nongnu.org/releases/davfs2/davfs2-$(DAVFS2_VERSION).tar.gz

The tarball name should not be part of the URL. This will try to
download:

http://download.savannah.nongnu.org/releases/davfs2/davfs2-1.5.4.tar.gz/davfs2-1.5.4.tar.gz

Which doesn't exist. Fixed.


> +DAVFS2_LICENSE = GPL-3.0+
 > +DAVFS2_LICENSE_FILES = COPYING
 > +
 > +DAVFS2_DEPENDENCIES = neon
 > +
 > +DAVFS2_AUTORECONF = YES

Why? You don't patch anything and the configure script is included in
the tarball. Dropped.

Committed with these fixes, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] DEVELOPERS: add myself to package/davfs2
  2018-06-22 13:33 ` [Buildroot] [PATCH 2/2] DEVELOPERS: add myself to package/davfs2 Roman Gorbenkov
@ 2018-06-24  9:34   ` Peter Korsgaard
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2018-06-24  9:34 UTC (permalink / raw)
  To: buildroot

>>>>> "Roman" == Roman Gorbenkov <roman.gorbenkov@ens2m.org> writes:

 > Signed-off-by: Roman Gorbenkov <roman.gorbenkov@ens2m.org>
 > ---
 >  DEVELOPERS | 3 +++
 >  1 file changed, 3 insertions(+)

 > diff --git a/DEVELOPERS b/DEVELOPERS
 > index d22ac527fa..85b341e7ce 100644
 > --- a/DEVELOPERS
 > +++ b/DEVELOPERS
 > @@ -1664,6 +1664,9 @@ F:	package/chocolate-doom/
 >  F:	package/irssi/
 >  F:	package/vnstat/
 
 > +N:	Roman Gorbenkov <roman.gorbenkov@ens2m.org>
 > +F:	package/davfs2/

This should have been part of the commit adding davfs2. I've merged it
with that commit and applied, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-24  9:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-22 13:33 [Buildroot] [PATCH 1/2] davfs2: new package Roman Gorbenkov
2018-06-22 13:33 ` [Buildroot] [PATCH 2/2] DEVELOPERS: add myself to package/davfs2 Roman Gorbenkov
2018-06-24  9:34   ` Peter Korsgaard
2018-06-24  9:27 ` [Buildroot] [PATCH 1/2] davfs2: new package Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.