All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: mt7622: specify the number of DMA requests
@ 2022-04-29  8:42 ` Rui Salvaterra
  0 siblings, 0 replies; 12+ messages in thread
From: Rui Salvaterra @ 2022-04-29  8:42 UTC (permalink / raw)
  To: linux-arm-kernel, linux-mediatek, linux-kernel
  Cc: matthias.bgg, ryder.lee, daniel, Rui Salvaterra

The MT7622 device tree never bothered to specify the number of virtual DMA
channels for the HSDMA controller, always falling back to the default value of
3. Make this value explicit, in order to avoid the following dmesg notification:

mtk_hsdma 1b007000.dma-controller: Using 3 as missing dma-requests property

Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
---
 arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
index 3d6eaf6dd078..5551f004945b 100644
--- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
@@ -924,6 +924,7 @@ hsdma: dma-controller@1b007000 {
 		clock-names = "hsdma";
 		power-domains = <&scpsys MT7622_POWER_DOMAIN_ETHSYS>;
 		#dma-cells = <1>;
+		dma-requests = <3>;
 	};
 
 	eth: ethernet@1b100000 {
-- 
2.36.0


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH] arm64: dts: mt7622: specify the number of DMA requests
@ 2022-04-29  8:42 ` Rui Salvaterra
  0 siblings, 0 replies; 12+ messages in thread
From: Rui Salvaterra @ 2022-04-29  8:42 UTC (permalink / raw)
  To: linux-arm-kernel, linux-mediatek, linux-kernel
  Cc: matthias.bgg, ryder.lee, daniel, Rui Salvaterra

The MT7622 device tree never bothered to specify the number of virtual DMA
channels for the HSDMA controller, always falling back to the default value of
3. Make this value explicit, in order to avoid the following dmesg notification:

mtk_hsdma 1b007000.dma-controller: Using 3 as missing dma-requests property

Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
---
 arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
index 3d6eaf6dd078..5551f004945b 100644
--- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
@@ -924,6 +924,7 @@ hsdma: dma-controller@1b007000 {
 		clock-names = "hsdma";
 		power-domains = <&scpsys MT7622_POWER_DOMAIN_ETHSYS>;
 		#dma-cells = <1>;
+		dma-requests = <3>;
 	};
 
 	eth: ethernet@1b100000 {
-- 
2.36.0


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH] arm64: dts: mt7622: specify the number of DMA requests
@ 2022-04-29  8:42 ` Rui Salvaterra
  0 siblings, 0 replies; 12+ messages in thread
From: Rui Salvaterra @ 2022-04-29  8:42 UTC (permalink / raw)
  To: linux-arm-kernel, linux-mediatek, linux-kernel
  Cc: matthias.bgg, ryder.lee, daniel, Rui Salvaterra

The MT7622 device tree never bothered to specify the number of virtual DMA
channels for the HSDMA controller, always falling back to the default value of
3. Make this value explicit, in order to avoid the following dmesg notification:

mtk_hsdma 1b007000.dma-controller: Using 3 as missing dma-requests property

Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
---
 arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
index 3d6eaf6dd078..5551f004945b 100644
--- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
@@ -924,6 +924,7 @@ hsdma: dma-controller@1b007000 {
 		clock-names = "hsdma";
 		power-domains = <&scpsys MT7622_POWER_DOMAIN_ETHSYS>;
 		#dma-cells = <1>;
+		dma-requests = <3>;
 	};
 
 	eth: ethernet@1b100000 {
-- 
2.36.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64: dts: mt7622: specify the number of DMA requests
  2022-04-29  8:42 ` Rui Salvaterra
  (?)
@ 2022-04-29 11:57   ` Matthias Brugger
  -1 siblings, 0 replies; 12+ messages in thread
From: Matthias Brugger @ 2022-04-29 11:57 UTC (permalink / raw)
  To: Rui Salvaterra, linux-arm-kernel, linux-mediatek, linux-kernel
  Cc: ryder.lee, daniel



On 29/04/2022 10:42, Rui Salvaterra wrote:
> The MT7622 device tree never bothered to specify the number of virtual DMA
> channels for the HSDMA controller, always falling back to the default value of
> 3. Make this value explicit, in order to avoid the following dmesg notification:
> 
> mtk_hsdma 1b007000.dma-controller: Using 3 as missing dma-requests property
> 
> Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>

Applied, thanks!

> ---
>   arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> index 3d6eaf6dd078..5551f004945b 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> @@ -924,6 +924,7 @@ hsdma: dma-controller@1b007000 {
>   		clock-names = "hsdma";
>   		power-domains = <&scpsys MT7622_POWER_DOMAIN_ETHSYS>;
>   		#dma-cells = <1>;
> +		dma-requests = <3>;
>   	};
>   
>   	eth: ethernet@1b100000 {

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64: dts: mt7622: specify the number of DMA requests
@ 2022-04-29 11:57   ` Matthias Brugger
  0 siblings, 0 replies; 12+ messages in thread
From: Matthias Brugger @ 2022-04-29 11:57 UTC (permalink / raw)
  To: Rui Salvaterra, linux-arm-kernel, linux-mediatek, linux-kernel
  Cc: ryder.lee, daniel



On 29/04/2022 10:42, Rui Salvaterra wrote:
> The MT7622 device tree never bothered to specify the number of virtual DMA
> channels for the HSDMA controller, always falling back to the default value of
> 3. Make this value explicit, in order to avoid the following dmesg notification:
> 
> mtk_hsdma 1b007000.dma-controller: Using 3 as missing dma-requests property
> 
> Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>

Applied, thanks!

> ---
>   arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> index 3d6eaf6dd078..5551f004945b 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> @@ -924,6 +924,7 @@ hsdma: dma-controller@1b007000 {
>   		clock-names = "hsdma";
>   		power-domains = <&scpsys MT7622_POWER_DOMAIN_ETHSYS>;
>   		#dma-cells = <1>;
> +		dma-requests = <3>;
>   	};
>   
>   	eth: ethernet@1b100000 {

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64: dts: mt7622: specify the number of DMA requests
@ 2022-04-29 11:57   ` Matthias Brugger
  0 siblings, 0 replies; 12+ messages in thread
From: Matthias Brugger @ 2022-04-29 11:57 UTC (permalink / raw)
  To: Rui Salvaterra, linux-arm-kernel, linux-mediatek, linux-kernel
  Cc: ryder.lee, daniel



On 29/04/2022 10:42, Rui Salvaterra wrote:
> The MT7622 device tree never bothered to specify the number of virtual DMA
> channels for the HSDMA controller, always falling back to the default value of
> 3. Make this value explicit, in order to avoid the following dmesg notification:
> 
> mtk_hsdma 1b007000.dma-controller: Using 3 as missing dma-requests property
> 
> Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>

Applied, thanks!

> ---
>   arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> index 3d6eaf6dd078..5551f004945b 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> @@ -924,6 +924,7 @@ hsdma: dma-controller@1b007000 {
>   		clock-names = "hsdma";
>   		power-domains = <&scpsys MT7622_POWER_DOMAIN_ETHSYS>;
>   		#dma-cells = <1>;
> +		dma-requests = <3>;
>   	};
>   
>   	eth: ethernet@1b100000 {

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64: dts: mt7622: specify the number of DMA requests
  2022-04-29 11:57   ` Matthias Brugger
  (?)
@ 2022-04-29 13:05     ` Rui Salvaterra
  -1 siblings, 0 replies; 12+ messages in thread
From: Rui Salvaterra @ 2022-04-29 13:05 UTC (permalink / raw)
  To: Matthias Brugger
  Cc: linux-arm-kernel, linux-mediatek, linux-kernel, ryder.lee, daniel

Hi, Matthias,

On Fri, 29 Apr 2022 at 12:57, Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
> Applied, thanks!

Would this and the cache topology patch qualify as stable material?
Intuitively, I'd say yes, but I'm not really sure.

Thanks,
Rui

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64: dts: mt7622: specify the number of DMA requests
@ 2022-04-29 13:05     ` Rui Salvaterra
  0 siblings, 0 replies; 12+ messages in thread
From: Rui Salvaterra @ 2022-04-29 13:05 UTC (permalink / raw)
  To: Matthias Brugger
  Cc: linux-arm-kernel, linux-mediatek, linux-kernel, ryder.lee, daniel

Hi, Matthias,

On Fri, 29 Apr 2022 at 12:57, Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
> Applied, thanks!

Would this and the cache topology patch qualify as stable material?
Intuitively, I'd say yes, but I'm not really sure.

Thanks,
Rui

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64: dts: mt7622: specify the number of DMA requests
@ 2022-04-29 13:05     ` Rui Salvaterra
  0 siblings, 0 replies; 12+ messages in thread
From: Rui Salvaterra @ 2022-04-29 13:05 UTC (permalink / raw)
  To: Matthias Brugger
  Cc: linux-arm-kernel, linux-mediatek, linux-kernel, ryder.lee, daniel

Hi, Matthias,

On Fri, 29 Apr 2022 at 12:57, Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
> Applied, thanks!

Would this and the cache topology patch qualify as stable material?
Intuitively, I'd say yes, but I'm not really sure.

Thanks,
Rui

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64: dts: mt7622: specify the number of DMA requests
  2022-04-29 13:05     ` Rui Salvaterra
  (?)
@ 2022-04-29 14:14       ` Matthias Brugger
  -1 siblings, 0 replies; 12+ messages in thread
From: Matthias Brugger @ 2022-04-29 14:14 UTC (permalink / raw)
  To: Rui Salvaterra
  Cc: linux-arm-kernel, linux-mediatek, linux-kernel, ryder.lee, daniel

Hi Rui,

On 29/04/2022 15:05, Rui Salvaterra wrote:
> Hi, Matthias,
> 
> On Fri, 29 Apr 2022 at 12:57, Matthias Brugger <matthias.bgg@gmail.com> wrote:
>>
>> Applied, thanks!
> 
> Would this and the cache topology patch qualify as stable material?
> Intuitively, I'd say yes, but I'm not really sure.
> 

my understanding is that these fix some warning, but no real bug in the sense 
something does not work without them. So no I don't think they are stable material.

Regards,
Matthias

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64: dts: mt7622: specify the number of DMA requests
@ 2022-04-29 14:14       ` Matthias Brugger
  0 siblings, 0 replies; 12+ messages in thread
From: Matthias Brugger @ 2022-04-29 14:14 UTC (permalink / raw)
  To: Rui Salvaterra
  Cc: linux-arm-kernel, linux-mediatek, linux-kernel, ryder.lee, daniel

Hi Rui,

On 29/04/2022 15:05, Rui Salvaterra wrote:
> Hi, Matthias,
> 
> On Fri, 29 Apr 2022 at 12:57, Matthias Brugger <matthias.bgg@gmail.com> wrote:
>>
>> Applied, thanks!
> 
> Would this and the cache topology patch qualify as stable material?
> Intuitively, I'd say yes, but I'm not really sure.
> 

my understanding is that these fix some warning, but no real bug in the sense 
something does not work without them. So no I don't think they are stable material.

Regards,
Matthias

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] arm64: dts: mt7622: specify the number of DMA requests
@ 2022-04-29 14:14       ` Matthias Brugger
  0 siblings, 0 replies; 12+ messages in thread
From: Matthias Brugger @ 2022-04-29 14:14 UTC (permalink / raw)
  To: Rui Salvaterra
  Cc: linux-arm-kernel, linux-mediatek, linux-kernel, ryder.lee, daniel

Hi Rui,

On 29/04/2022 15:05, Rui Salvaterra wrote:
> Hi, Matthias,
> 
> On Fri, 29 Apr 2022 at 12:57, Matthias Brugger <matthias.bgg@gmail.com> wrote:
>>
>> Applied, thanks!
> 
> Would this and the cache topology patch qualify as stable material?
> Intuitively, I'd say yes, but I'm not really sure.
> 

my understanding is that these fix some warning, but no real bug in the sense 
something does not work without them. So no I don't think they are stable material.

Regards,
Matthias

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2022-04-29 14:16 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-29  8:42 [PATCH] arm64: dts: mt7622: specify the number of DMA requests Rui Salvaterra
2022-04-29  8:42 ` Rui Salvaterra
2022-04-29  8:42 ` Rui Salvaterra
2022-04-29 11:57 ` Matthias Brugger
2022-04-29 11:57   ` Matthias Brugger
2022-04-29 11:57   ` Matthias Brugger
2022-04-29 13:05   ` Rui Salvaterra
2022-04-29 13:05     ` Rui Salvaterra
2022-04-29 13:05     ` Rui Salvaterra
2022-04-29 14:14     ` Matthias Brugger
2022-04-29 14:14       ` Matthias Brugger
2022-04-29 14:14       ` Matthias Brugger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.