All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Mark Brown <broonie@kernel.org>
Cc: "Robin Murphy" <robin.murphy@arm.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Jean Delvare" <jdelvare@suse.com>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Lee Jones" <lee.jones@linaro.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Wim Van Sebroeck" <wim@linux-watchdog.org>,
	"Shawn Guo" <shawnguo@kernel.org>, "Li Yang" <leoyang.li@nxp.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Jason Cooper" <jason@lakedaemon.net>,
	"Marc Zyngier" <maz@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3 02/16] mfd: mfd-core: Don't overwrite the dma_mask of the child device
Date: Thu, 14 May 2020 22:45:53 +0200	[thread overview]
Message-ID: <8fb998f882938680d98f1c2f6f8254c1@walle.cc> (raw)
In-Reply-To: <20200428152543.GI5677@sirena.org.uk>

Am 2020-04-28 17:25, schrieb Mark Brown:
> On Tue, Apr 28, 2020 at 03:49:49PM +0100, Robin Murphy wrote:
> 
>> For better or worse, the platform bus is the dumping ground for random 
>> crap,
>> so we just have to deal with all the abstraction breakage that leaks 
>> out of
>> that.
> 
> The reason we're using the platform bus for this is that historically
> people were creating buses which were essentially carbon copies of the
> platform bus with the name changed and it was felt that rather than
> duplicate code it was better to just use platform devices with no MMIO
> ranges defined.  If there's some assumptions about DMA for platform
> devices floating about somewhere it might be reasonable to revisit this
> and create a non-DMA variant of platform devices since there is a
> meaningful difference.

Was there any conclusion? Should I keep or drop this patch in the next 
version
of this series?

-- 
-michael

WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael-QKn5cuLxLXY@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "Robin Murphy" <robin.murphy-5wv7dgnIgG8@public.gmane.org>,
	"Andy Shevchenko"
	<andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-hwmon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	"Linus Walleij"
	<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"Bartosz Golaszewski"
	<bgolaszewski-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Jean Delvare" <jdelvare-IBi9RG/b67k@public.gmane.org>,
	"Guenter Roeck" <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
	"Lee Jones" <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"Thierry Reding"
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Uwe Kleine-König"
	<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	"Wim Van Sebroeck"
	<wim-Q8PRGTgFL9WUCWQAtAn6Ix2eb7JE58TQ@public.gmane.org>,
	"Shawn Guo" <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Li Yang" <leoyang.li-3arQi8VN3Tc@public.gmane.org>
Subject: Re: [PATCH v3 02/16] mfd: mfd-core: Don't overwrite the dma_mask of the child device
Date: Thu, 14 May 2020 22:45:53 +0200	[thread overview]
Message-ID: <8fb998f882938680d98f1c2f6f8254c1@walle.cc> (raw)
In-Reply-To: <20200428152543.GI5677-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>

Am 2020-04-28 17:25, schrieb Mark Brown:
> On Tue, Apr 28, 2020 at 03:49:49PM +0100, Robin Murphy wrote:
> 
>> For better or worse, the platform bus is the dumping ground for random 
>> crap,
>> so we just have to deal with all the abstraction breakage that leaks 
>> out of
>> that.
> 
> The reason we're using the platform bus for this is that historically
> people were creating buses which were essentially carbon copies of the
> platform bus with the name changed and it was felt that rather than
> duplicate code it was better to just use platform devices with no MMIO
> ranges defined.  If there's some assumptions about DMA for platform
> devices floating about somewhere it might be reasonable to revisit this
> and create a non-DMA variant of platform devices since there is a
> meaningful difference.

Was there any conclusion? Should I keep or drop this patch in the next 
version
of this series?

-- 
-michael

WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc>
To: Mark Brown <broonie@kernel.org>
Cc: linux-pwm@vger.kernel.org,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Lee Jones" <lee.jones@linaro.org>,
	"Jason Cooper" <jason@lakedaemon.net>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Marc Zyngier" <maz@kernel.org>,
	"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Guenter Roeck" <linux@roeck-us.net>,
	devicetree@vger.kernel.org, "Jean Delvare" <jdelvare@suse.com>,
	linux-watchdog@vger.kernel.org, linux-gpio@vger.kernel.org,
	"Rob Herring" <robh+dt@kernel.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Wim Van Sebroeck" <wim@linux-watchdog.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-hwmon@vger.kernel.org, "Shawn Guo" <shawnguo@kernel.org>,
	linux-kernel@vger.kernel.org, "Li Yang" <leoyang.li@nxp.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Robin Murphy" <robin.murphy@arm.com>
Subject: Re: [PATCH v3 02/16] mfd: mfd-core: Don't overwrite the dma_mask of the child device
Date: Thu, 14 May 2020 22:45:53 +0200	[thread overview]
Message-ID: <8fb998f882938680d98f1c2f6f8254c1@walle.cc> (raw)
In-Reply-To: <20200428152543.GI5677@sirena.org.uk>

Am 2020-04-28 17:25, schrieb Mark Brown:
> On Tue, Apr 28, 2020 at 03:49:49PM +0100, Robin Murphy wrote:
> 
>> For better or worse, the platform bus is the dumping ground for random 
>> crap,
>> so we just have to deal with all the abstraction breakage that leaks 
>> out of
>> that.
> 
> The reason we're using the platform bus for this is that historically
> people were creating buses which were essentially carbon copies of the
> platform bus with the name changed and it was felt that rather than
> duplicate code it was better to just use platform devices with no MMIO
> ranges defined.  If there's some assumptions about DMA for platform
> devices floating about somewhere it might be reasonable to revisit this
> and create a non-DMA variant of platform devices since there is a
> meaningful difference.

Was there any conclusion? Should I keep or drop this patch in the next 
version
of this series?

-- 
-michael

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-05-14 20:46 UTC|newest]

Thread overview: 177+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23 17:45 [PATCH v3 00/16] Add support for Kontron sl28cpld Michael Walle
2020-04-23 17:45 ` Michael Walle
2020-04-23 17:45 ` [PATCH v3 01/16] include/linux/ioport.h: add helper to define REG resource constructs Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-23 17:45 ` [PATCH v3 02/16] mfd: mfd-core: Don't overwrite the dma_mask of the child device Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-28 12:45   ` Andy Shevchenko
2020-04-28 12:45     ` Andy Shevchenko
2020-04-28 12:45     ` Andy Shevchenko
2020-04-28 13:06     ` Robin Murphy
2020-04-28 13:06       ` Robin Murphy
2020-04-28 13:06       ` Robin Murphy
2020-04-28 14:29       ` Andy Shevchenko
2020-04-28 14:29         ` Andy Shevchenko
2020-04-28 14:29         ` Andy Shevchenko
2020-04-28 14:49         ` Robin Murphy
2020-04-28 14:49           ` Robin Murphy
2020-04-28 14:49           ` Robin Murphy
2020-04-28 15:25           ` Mark Brown
2020-04-28 15:25             ` Mark Brown
2020-04-28 15:25             ` Mark Brown
2020-05-14 20:45             ` Michael Walle [this message]
2020-05-14 20:45               ` Michael Walle
2020-05-14 20:45               ` Michael Walle
2020-04-23 17:45 ` [PATCH v3 03/16] mfd: mfd-core: match device tree node against reg property Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-29 22:18   ` Michael Walle
2020-04-29 22:18     ` Michael Walle
2020-04-29 22:18     ` Michael Walle
2020-05-15 10:28     ` Lee Jones
2020-05-15 10:28       ` Lee Jones
2020-05-15 10:28       ` Lee Jones
2020-05-25 17:36       ` Michael Walle
2020-05-25 17:36         ` Michael Walle
2020-05-25 17:36         ` Michael Walle
2020-05-26  7:24         ` Lee Jones
2020-05-26  7:24           ` Lee Jones
2020-05-26  7:24           ` Lee Jones
2020-05-26 15:54           ` Michael Walle
2020-05-26 15:54             ` Michael Walle
2020-05-26 15:54             ` Michael Walle
2020-05-26 16:03             ` Andy Shevchenko
2020-05-26 16:03               ` Andy Shevchenko
2020-05-26 16:03               ` Andy Shevchenko
2020-05-27  6:53               ` Lee Jones
2020-05-27  6:53                 ` Lee Jones
2020-05-27  6:53                 ` Lee Jones
2020-06-08 14:24         ` Lee Jones
2020-06-08 14:24           ` Lee Jones
2020-06-08 14:24           ` Lee Jones
2020-06-08 15:21           ` Michael Walle
2020-06-08 15:21             ` Michael Walle
2020-06-08 15:21             ` Michael Walle
2020-06-08 18:45             ` Lee Jones
2020-06-08 18:45               ` Lee Jones
2020-06-08 18:45               ` Lee Jones
2020-04-23 17:45 ` [PATCH v3 04/16] dt-bindings: mfd: Add bindings for sl28cpld Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-28 12:48   ` Andy Shevchenko
2020-04-28 12:48     ` Andy Shevchenko
2020-04-28 12:48     ` Andy Shevchenko
2020-04-28 14:39     ` Michael Walle
2020-04-28 14:39       ` Michael Walle
2020-04-28 14:39       ` Michael Walle
2020-04-28 14:49       ` Andy Shevchenko
2020-04-28 14:49         ` Andy Shevchenko
2020-04-28 14:49         ` Andy Shevchenko
2020-04-23 17:45 ` [PATCH v3 05/16] mfd: Add support for Kontron sl28cpld management controller Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-28 12:50   ` Andy Shevchenko
2020-04-28 12:50     ` Andy Shevchenko
2020-04-28 12:50     ` Andy Shevchenko
2020-04-28 14:43     ` Michael Walle
2020-04-28 14:43       ` Michael Walle
2020-04-28 14:43       ` Michael Walle
2020-04-28 14:49       ` Andy Shevchenko
2020-04-28 14:49         ` Andy Shevchenko
2020-04-28 14:49         ` Andy Shevchenko
2020-04-29  6:27         ` Lee Jones
2020-04-29  6:27           ` Lee Jones
2020-04-29  6:27           ` Lee Jones
2020-05-11 21:13   ` Rob Herring
2020-05-11 21:13     ` Rob Herring
2020-05-11 21:13     ` Rob Herring
2020-05-11 21:44     ` Michael Walle
2020-05-11 21:44       ` Michael Walle
2020-05-11 21:44       ` Michael Walle
2020-05-11 22:29       ` Michael Walle
2020-05-11 22:29         ` Michael Walle
2020-05-11 22:29         ` Michael Walle
2020-05-12 21:59       ` Rob Herring
2020-05-12 21:59         ` Rob Herring
2020-05-12 21:59         ` Rob Herring
2020-05-13 22:15         ` Michael Walle
2020-05-13 22:15           ` Michael Walle
2020-05-13 22:15           ` Michael Walle
2020-04-23 17:45 ` [PATCH v3 06/16] irqchip: add sl28cpld interrupt controller support Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-27 11:40   ` Thomas Gleixner
2020-04-27 11:40     ` Thomas Gleixner
2020-04-27 11:40     ` Thomas Gleixner
2020-04-27 17:40     ` Michael Walle
2020-04-27 17:40       ` Michael Walle
2020-04-27 17:40       ` Michael Walle
2020-04-27 17:44       ` Mark Brown
2020-04-27 17:44         ` Mark Brown
2020-04-27 17:44         ` Mark Brown
2020-04-27 18:01         ` Michael Walle
2020-04-27 18:01           ` Michael Walle
2020-04-27 18:01           ` Michael Walle
2020-04-27 18:05           ` Mark Brown
2020-04-27 18:05             ` Mark Brown
2020-04-27 18:05             ` Mark Brown
2020-04-27 19:00       ` Thomas Gleixner
2020-04-27 19:00         ` Thomas Gleixner
2020-04-27 19:00         ` Thomas Gleixner
2020-04-23 17:45 ` [PATCH v3 07/16] watchdog: add support for sl28cpld watchdog Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-25 17:02   ` Guenter Roeck
2020-04-25 17:02     ` Guenter Roeck
2020-04-23 17:45 ` [PATCH v3 08/16] pwm: add support for sl28cpld PWM controller Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-05-11 20:45   ` Rob Herring
2020-05-11 20:45     ` Rob Herring
2020-05-11 20:45     ` Rob Herring
2020-04-23 17:45 ` [PATCH v3 09/16] gpiolib: Introduce gpiochip_irqchip_add_domain() Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-27 11:42   ` Thomas Gleixner
2020-04-27 11:42     ` Thomas Gleixner
2020-04-27 11:42     ` Thomas Gleixner
2020-04-27 17:49     ` Michael Walle
2020-04-27 17:49       ` Michael Walle
2020-04-27 17:49       ` Michael Walle
2020-04-23 17:45 ` [PATCH v3 10/16] gpio: add a reusable generic gpio_chip using regmap Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-05-12 12:48   ` Bartosz Golaszewski
2020-05-12 12:48     ` Bartosz Golaszewski
2020-05-12 12:48     ` Bartosz Golaszewski
2020-05-12 14:41     ` Michael Walle
2020-05-12 14:41       ` Michael Walle
2020-05-12 14:41       ` Michael Walle
2020-05-25  9:05       ` Bartosz Golaszewski
2020-05-25  9:05         ` Bartosz Golaszewski
2020-05-25  9:05         ` Bartosz Golaszewski
2020-05-25 10:20         ` Michael Walle
2020-05-25 10:20           ` Michael Walle
2020-05-25 10:20           ` Michael Walle
2020-05-25 12:59           ` Linus Walleij
2020-05-25 12:59             ` Linus Walleij
2020-05-25 12:59             ` Linus Walleij
2020-05-25 13:25             ` Andy Shevchenko
2020-05-25 13:25               ` Andy Shevchenko
2020-05-25 13:25               ` Andy Shevchenko
2020-04-23 17:45 ` [PATCH v3 11/16] gpio: add support for the sl28cpld GPIO controller Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-27 11:45   ` Thomas Gleixner
2020-04-27 11:45     ` Thomas Gleixner
2020-04-27 11:45     ` Thomas Gleixner
2020-04-27 17:58     ` Michael Walle
2020-04-27 17:58       ` Michael Walle
2020-04-27 17:58       ` Michael Walle
2020-04-23 17:45 ` [PATCH v3 12/16] hwmon: add support for the sl28cpld hardware monitoring controller Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-23 17:45 ` [PATCH v3 13/16] arm64: dts: freescale: sl28: enable sl28cpld Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-23 17:45 ` [PATCH v3 14/16] arm64: dts: freescale: sl28: map GPIOs to input events Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-23 17:45 ` [PATCH v3 15/16] arm64: dts: freescale: sl28: enable LED support Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-23 17:45 ` [PATCH v3 16/16] arm64: dts: freescale: sl28: enable fan support Michael Walle
2020-04-23 17:45   ` Michael Walle
2020-04-23 17:45   ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fb998f882938680d98f1c2f6f8254c1@walle.cc \
    --to=michael@walle.cc \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jason@lakedaemon.net \
    --cc=jdelvare@suse.com \
    --cc=lee.jones@linaro.org \
    --cc=leoyang.li@nxp.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=maz@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=shawnguo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.