From: Colin Ian King <colin.king@canonical.com> To: Joe Perches <joe@perches.com>, Andrzej Hajda <a.hajda@samsung.com>, Neil Armstrong <narmstrong@baylibre.com>, Robert Foss <robert.foss@linaro.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/bridge/tc358767: make the array ext_div static const, makes object smaller Date: Thu, 19 Aug 2021 14:54:40 +0100 [thread overview] Message-ID: <913b96bc-f5c4-1a26-c5f7-70a9d0ab3f53@canonical.com> (raw) In-Reply-To: <0a2ea4e54d7bfd61b45cc070eee6b62e8da82190.camel@perches.com> On 19/08/2021 14:51, Joe Perches wrote: > On Thu, 2021-08-19 at 14:38 +0100, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Don't populate the array ext_div on the stack but instead it >> static const. Makes the object code smaller by 118 bytes: >> >> Before: >> text data bss dec hex filename >> 39449 17500 128 57077 def5 ./drivers/gpu/drm/bridge/tc358767.o >> >> After: >> text data bss dec hex filename >> 39235 17596 128 56959 de7f ./drivers/gpu/drm/bridge/tc358767.o > > Why is text smaller and data larger with this change? There are less instructions being used with the change since it's not shoving the array data onto the stack at run time. Instead the array is being stored in the data section and there is less object code required to access the data. Colin > >> >> (gcc version 10.3.0) >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> drivers/gpu/drm/bridge/tc358767.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c >> index 23a6f90b694b..599c23759400 100644 >> --- a/drivers/gpu/drm/bridge/tc358767.c >> +++ b/drivers/gpu/drm/bridge/tc358767.c >> @@ -468,7 +468,7 @@ static int tc_pxl_pll_en(struct tc_data *tc, u32 refclk, u32 pixelclock) >> int div, best_div = 1; >> int mul, best_mul = 1; >> int delta, best_delta; >> - int ext_div[] = {1, 2, 3, 5, 7}; >> + static const int ext_div[] = {1, 2, 3, 5, 7}; >> int best_pixelclock = 0; >> int vco_hi = 0; >> u32 pxl_pllparam; > >
WARNING: multiple messages have this Message-ID (diff)
From: Colin Ian King <colin.king@canonical.com> To: Joe Perches <joe@perches.com>, Andrzej Hajda <a.hajda@samsung.com>, Neil Armstrong <narmstrong@baylibre.com>, Robert Foss <robert.foss@linaro.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/bridge/tc358767: make the array ext_div static const, makes object smaller Date: Thu, 19 Aug 2021 14:54:40 +0100 [thread overview] Message-ID: <913b96bc-f5c4-1a26-c5f7-70a9d0ab3f53@canonical.com> (raw) In-Reply-To: <0a2ea4e54d7bfd61b45cc070eee6b62e8da82190.camel@perches.com> On 19/08/2021 14:51, Joe Perches wrote: > On Thu, 2021-08-19 at 14:38 +0100, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Don't populate the array ext_div on the stack but instead it >> static const. Makes the object code smaller by 118 bytes: >> >> Before: >> text data bss dec hex filename >> 39449 17500 128 57077 def5 ./drivers/gpu/drm/bridge/tc358767.o >> >> After: >> text data bss dec hex filename >> 39235 17596 128 56959 de7f ./drivers/gpu/drm/bridge/tc358767.o > > Why is text smaller and data larger with this change? There are less instructions being used with the change since it's not shoving the array data onto the stack at run time. Instead the array is being stored in the data section and there is less object code required to access the data. Colin > >> >> (gcc version 10.3.0) >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> drivers/gpu/drm/bridge/tc358767.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c >> index 23a6f90b694b..599c23759400 100644 >> --- a/drivers/gpu/drm/bridge/tc358767.c >> +++ b/drivers/gpu/drm/bridge/tc358767.c >> @@ -468,7 +468,7 @@ static int tc_pxl_pll_en(struct tc_data *tc, u32 refclk, u32 pixelclock) >> int div, best_div = 1; >> int mul, best_mul = 1; >> int delta, best_delta; >> - int ext_div[] = {1, 2, 3, 5, 7}; >> + static const int ext_div[] = {1, 2, 3, 5, 7}; >> int best_pixelclock = 0; >> int vco_hi = 0; >> u32 pxl_pllparam; > >
next prev parent reply other threads:[~2021-08-19 13:54 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-19 13:38 [PATCH] drm/bridge/tc358767: make the array ext_div static const, makes object smaller Colin King 2021-08-19 13:51 ` Joe Perches 2021-08-19 13:51 ` Joe Perches 2021-08-19 13:54 ` Colin Ian King [this message] 2021-08-19 13:54 ` Colin Ian King 2021-08-19 14:40 ` Joe Perches 2021-08-19 14:40 ` Joe Perches 2021-08-19 14:51 ` Colin Ian King 2021-08-19 14:51 ` Colin Ian King 2021-08-19 15:10 ` Joe Perches 2021-08-19 15:10 ` Joe Perches 2021-08-19 17:18 ` Sam Ravnborg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=913b96bc-f5c4-1a26-c5f7-70a9d0ab3f53@canonical.com \ --to=colin.king@canonical.com \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=jernej.skrabec@gmail.com \ --cc=joe@perches.com \ --cc=jonas@kwiboo.se \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=narmstrong@baylibre.com \ --cc=robert.foss@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.