[PATCH] EFI: don't repeatedly replace symlinks

[PATCH] EFI: don't repeatedly replace symlinks

[Jan Beulich]

Once created there's no point re-creating them on every incremental
make. This in particular prevents them from becoming root-owned during
e.g. "sudo make install-xen", but it also allows (during development)
to replace them there (instead of in common/efi/) by actual files with
perhaps slightly changed contents.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Note that the root-owned issue also exists for the various .*.d2 files.

--- a/xen/Makefile
+++ b/xen/Makefile
@@ -137,7 +137,9 @@ $(TARGET): delete-unfresh-files
 	$(MAKE) -f $(BASEDIR)/Rules.mk include/xen/compile.h
 	[ -e include/asm ] || ln -sf asm-$(TARGET_ARCH) include/asm
 	[ -e arch/$(TARGET_ARCH)/efi ] && for f in boot.c runtime.c compat.c efi.h;\
-		do ln -nsf ../../../common/efi/$$f arch/$(TARGET_ARCH)/efi/; done;\
+		do test -r arch/$(TARGET_ARCH)/efi/$$f || \
+		   ln -nsf ../../../common/efi/$$f arch/$(TARGET_ARCH)/efi/; \
+		done; \
 		true
 	$(MAKE) -f $(BASEDIR)/Rules.mk -C include
 	$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) asm-offsets.s



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] EFI: don't repeatedly replace symlinks

[Andrew Cooper]

On 23/11/2018 11:37, Jan Beulich wrote:
> Once created there's no point re-creating them on every incremental
> make. This in particular prevents them from becoming root-owned during
> e.g. "sudo make install-xen", but it also allows (during development)
> to replace them there (instead of in common/efi/) by actual files with
> perhaps slightly changed contents.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel