From: Andrej Picej <andrej.picej@norik.com> To: Christoph Niedermaier <cniedermaier@dh-electronics.com>, "support.opensource@diasemi.com" <support.opensource@diasemi.com>, "linux@roeck-us.net" <linux@roeck-us.net>, "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org> Cc: "wim@linux-watchdog.org" <wim@linux-watchdog.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "linux-imx@nxp.com" <linux-imx@nxp.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v4 1/4] mfd: da9062: make register CONFIG_I writable Date: Fri, 3 Dec 2021 09:59:02 +0100 [thread overview] Message-ID: <9524a32b-d7f5-487c-e791-12bf0554a90f@norik.com> (raw) In-Reply-To: <9e35530f629044e595decb101a097fde@dh-electronics.com> On 2. 12. 21 16:18, Christoph Niedermaier wrote: > From: Andrej Picej > Sent: Thursday, December 2, 2021 10:32 AM >> From: Stefan Christ <s.christ@phytec.de> >> >> Make the config register CONFIG_I writable to change the watchdog mode. >> >> Signed-off-by: Stefan Christ <s.christ@phytec.de> >> Signed-off-by: Andrej Picej <andrej.picej@norik.com> >> --- >> Chnages in v4: >> - no changes >> >> Changes in v3: >> - no chagnes >> >> Changes in v2: >> - no changes >> --- >> drivers/mfd/da9062-core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c >> index 01f8e10dfa55..7041ba53efb4 100644 >> --- a/drivers/mfd/da9062-core.c >> +++ b/drivers/mfd/da9062-core.c >> @@ -556,6 +556,7 @@ static const struct regmap_range >> da9062_aa_writeable_ranges[] = { >> regmap_reg_range(DA9062AA_VBUCK3_B, DA9062AA_VBUCK3_B), >> regmap_reg_range(DA9062AA_VLDO1_B, DA9062AA_VLDO4_B), >> regmap_reg_range(DA9062AA_BBAT_CONT, DA9062AA_BBAT_CONT), >> + regmap_reg_range(DA9062AA_CONFIG_I, DA9062AA_CONFIG_I), >> regmap_reg_range(DA9062AA_GP_ID_0, DA9062AA_GP_ID_19), >> }; > Could you also include the CONFIG_I for the DA9061? > So I can test it on my system. > Yes, I don't see the problem here. @Maintainers, should I send a new version with this (then I would also fix the minor spelling mistake in commit message of 2/4), or do you prefer a separate patch? Thanks, Andrej.
WARNING: multiple messages have this Message-ID (diff)
From: Andrej Picej <andrej.picej@norik.com> To: Christoph Niedermaier <cniedermaier@dh-electronics.com>, "support.opensource@diasemi.com" <support.opensource@diasemi.com>, "linux@roeck-us.net" <linux@roeck-us.net>, "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org> Cc: "wim@linux-watchdog.org" <wim@linux-watchdog.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "linux-imx@nxp.com" <linux-imx@nxp.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v4 1/4] mfd: da9062: make register CONFIG_I writable Date: Fri, 3 Dec 2021 09:59:02 +0100 [thread overview] Message-ID: <9524a32b-d7f5-487c-e791-12bf0554a90f@norik.com> (raw) In-Reply-To: <9e35530f629044e595decb101a097fde@dh-electronics.com> On 2. 12. 21 16:18, Christoph Niedermaier wrote: > From: Andrej Picej > Sent: Thursday, December 2, 2021 10:32 AM >> From: Stefan Christ <s.christ@phytec.de> >> >> Make the config register CONFIG_I writable to change the watchdog mode. >> >> Signed-off-by: Stefan Christ <s.christ@phytec.de> >> Signed-off-by: Andrej Picej <andrej.picej@norik.com> >> --- >> Chnages in v4: >> - no changes >> >> Changes in v3: >> - no chagnes >> >> Changes in v2: >> - no changes >> --- >> drivers/mfd/da9062-core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c >> index 01f8e10dfa55..7041ba53efb4 100644 >> --- a/drivers/mfd/da9062-core.c >> +++ b/drivers/mfd/da9062-core.c >> @@ -556,6 +556,7 @@ static const struct regmap_range >> da9062_aa_writeable_ranges[] = { >> regmap_reg_range(DA9062AA_VBUCK3_B, DA9062AA_VBUCK3_B), >> regmap_reg_range(DA9062AA_VLDO1_B, DA9062AA_VLDO4_B), >> regmap_reg_range(DA9062AA_BBAT_CONT, DA9062AA_BBAT_CONT), >> + regmap_reg_range(DA9062AA_CONFIG_I, DA9062AA_CONFIG_I), >> regmap_reg_range(DA9062AA_GP_ID_0, DA9062AA_GP_ID_19), >> }; > Could you also include the CONFIG_I for the DA9061? > So I can test it on my system. > Yes, I don't see the problem here. @Maintainers, should I send a new version with this (then I would also fix the minor spelling mistake in commit message of 2/4), or do you prefer a separate patch? Thanks, Andrej. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-03 8:59 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-02 9:32 [PATCH v4 1/4] mfd: da9062: make register CONFIG_I writable Andrej Picej 2021-12-02 9:32 ` Andrej Picej 2021-12-02 9:32 ` [PATCH v4 2/4] watchdog: da9062: reset board on watchdog timeout Andrej Picej 2021-12-02 9:32 ` Andrej Picej 2021-12-02 12:18 ` Adam Thomson 2021-12-02 12:18 ` Adam Thomson 2021-12-02 12:25 ` Andrej Picej 2021-12-02 12:25 ` Andrej Picej 2021-12-02 14:41 ` Guenter Roeck 2021-12-02 14:41 ` Guenter Roeck 2021-12-02 9:32 ` [PATCH v4 3/4] dt-bindings: watchdog: da9062: add watchdog timeout mode Andrej Picej 2021-12-02 9:32 ` Andrej Picej 2021-12-02 12:19 ` Adam Thomson 2021-12-02 12:19 ` Adam Thomson 2021-12-02 9:32 ` [PATCH v4 4/4] ARM: dts: imx6: phycore-som: set watchdog timeout mode to shutdown Andrej Picej 2021-12-02 9:32 ` Andrej Picej 2021-12-02 12:14 ` [PATCH v4 1/4] mfd: da9062: make register CONFIG_I writable Adam Thomson 2021-12-02 12:14 ` Adam Thomson 2021-12-02 14:40 ` Guenter Roeck 2021-12-02 14:40 ` Guenter Roeck 2021-12-02 15:18 ` Christoph Niedermaier 2021-12-03 8:59 ` Andrej Picej [this message] 2021-12-03 8:59 ` Andrej Picej 2021-12-03 15:04 ` Guenter Roeck 2021-12-03 15:04 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9524a32b-d7f5-487c-e791-12bf0554a90f@norik.com \ --to=andrej.picej@norik.com \ --cc=cniedermaier@dh-electronics.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=support.opensource@diasemi.com \ --cc=wim@linux-watchdog.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.