All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM64: use linux/types.h in kvm.h
@ 2015-11-12 14:41 ` Arnd Bergmann
  0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2015-11-12 14:41 UTC (permalink / raw)
  To: Christoffer Dall
  Cc: Marc Zyngier, Catalin Marinas, Will Deacon, linux-arm-kernel,
	kvmarm, linux-kernel

We should always use linux/types.h instead of asm/types.h for
consistency, and Kbuild actually warns about it:

./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>

This patch does as Kbuild asks us.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Found on ARM64 allmodconfig

diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h
index 0cd7b5947dfc..2d4ca4bb0dd3 100644
--- a/arch/arm64/include/uapi/asm/kvm.h
+++ b/arch/arm64/include/uapi/asm/kvm.h
@@ -32,7 +32,7 @@
 
 #ifndef __ASSEMBLY__
 #include <linux/psci.h>
-#include <asm/types.h>
+#include <linux/types.h>
 #include <asm/ptrace.h>
 
 #define __KVM_HAVE_GUEST_DEBUG


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] ARM64: use linux/types.h in kvm.h
@ 2015-11-12 14:41 ` Arnd Bergmann
  0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2015-11-12 14:41 UTC (permalink / raw)
  To: Christoffer Dall
  Cc: Marc Zyngier, Catalin Marinas, Will Deacon, linux-kernel, kvmarm,
	linux-arm-kernel

We should always use linux/types.h instead of asm/types.h for
consistency, and Kbuild actually warns about it:

./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>

This patch does as Kbuild asks us.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Found on ARM64 allmodconfig

diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h
index 0cd7b5947dfc..2d4ca4bb0dd3 100644
--- a/arch/arm64/include/uapi/asm/kvm.h
+++ b/arch/arm64/include/uapi/asm/kvm.h
@@ -32,7 +32,7 @@
 
 #ifndef __ASSEMBLY__
 #include <linux/psci.h>
-#include <asm/types.h>
+#include <linux/types.h>
 #include <asm/ptrace.h>
 
 #define __KVM_HAVE_GUEST_DEBUG

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] ARM64: use linux/types.h in kvm.h
@ 2015-11-12 14:41 ` Arnd Bergmann
  0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2015-11-12 14:41 UTC (permalink / raw)
  To: linux-arm-kernel

We should always use linux/types.h instead of asm/types.h for
consistency, and Kbuild actually warns about it:

./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>

This patch does as Kbuild asks us.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Found on ARM64 allmodconfig

diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h
index 0cd7b5947dfc..2d4ca4bb0dd3 100644
--- a/arch/arm64/include/uapi/asm/kvm.h
+++ b/arch/arm64/include/uapi/asm/kvm.h
@@ -32,7 +32,7 @@
 
 #ifndef __ASSEMBLY__
 #include <linux/psci.h>
-#include <asm/types.h>
+#include <linux/types.h>
 #include <asm/ptrace.h>
 
 #define __KVM_HAVE_GUEST_DEBUG

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] ARM64: use linux/types.h in kvm.h
  2015-11-12 14:41 ` Arnd Bergmann
  (?)
@ 2015-11-13 11:38   ` Christoffer Dall
  -1 siblings, 0 replies; 9+ messages in thread
From: Christoffer Dall @ 2015-11-13 11:38 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Marc Zyngier, Catalin Marinas, Will Deacon, linux-arm-kernel,
	kvmarm, linux-kernel

On Thu, Nov 12, 2015 at 03:41:08PM +0100, Arnd Bergmann wrote:
> We should always use linux/types.h instead of asm/types.h for
> consistency, and Kbuild actually warns about it:
> 
> ./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>
> 
> This patch does as Kbuild asks us.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I don't see this error when building the kernel, does it require a
special option to check for these things?


In any case, thanks for the patch, I have applied it.

-Christoffer

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] ARM64: use linux/types.h in kvm.h
@ 2015-11-13 11:38   ` Christoffer Dall
  0 siblings, 0 replies; 9+ messages in thread
From: Christoffer Dall @ 2015-11-13 11:38 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Marc Zyngier, Catalin Marinas, Will Deacon, linux-kernel, kvmarm,
	linux-arm-kernel

On Thu, Nov 12, 2015 at 03:41:08PM +0100, Arnd Bergmann wrote:
> We should always use linux/types.h instead of asm/types.h for
> consistency, and Kbuild actually warns about it:
> 
> ./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>
> 
> This patch does as Kbuild asks us.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I don't see this error when building the kernel, does it require a
special option to check for these things?


In any case, thanks for the patch, I have applied it.

-Christoffer

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] ARM64: use linux/types.h in kvm.h
@ 2015-11-13 11:38   ` Christoffer Dall
  0 siblings, 0 replies; 9+ messages in thread
From: Christoffer Dall @ 2015-11-13 11:38 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Nov 12, 2015 at 03:41:08PM +0100, Arnd Bergmann wrote:
> We should always use linux/types.h instead of asm/types.h for
> consistency, and Kbuild actually warns about it:
> 
> ./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>
> 
> This patch does as Kbuild asks us.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I don't see this error when building the kernel, does it require a
special option to check for these things?


In any case, thanks for the patch, I have applied it.

-Christoffer

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] ARM64: use linux/types.h in kvm.h
  2015-11-13 11:38   ` Christoffer Dall
  (?)
@ 2015-11-13 11:46     ` Arnd Bergmann
  -1 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2015-11-13 11:46 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Christoffer Dall, Marc Zyngier, Catalin Marinas, Will Deacon,
	linux-kernel, kvmarm

On Friday 13 November 2015 12:38:43 Christoffer Dall wrote:
> On Thu, Nov 12, 2015 at 03:41:08PM +0100, Arnd Bergmann wrote:
> > We should always use linux/types.h instead of asm/types.h for
> > consistency, and Kbuild actually warns about it:
> > 
> > ./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>
> > 
> > This patch does as Kbuild asks us.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> I don't see this error when building the kernel, does it require a
> special option to check for these things?

CONFIG_HEADERS_CHECK should be included in 'allmodconfig', which is the
configuration I used. I think at the moment, allmodconfig  builds fail,
so you don't get to this point unless you also apply my other fixes. 
 
> In any case, thanks for the patch, I have applied it.

Thanks!

	Arnd

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] ARM64: use linux/types.h in kvm.h
@ 2015-11-13 11:46     ` Arnd Bergmann
  0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2015-11-13 11:46 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Marc Zyngier, Catalin Marinas, Will Deacon, linux-kernel, kvmarm

On Friday 13 November 2015 12:38:43 Christoffer Dall wrote:
> On Thu, Nov 12, 2015 at 03:41:08PM +0100, Arnd Bergmann wrote:
> > We should always use linux/types.h instead of asm/types.h for
> > consistency, and Kbuild actually warns about it:
> > 
> > ./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>
> > 
> > This patch does as Kbuild asks us.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> I don't see this error when building the kernel, does it require a
> special option to check for these things?

CONFIG_HEADERS_CHECK should be included in 'allmodconfig', which is the
configuration I used. I think at the moment, allmodconfig  builds fail,
so you don't get to this point unless you also apply my other fixes. 
 
> In any case, thanks for the patch, I have applied it.

Thanks!

	Arnd

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] ARM64: use linux/types.h in kvm.h
@ 2015-11-13 11:46     ` Arnd Bergmann
  0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2015-11-13 11:46 UTC (permalink / raw)
  To: linux-arm-kernel

On Friday 13 November 2015 12:38:43 Christoffer Dall wrote:
> On Thu, Nov 12, 2015 at 03:41:08PM +0100, Arnd Bergmann wrote:
> > We should always use linux/types.h instead of asm/types.h for
> > consistency, and Kbuild actually warns about it:
> > 
> > ./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>
> > 
> > This patch does as Kbuild asks us.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> I don't see this error when building the kernel, does it require a
> special option to check for these things?

CONFIG_HEADERS_CHECK should be included in 'allmodconfig', which is the
configuration I used. I think at the moment, allmodconfig  builds fail,
so you don't get to this point unless you also apply my other fixes. 
 
> In any case, thanks for the patch, I have applied it.

Thanks!

	Arnd

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-11-13 11:46 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-12 14:41 [PATCH] ARM64: use linux/types.h in kvm.h Arnd Bergmann
2015-11-12 14:41 ` Arnd Bergmann
2015-11-12 14:41 ` Arnd Bergmann
2015-11-13 11:38 ` Christoffer Dall
2015-11-13 11:38   ` Christoffer Dall
2015-11-13 11:38   ` Christoffer Dall
2015-11-13 11:46   ` Arnd Bergmann
2015-11-13 11:46     ` Arnd Bergmann
2015-11-13 11:46     ` Arnd Bergmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.