From: Eric Dumazet <eric.dumazet@gmail.com>
To: Leon Romanovsky <leon@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Leon Romanovsky <leonro@nvidia.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>, Ariel Elior <aelior@marvell.com>,
Bin Luo <luobin9@huawei.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Coiby Xu <coiby.xu@gmail.com>,
Derek Chickles <dchickles@marvell.com>,
drivers@pensando.io, Felix Manlunas <fmanlunas@marvell.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Geetha sowjanya <gakula@marvell.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
GR-everest-linux-l2@marvell.com, GR-Linux-NIC-Dev@marvell.com,
hariprasad <hkelam@marvell.com>, Ido Schimmel <idosch@nvidia.com>,
Intel Corporation <linuxwwan@intel.com>,
intel-wired-lan@lists.osuosl.org,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Jerin Jacob <jerinj@marvell.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Jiri Pirko <jiri@nvidia.com>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Linu Cherian <lcherian@marvell.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-staging@lists.linux.dev,
Loic Poulain <loic.poulain@linaro.org>,
Manish Chopra <manishc@marvell.com>,
M Chetan Kumar <m.chetan.kumar@intel.com>,
Michael Chan <michael.chan@broadcom.com>,
Michael Guralnik <michaelgur@mellanox.com>,
netdev@vger.kernel.org, oss-drivers@corigine.com,
Richard Cochran <richardcochran@gmail.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Satanand Burla <sburla@marvell.com>,
Sergey Ryazanov <ryazanov.s.a@gmail.com>,
Shannon Nelson <snelson@pensando.io>,
Simon Horman <simon.horman@corigine.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
Sunil Goutham <sgoutham@marvell.com>,
Taras Chornyi <tchornyi@marvell.com>,
Tariq Toukan <tariqt@nvidia.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
UNGLinuxDriver@microchip.com, Vadym Kochan <vkochan@marvell.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH net-next v1 01/21] devlink: Notify users when objects are accessible
Date: Mon, 27 Sep 2021 19:49:18 -0700 [thread overview]
Message-ID: <97c1ba9d-52b9-5689-19ab-ad4a82e55ae2@gmail.com> (raw)
In-Reply-To: <0f7f201a059b24c96eac837e1f424e2483254e1c.1632565508.git.leonro@nvidia.com>
On 9/25/21 4:22 AM, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> The devlink core code notified users about add/remove objects without
> relation if this object can be accessible or not. In this patch we unify
> such user visible notifications in one place.
>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> net/core/devlink.c | 107 +++++++++++++++++++++++++++++++++++++++------
> 1 file changed, 93 insertions(+), 14 deletions(-)
>
> diff --git a/net/core/devlink.c b/net/core/devlink.c
> index 3ea33c689790..06edb2f1d21e 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -742,6 +742,7 @@ static void devlink_notify(struct devlink *devlink, enum devlink_command cmd)
> int err;
>
> WARN_ON(cmd != DEVLINK_CMD_NEW && cmd != DEVLINK_CMD_DEL);
> + WARN_ON(!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED));
>
> msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
> if (!msg)
> @@ -1040,11 +1041,15 @@ static int devlink_nl_port_fill(struct sk_buff *msg,
> static void devlink_port_notify(struct devlink_port *devlink_port,
> enum devlink_command cmd)
> {
> + struct devlink *devlink = devlink_port->devlink;
> struct sk_buff *msg;
> int err;
>
> WARN_ON(cmd != DEVLINK_CMD_PORT_NEW && cmd != DEVLINK_CMD_PORT_DEL);
>
> + if (!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED))
> + return;
> +
> msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
> if (!msg)
> return;
> @@ -1055,18 +1060,19 @@ static void devlink_port_notify(struct devlink_port *devlink_port,
> return;
> }
>
> - genlmsg_multicast_netns(&devlink_nl_family,
> - devlink_net(devlink_port->devlink), msg, 0,
> - DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
> + genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), msg,
> + 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
> }
>
> static void devlink_rate_notify(struct devlink_rate *devlink_rate,
> enum devlink_command cmd)
> {
> + struct devlink *devlink = devlink_rate->devlink;
> struct sk_buff *msg;
> int err;
>
> WARN_ON(cmd != DEVLINK_CMD_RATE_NEW && cmd != DEVLINK_CMD_RATE_DEL);
> + WARN_ON(!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED));
FYI, this new warning was triggered by syzbot :
WARNING: CPU: 1 PID: 6540 at net/core/devlink.c:5158 devlink_nl_region_notify+0x184/0x1e0 net/core/devlink.c:5158
Modules linked in:
CPU: 1 PID: 6540 Comm: syz-executor.0 Not tainted 5.15.0-rc2-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:devlink_nl_region_notify+0x184/0x1e0 net/core/devlink.c:5158
Code: 38 41 b8 c0 0c 00 00 31 d2 48 89 ee 4c 89 e7 e8 72 1a 26 00 48 83 c4 08 5b 5d 41 5c 41 5d 41 5e e9 01 bd 41 fa e8 fc bc 41 fa <0f> 0b e9 f7 fe ff ff e8 f0 bc 41 fa 0f 0b eb da 4c 89 e7 e8 c4 18
RSP: 0018:ffffc90002d6f658 EFLAGS: 00010293
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
RDX: ffff88801f08d580 RSI: ffffffff87344e94 RDI: 0000000000000003
RBP: ffff88801ee42100 R08: 0000000000000000 R09: 0000000000000000
R10: ffffffff87344d8a R11: 0000000000000000 R12: ffff88801c1dc000
R13: 0000000000000000 R14: 000000000000002c R15: ffff88801c1dc070
FS: 0000555555e8e400(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055dd7c590310 CR3: 0000000069a09000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
devlink_region_create+0x39f/0x4c0 net/core/devlink.c:10327
nsim_dev_dummy_region_init drivers/net/netdevsim/dev.c:481 [inline]
nsim_dev_probe+0x5f6/0x1150 drivers/net/netdevsim/dev.c:1479
call_driver_probe drivers/base/dd.c:517 [inline]
really_probe+0x245/0xcc0 drivers/base/dd.c:596
__driver_probe_device+0x338/0x4d0 drivers/base/dd.c:751
driver_probe_device+0x4c/0x1a0 drivers/base/dd.c:781
__device_attach_driver+0x20b/0x2f0 drivers/base/dd.c:898
bus_for_each_drv+0x15f/0x1e0 drivers/base/bus.c:427
__device_attach+0x228/0x4a0 drivers/base/dd.c:969
bus_probe_device+0x1e4/0x290 drivers/base/bus.c:487
device_add+0xc35/0x21b0 drivers/base/core.c:3359
nsim_bus_dev_new drivers/net/netdevsim/bus.c:435 [inline]
new_device_store+0x48b/0x770 drivers/net/netdevsim/bus.c:302
bus_attr_store+0x72/0xa0 drivers/base/bus.c:122
sysfs_kf_write+0x110/0x160 fs/sysfs/file.c:139
kernfs_fop_write_iter+0x342/0x500 fs/kernfs/file.c:296
call_write_iter include/linux/fs.h:2163 [inline]
new_sync_write+0x429/0x660 fs/read_write.c:507
vfs_write+0x7cf/0xae0 fs/read_write.c:594
ksys_write+0x12d/0x250 fs/read_write.c:647
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7f328409d3ef
Code: 89 54 24 18 48 89 74 24 10 89 7c 24 08 e8 99 fd ff ff 48 8b 54 24 18 48 8b 74 24 10 41 89 c0 8b 7c 24 08 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 31 44 89 c7 48 89 44 24 08 e8 cc fd ff ff 48
RSP: 002b:00007ffdc6851140 EFLAGS: 00000293 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007f328409d3ef
RDX: 0000000000000003 RSI: 00007ffdc6851190 RDI: 0000000000000004
RBP: 0000000000000004 R08: 0000000000000000 R09: 00007ffdc68510e0
R10: 0000000000000000 R11: 0000000000000293 R12: 00007f3284144971
R13: 00007ffdc6851190 R14: 0000000000000000 R15: 00007ffdc6851860
05:42PM
>
> msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
> if (!msg)
> @@ -1078,9 +1084,8 @@ static void devlink_rate_notify(struct devlink_rate *devlink_rate,
> return;
> }
>
> - genlmsg_multicast_netns(&devlink_nl_family,
> - devlink_net(devlink_rate->devlink), msg, 0,
> - DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
> + genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), msg,
> + 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
> }
>
> static int devlink_nl_cmd_rate_get_dumpit(struct sk_buff *msg,
> @@ -4150,6 +4155,7 @@ static void __devlink_flash_update_notify(struct devlink *devlink,
> WARN_ON(cmd != DEVLINK_CMD_FLASH_UPDATE &&
> cmd != DEVLINK_CMD_FLASH_UPDATE_END &&
> cmd != DEVLINK_CMD_FLASH_UPDATE_STATUS);
> + WARN_ON(!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED));
>
> msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
> if (!msg)
> @@ -5145,17 +5151,18 @@ static void devlink_nl_region_notify(struct devlink_region *region,
> struct devlink_snapshot *snapshot,
> enum devlink_command cmd)
> {
> + struct devlink *devlink = region->devlink;
> struct sk_buff *msg;
>
> WARN_ON(cmd != DEVLINK_CMD_REGION_NEW && cmd != DEVLINK_CMD_REGION_DEL);
> + WARN_ON(!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED));
>
> msg = devlink_nl_region_notify_build(region, snapshot, cmd, 0, 0);
> if (IS_ERR(msg))
> return;
>
> - genlmsg_multicast_netns(&devlink_nl_family,
> - devlink_net(region->devlink), msg, 0,
> - DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
> + genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), msg,
> + 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
> }
>
> /**
> @@ -6920,10 +6927,12 @@ devlink_nl_health_reporter_fill(struct sk_buff *msg,
> static void devlink_recover_notify(struct devlink_health_reporter *reporter,
> enum devlink_command cmd)
> {
> + struct devlink *devlink = reporter->devlink;
> struct sk_buff *msg;
> int err;
>
> WARN_ON(cmd != DEVLINK_CMD_HEALTH_REPORTER_RECOVER);
> + WARN_ON(!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED));
>
> msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
> if (!msg)
> @@ -6935,9 +6944,8 @@ static void devlink_recover_notify(struct devlink_health_reporter *reporter,
> return;
> }
>
> - genlmsg_multicast_netns(&devlink_nl_family,
> - devlink_net(reporter->devlink),
> - msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
> + genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), msg,
> + 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
> }
>
> void
> @@ -8955,6 +8963,68 @@ struct devlink *devlink_alloc_ns(const struct devlink_ops *ops,
> }
> EXPORT_SYMBOL_GPL(devlink_alloc_ns);
>
> +static void
> +devlink_trap_policer_notify(struct devlink *devlink,
> + const struct devlink_trap_policer_item *policer_item,
> + enum devlink_command cmd);
> +static void
> +devlink_trap_group_notify(struct devlink *devlink,
> + const struct devlink_trap_group_item *group_item,
> + enum devlink_command cmd);
> +static void devlink_trap_notify(struct devlink *devlink,
> + const struct devlink_trap_item *trap_item,
> + enum devlink_command cmd);
> +
> +static void devlink_notify_register(struct devlink *devlink)
> +{
> + struct devlink_trap_policer_item *policer_item;
> + struct devlink_trap_group_item *group_item;
> + struct devlink_trap_item *trap_item;
> + struct devlink_port *devlink_port;
> +
> + devlink_notify(devlink, DEVLINK_CMD_NEW);
> + list_for_each_entry(devlink_port, &devlink->port_list, list)
> + devlink_port_notify(devlink_port, DEVLINK_CMD_PORT_NEW);
> +
> + list_for_each_entry(policer_item, &devlink->trap_policer_list, list)
> + devlink_trap_policer_notify(devlink, policer_item,
> + DEVLINK_CMD_TRAP_POLICER_NEW);
> +
> + list_for_each_entry(group_item, &devlink->trap_group_list, list)
> + devlink_trap_group_notify(devlink, group_item,
> + DEVLINK_CMD_TRAP_GROUP_NEW);
> +
> + list_for_each_entry(trap_item, &devlink->trap_list, list)
> + devlink_trap_notify(devlink, trap_item, DEVLINK_CMD_TRAP_NEW);
> +
> + devlink_params_publish(devlink);
> +}
> +
> +static void devlink_notify_unregister(struct devlink *devlink)
> +{
> + struct devlink_trap_policer_item *policer_item;
> + struct devlink_trap_group_item *group_item;
> + struct devlink_trap_item *trap_item;
> + struct devlink_port *devlink_port;
> +
> + devlink_params_unpublish(devlink);
> +
> + list_for_each_entry_reverse(trap_item, &devlink->trap_list, list)
> + devlink_trap_notify(devlink, trap_item, DEVLINK_CMD_TRAP_DEL);
> +
> + list_for_each_entry_reverse(group_item, &devlink->trap_group_list, list)
> + devlink_trap_group_notify(devlink, group_item,
> + DEVLINK_CMD_TRAP_GROUP_DEL);
> + list_for_each_entry_reverse(policer_item, &devlink->trap_policer_list,
> + list)
> + devlink_trap_policer_notify(devlink, policer_item,
> + DEVLINK_CMD_TRAP_POLICER_DEL);
> +
> + list_for_each_entry_reverse(devlink_port, &devlink->port_list, list)
> + devlink_port_notify(devlink_port, DEVLINK_CMD_PORT_DEL);
> + devlink_notify(devlink, DEVLINK_CMD_DEL);
> +}
> +
> /**
> * devlink_register - Register devlink instance
> *
> @@ -8964,7 +9034,7 @@ void devlink_register(struct devlink *devlink)
> {
> mutex_lock(&devlink_mutex);
> xa_set_mark(&devlinks, devlink->index, DEVLINK_REGISTERED);
> - devlink_notify(devlink, DEVLINK_CMD_NEW);
> + devlink_notify_register(devlink);
> mutex_unlock(&devlink_mutex);
> }
> EXPORT_SYMBOL_GPL(devlink_register);
> @@ -8982,7 +9052,7 @@ void devlink_unregister(struct devlink *devlink)
> mutex_lock(&devlink_mutex);
> WARN_ON(devlink_reload_supported(devlink->ops) &&
> devlink->reload_enabled);
> - devlink_notify(devlink, DEVLINK_CMD_DEL);
> + devlink_notify_unregister(devlink);
> xa_clear_mark(&devlinks, devlink->index, DEVLINK_REGISTERED);
> mutex_unlock(&devlink_mutex);
> }
> @@ -10086,6 +10156,9 @@ void devlink_params_publish(struct devlink *devlink)
> {
> struct devlink_param_item *param_item;
>
> + if (!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED))
> + return;
> +
> list_for_each_entry(param_item, &devlink->param_list, list) {
> if (param_item->published)
> continue;
> @@ -10631,6 +10704,8 @@ devlink_trap_group_notify(struct devlink *devlink,
>
> WARN_ON_ONCE(cmd != DEVLINK_CMD_TRAP_GROUP_NEW &&
> cmd != DEVLINK_CMD_TRAP_GROUP_DEL);
> + if (!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED))
> + return;
>
> msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
> if (!msg)
> @@ -10672,6 +10747,8 @@ static void devlink_trap_notify(struct devlink *devlink,
>
> WARN_ON_ONCE(cmd != DEVLINK_CMD_TRAP_NEW &&
> cmd != DEVLINK_CMD_TRAP_DEL);
> + if (!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED))
> + return;
>
> msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
> if (!msg)
> @@ -11053,6 +11130,8 @@ devlink_trap_policer_notify(struct devlink *devlink,
>
> WARN_ON_ONCE(cmd != DEVLINK_CMD_TRAP_POLICER_NEW &&
> cmd != DEVLINK_CMD_TRAP_POLICER_DEL);
> + if (!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED))
> + return;
>
> msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
> if (!msg)
>
WARNING: multiple messages have this Message-ID (diff)
From: Eric Dumazet <eric.dumazet@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v1 01/21] devlink: Notify users when objects are accessible
Date: Mon, 27 Sep 2021 19:49:18 -0700 [thread overview]
Message-ID: <97c1ba9d-52b9-5689-19ab-ad4a82e55ae2@gmail.com> (raw)
In-Reply-To: <0f7f201a059b24c96eac837e1f424e2483254e1c.1632565508.git.leonro@nvidia.com>
On 9/25/21 4:22 AM, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> The devlink core code notified users about add/remove objects without
> relation if this object can be accessible or not. In this patch we unify
> such user visible notifications in one place.
>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> net/core/devlink.c | 107 +++++++++++++++++++++++++++++++++++++++------
> 1 file changed, 93 insertions(+), 14 deletions(-)
>
> diff --git a/net/core/devlink.c b/net/core/devlink.c
> index 3ea33c689790..06edb2f1d21e 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -742,6 +742,7 @@ static void devlink_notify(struct devlink *devlink, enum devlink_command cmd)
> int err;
>
> WARN_ON(cmd != DEVLINK_CMD_NEW && cmd != DEVLINK_CMD_DEL);
> + WARN_ON(!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED));
>
> msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
> if (!msg)
> @@ -1040,11 +1041,15 @@ static int devlink_nl_port_fill(struct sk_buff *msg,
> static void devlink_port_notify(struct devlink_port *devlink_port,
> enum devlink_command cmd)
> {
> + struct devlink *devlink = devlink_port->devlink;
> struct sk_buff *msg;
> int err;
>
> WARN_ON(cmd != DEVLINK_CMD_PORT_NEW && cmd != DEVLINK_CMD_PORT_DEL);
>
> + if (!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED))
> + return;
> +
> msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
> if (!msg)
> return;
> @@ -1055,18 +1060,19 @@ static void devlink_port_notify(struct devlink_port *devlink_port,
> return;
> }
>
> - genlmsg_multicast_netns(&devlink_nl_family,
> - devlink_net(devlink_port->devlink), msg, 0,
> - DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
> + genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), msg,
> + 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
> }
>
> static void devlink_rate_notify(struct devlink_rate *devlink_rate,
> enum devlink_command cmd)
> {
> + struct devlink *devlink = devlink_rate->devlink;
> struct sk_buff *msg;
> int err;
>
> WARN_ON(cmd != DEVLINK_CMD_RATE_NEW && cmd != DEVLINK_CMD_RATE_DEL);
> + WARN_ON(!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED));
FYI, this new warning was triggered by syzbot :
WARNING: CPU: 1 PID: 6540 at net/core/devlink.c:5158 devlink_nl_region_notify+0x184/0x1e0 net/core/devlink.c:5158
Modules linked in:
CPU: 1 PID: 6540 Comm: syz-executor.0 Not tainted 5.15.0-rc2-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:devlink_nl_region_notify+0x184/0x1e0 net/core/devlink.c:5158
Code: 38 41 b8 c0 0c 00 00 31 d2 48 89 ee 4c 89 e7 e8 72 1a 26 00 48 83 c4 08 5b 5d 41 5c 41 5d 41 5e e9 01 bd 41 fa e8 fc bc 41 fa <0f> 0b e9 f7 fe ff ff e8 f0 bc 41 fa 0f 0b eb da 4c 89 e7 e8 c4 18
RSP: 0018:ffffc90002d6f658 EFLAGS: 00010293
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
RDX: ffff88801f08d580 RSI: ffffffff87344e94 RDI: 0000000000000003
RBP: ffff88801ee42100 R08: 0000000000000000 R09: 0000000000000000
R10: ffffffff87344d8a R11: 0000000000000000 R12: ffff88801c1dc000
R13: 0000000000000000 R14: 000000000000002c R15: ffff88801c1dc070
FS: 0000555555e8e400(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055dd7c590310 CR3: 0000000069a09000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
devlink_region_create+0x39f/0x4c0 net/core/devlink.c:10327
nsim_dev_dummy_region_init drivers/net/netdevsim/dev.c:481 [inline]
nsim_dev_probe+0x5f6/0x1150 drivers/net/netdevsim/dev.c:1479
call_driver_probe drivers/base/dd.c:517 [inline]
really_probe+0x245/0xcc0 drivers/base/dd.c:596
__driver_probe_device+0x338/0x4d0 drivers/base/dd.c:751
driver_probe_device+0x4c/0x1a0 drivers/base/dd.c:781
__device_attach_driver+0x20b/0x2f0 drivers/base/dd.c:898
bus_for_each_drv+0x15f/0x1e0 drivers/base/bus.c:427
__device_attach+0x228/0x4a0 drivers/base/dd.c:969
bus_probe_device+0x1e4/0x290 drivers/base/bus.c:487
device_add+0xc35/0x21b0 drivers/base/core.c:3359
nsim_bus_dev_new drivers/net/netdevsim/bus.c:435 [inline]
new_device_store+0x48b/0x770 drivers/net/netdevsim/bus.c:302
bus_attr_store+0x72/0xa0 drivers/base/bus.c:122
sysfs_kf_write+0x110/0x160 fs/sysfs/file.c:139
kernfs_fop_write_iter+0x342/0x500 fs/kernfs/file.c:296
call_write_iter include/linux/fs.h:2163 [inline]
new_sync_write+0x429/0x660 fs/read_write.c:507
vfs_write+0x7cf/0xae0 fs/read_write.c:594
ksys_write+0x12d/0x250 fs/read_write.c:647
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7f328409d3ef
Code: 89 54 24 18 48 89 74 24 10 89 7c 24 08 e8 99 fd ff ff 48 8b 54 24 18 48 8b 74 24 10 41 89 c0 8b 7c 24 08 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 31 44 89 c7 48 89 44 24 08 e8 cc fd ff ff 48
RSP: 002b:00007ffdc6851140 EFLAGS: 00000293 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007f328409d3ef
RDX: 0000000000000003 RSI: 00007ffdc6851190 RDI: 0000000000000004
RBP: 0000000000000004 R08: 0000000000000000 R09: 00007ffdc68510e0
R10: 0000000000000000 R11: 0000000000000293 R12: 00007f3284144971
R13: 00007ffdc6851190 R14: 0000000000000000 R15: 00007ffdc6851860
05:42PM
>
> msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
> if (!msg)
> @@ -1078,9 +1084,8 @@ static void devlink_rate_notify(struct devlink_rate *devlink_rate,
> return;
> }
>
> - genlmsg_multicast_netns(&devlink_nl_family,
> - devlink_net(devlink_rate->devlink), msg, 0,
> - DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
> + genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), msg,
> + 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
> }
>
> static int devlink_nl_cmd_rate_get_dumpit(struct sk_buff *msg,
> @@ -4150,6 +4155,7 @@ static void __devlink_flash_update_notify(struct devlink *devlink,
> WARN_ON(cmd != DEVLINK_CMD_FLASH_UPDATE &&
> cmd != DEVLINK_CMD_FLASH_UPDATE_END &&
> cmd != DEVLINK_CMD_FLASH_UPDATE_STATUS);
> + WARN_ON(!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED));
>
> msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
> if (!msg)
> @@ -5145,17 +5151,18 @@ static void devlink_nl_region_notify(struct devlink_region *region,
> struct devlink_snapshot *snapshot,
> enum devlink_command cmd)
> {
> + struct devlink *devlink = region->devlink;
> struct sk_buff *msg;
>
> WARN_ON(cmd != DEVLINK_CMD_REGION_NEW && cmd != DEVLINK_CMD_REGION_DEL);
> + WARN_ON(!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED));
>
> msg = devlink_nl_region_notify_build(region, snapshot, cmd, 0, 0);
> if (IS_ERR(msg))
> return;
>
> - genlmsg_multicast_netns(&devlink_nl_family,
> - devlink_net(region->devlink), msg, 0,
> - DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
> + genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), msg,
> + 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
> }
>
> /**
> @@ -6920,10 +6927,12 @@ devlink_nl_health_reporter_fill(struct sk_buff *msg,
> static void devlink_recover_notify(struct devlink_health_reporter *reporter,
> enum devlink_command cmd)
> {
> + struct devlink *devlink = reporter->devlink;
> struct sk_buff *msg;
> int err;
>
> WARN_ON(cmd != DEVLINK_CMD_HEALTH_REPORTER_RECOVER);
> + WARN_ON(!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED));
>
> msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
> if (!msg)
> @@ -6935,9 +6944,8 @@ static void devlink_recover_notify(struct devlink_health_reporter *reporter,
> return;
> }
>
> - genlmsg_multicast_netns(&devlink_nl_family,
> - devlink_net(reporter->devlink),
> - msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
> + genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), msg,
> + 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
> }
>
> void
> @@ -8955,6 +8963,68 @@ struct devlink *devlink_alloc_ns(const struct devlink_ops *ops,
> }
> EXPORT_SYMBOL_GPL(devlink_alloc_ns);
>
> +static void
> +devlink_trap_policer_notify(struct devlink *devlink,
> + const struct devlink_trap_policer_item *policer_item,
> + enum devlink_command cmd);
> +static void
> +devlink_trap_group_notify(struct devlink *devlink,
> + const struct devlink_trap_group_item *group_item,
> + enum devlink_command cmd);
> +static void devlink_trap_notify(struct devlink *devlink,
> + const struct devlink_trap_item *trap_item,
> + enum devlink_command cmd);
> +
> +static void devlink_notify_register(struct devlink *devlink)
> +{
> + struct devlink_trap_policer_item *policer_item;
> + struct devlink_trap_group_item *group_item;
> + struct devlink_trap_item *trap_item;
> + struct devlink_port *devlink_port;
> +
> + devlink_notify(devlink, DEVLINK_CMD_NEW);
> + list_for_each_entry(devlink_port, &devlink->port_list, list)
> + devlink_port_notify(devlink_port, DEVLINK_CMD_PORT_NEW);
> +
> + list_for_each_entry(policer_item, &devlink->trap_policer_list, list)
> + devlink_trap_policer_notify(devlink, policer_item,
> + DEVLINK_CMD_TRAP_POLICER_NEW);
> +
> + list_for_each_entry(group_item, &devlink->trap_group_list, list)
> + devlink_trap_group_notify(devlink, group_item,
> + DEVLINK_CMD_TRAP_GROUP_NEW);
> +
> + list_for_each_entry(trap_item, &devlink->trap_list, list)
> + devlink_trap_notify(devlink, trap_item, DEVLINK_CMD_TRAP_NEW);
> +
> + devlink_params_publish(devlink);
> +}
> +
> +static void devlink_notify_unregister(struct devlink *devlink)
> +{
> + struct devlink_trap_policer_item *policer_item;
> + struct devlink_trap_group_item *group_item;
> + struct devlink_trap_item *trap_item;
> + struct devlink_port *devlink_port;
> +
> + devlink_params_unpublish(devlink);
> +
> + list_for_each_entry_reverse(trap_item, &devlink->trap_list, list)
> + devlink_trap_notify(devlink, trap_item, DEVLINK_CMD_TRAP_DEL);
> +
> + list_for_each_entry_reverse(group_item, &devlink->trap_group_list, list)
> + devlink_trap_group_notify(devlink, group_item,
> + DEVLINK_CMD_TRAP_GROUP_DEL);
> + list_for_each_entry_reverse(policer_item, &devlink->trap_policer_list,
> + list)
> + devlink_trap_policer_notify(devlink, policer_item,
> + DEVLINK_CMD_TRAP_POLICER_DEL);
> +
> + list_for_each_entry_reverse(devlink_port, &devlink->port_list, list)
> + devlink_port_notify(devlink_port, DEVLINK_CMD_PORT_DEL);
> + devlink_notify(devlink, DEVLINK_CMD_DEL);
> +}
> +
> /**
> * devlink_register - Register devlink instance
> *
> @@ -8964,7 +9034,7 @@ void devlink_register(struct devlink *devlink)
> {
> mutex_lock(&devlink_mutex);
> xa_set_mark(&devlinks, devlink->index, DEVLINK_REGISTERED);
> - devlink_notify(devlink, DEVLINK_CMD_NEW);
> + devlink_notify_register(devlink);
> mutex_unlock(&devlink_mutex);
> }
> EXPORT_SYMBOL_GPL(devlink_register);
> @@ -8982,7 +9052,7 @@ void devlink_unregister(struct devlink *devlink)
> mutex_lock(&devlink_mutex);
> WARN_ON(devlink_reload_supported(devlink->ops) &&
> devlink->reload_enabled);
> - devlink_notify(devlink, DEVLINK_CMD_DEL);
> + devlink_notify_unregister(devlink);
> xa_clear_mark(&devlinks, devlink->index, DEVLINK_REGISTERED);
> mutex_unlock(&devlink_mutex);
> }
> @@ -10086,6 +10156,9 @@ void devlink_params_publish(struct devlink *devlink)
> {
> struct devlink_param_item *param_item;
>
> + if (!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED))
> + return;
> +
> list_for_each_entry(param_item, &devlink->param_list, list) {
> if (param_item->published)
> continue;
> @@ -10631,6 +10704,8 @@ devlink_trap_group_notify(struct devlink *devlink,
>
> WARN_ON_ONCE(cmd != DEVLINK_CMD_TRAP_GROUP_NEW &&
> cmd != DEVLINK_CMD_TRAP_GROUP_DEL);
> + if (!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED))
> + return;
>
> msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
> if (!msg)
> @@ -10672,6 +10747,8 @@ static void devlink_trap_notify(struct devlink *devlink,
>
> WARN_ON_ONCE(cmd != DEVLINK_CMD_TRAP_NEW &&
> cmd != DEVLINK_CMD_TRAP_DEL);
> + if (!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED))
> + return;
>
> msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
> if (!msg)
> @@ -11053,6 +11130,8 @@ devlink_trap_policer_notify(struct devlink *devlink,
>
> WARN_ON_ONCE(cmd != DEVLINK_CMD_TRAP_POLICER_NEW &&
> cmd != DEVLINK_CMD_TRAP_POLICER_DEL);
> + if (!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED))
> + return;
>
> msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
> if (!msg)
>
next prev parent reply other threads:[~2021-09-28 2:49 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 11:22 [PATCH net-next v1 00/21] Move devlink_register to be last devlink command Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 01/21] devlink: Notify users when objects are accessible Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-28 2:49 ` Eric Dumazet [this message]
2021-09-28 2:49 ` Eric Dumazet
2021-09-28 7:34 ` Leon Romanovsky
2021-09-28 7:34 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 02/21] bnxt_en: Register devlink instance at the end devlink configuration Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 03/21] liquidio: Overcome missing device lock protection in init/remove flows Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 04/21] dpaa2-eth: Register devlink instance at the end of probe Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 05/21] net: hinic: Open device for the user access when it is ready Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 06/21] ice: Open devlink when device " Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-27 19:47 ` Jesse Brandeburg
2021-09-27 19:47 ` [Intel-wired-lan] " Jesse Brandeburg
2021-09-25 11:22 ` [PATCH net-next v1 07/21] octeontx2: Move devlink registration to be last devlink command Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 08/21] net/prestera: Split devlink and traps registrations to separate routines Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 09/21] net/mlx4: Move devlink_register to be the last initialization command Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 10/21] net/mlx5: Accept devlink user input after driver initialization complete Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 11/21] mlxsw: core: Register devlink instance last Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-26 14:56 ` Ido Schimmel
2021-09-26 14:56 ` [Intel-wired-lan] " Ido Schimmel
2021-09-26 14:56 ` Ido Schimmel
2021-09-25 11:22 ` [PATCH net-next v1 12/21] net: mscc: ocelot: delay devlink registration to the end Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 13/21] nfp: Move delink_register to be last command Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-27 8:39 ` Simon Horman
2021-09-27 8:39 ` [Intel-wired-lan] " Simon Horman
2021-09-27 11:53 ` Leon Romanovsky
2021-09-27 11:53 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-27 12:20 ` Simon Horman
2021-09-27 12:20 ` [Intel-wired-lan] " Simon Horman
2021-09-25 11:22 ` [PATCH net-next v1 14/21] ionic: Move devlink registration to be last devlink command Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-27 16:07 ` Shannon Nelson
2021-09-27 16:07 ` [Intel-wired-lan] " Shannon Nelson
2021-09-25 11:22 ` [PATCH net-next v1 15/21] qed: " Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 16/21] net: ethernet: ti: " Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 17/21] netdevsim: " Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 18/21] net: wwan: iosm: Move devlink_register " Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 19/21] ptp: ocp: Move devlink registration " Leon Romanovsky
2021-09-25 11:22 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-25 11:23 ` [PATCH net-next v1 20/21] staging: qlge: " Leon Romanovsky
2021-09-25 11:23 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-25 11:23 ` [PATCH net-next v1 21/21] net: dsa: " Leon Romanovsky
2021-09-25 11:23 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-29 13:02 ` Vladimir Oltean
2021-09-29 13:02 ` [Intel-wired-lan] " Vladimir Oltean
2021-09-29 13:07 ` Leon Romanovsky
2021-09-29 13:07 ` [Intel-wired-lan] " Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97c1ba9d-52b9-5689-19ab-ad4a82e55ae2@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=GR-everest-linux-l2@marvell.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=aelior@marvell.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=claudiu.manoil@nxp.com \
--cc=coiby.xu@gmail.com \
--cc=davem@davemloft.net \
--cc=dchickles@marvell.com \
--cc=drivers@pensando.io \
--cc=f.fainelli@gmail.com \
--cc=fmanlunas@marvell.com \
--cc=gakula@marvell.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkelam@marvell.com \
--cc=idosch@nvidia.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=ioana.ciornei@nxp.com \
--cc=jerinj@marvell.com \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@nvidia.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linuxwwan@intel.com \
--cc=loic.poulain@linaro.org \
--cc=luobin9@huawei.com \
--cc=m.chetan.kumar@intel.com \
--cc=manishc@marvell.com \
--cc=michael.chan@broadcom.com \
--cc=michaelgur@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=richardcochran@gmail.com \
--cc=ryazanov.s.a@gmail.com \
--cc=saeedm@nvidia.com \
--cc=sbhatta@marvell.com \
--cc=sburla@marvell.com \
--cc=sgoutham@marvell.com \
--cc=simon.horman@corigine.com \
--cc=snelson@pensando.io \
--cc=tariqt@nvidia.com \
--cc=tchornyi@marvell.com \
--cc=vivien.didelot@gmail.com \
--cc=vkochan@marvell.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.