[MPTCP] Re: [PATCH] mptcp: Use sk_family field in the mptcp_sock for address family.

[MPTCP] Re: [PATCH] mptcp: Use sk_family field in the mptcp_sock for address family.

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1847 bytes --]

Hi Peter, Paolo, Mat,

On 05/11/2019 22:57, Mat Martineau wrote:
> 
> On Tue, 5 Nov 2019, Paolo Abeni wrote:
> 
>> On Mon, 2019-11-04 at 21:26 -0800, Peter Krystad wrote:
>>> It was not necessary to add a family field to mptcp_sock as it is
>>> a wrapper around a struct sock, and sk_family is set correctly when
>>> the msk is created as a result of a socket() call.
>>>
>>> squashto: Associate MPTCP context with TCP socket
>>>           mptcp: Implement basic path manager
>>>
>>> Signed-off-by: Peter Krystad <peter.krystad(a)linux.intel.com>
>>
>> LGTM, nice cleanup, thanks!
>>
>> It's unclear to me if I should update patchwork status, too ("Under
>> review"? would that help?)
>>
> 
> Looks good to me, too.

Thank you for the patch and the review!

- 7c4096766c23: "squashed" part 1 in "mptcp: Associate MPTCP context 
with TCP socket"
- already has the signed-off
- f9b323be35cf: conflict in 
t/mptcp-Handle-MP_CAPABLE-options-for-outgoing-connections
- ad05f6b594bc: conflict in t/mptcp-Add-key-generation-and-token-tree
- 94ddaeb75bd3: conflict in t/mptcp-Implement-MPTCP-receive-path
- d1db9d0195b3: conflict in 
t/mptcp-Add-handling-of-outgoing-MP_JOIN-requests
- 55b5be5a8eea: conflict in 
t/mptcp-implement-and-use-MPTCP-level-retransmission
- b8de8670bd8c: "squashed" part 2 in "mptcp: Implement basic path manager"
- 3b6112deb337..1b8d767c5872: result

> For handling patchwork status, I went to the upcoming meeting page to 
> create a proposal - and found that Matthieu has already done it :)

:)
Yes we can talk about that tomorrow.

I will apply the other patches tomorrow.

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

[MPTCP] Re: [PATCH] mptcp: Use sk_family field in the mptcp_sock for address family.

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]


On Tue, 5 Nov 2019, Paolo Abeni wrote:

> On Mon, 2019-11-04 at 21:26 -0800, Peter Krystad wrote:
>> It was not necessary to add a family field to mptcp_sock as it is
>> a wrapper around a struct sock, and sk_family is set correctly when
>> the msk is created as a result of a socket() call.
>>
>> squashto: Associate MPTCP context with TCP socket
>>           mptcp: Implement basic path manager
>>
>> Signed-off-by: Peter Krystad <peter.krystad(a)linux.intel.com>
>
> LGTM, nice cleanup, thanks!
>
> It's unclear to me if I should update patchwork status, too ("Under
> review"? would that help?)
>

Looks good to me, too.

For handling patchwork status, I went to the upcoming meeting page to 
create a proposal - and found that Matthieu has already done it :)

--
Mat Martineau
Intel

[MPTCP] Re: [PATCH] mptcp: Use sk_family field in the mptcp_sock for address family.

[Paolo Abeni]

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

On Mon, 2019-11-04 at 21:26 -0800, Peter Krystad wrote:
> It was not necessary to add a family field to mptcp_sock as it is
> a wrapper around a struct sock, and sk_family is set correctly when
> the msk is created as a result of a socket() call.
> 
> squashto: Associate MPTCP context with TCP socket
>           mptcp: Implement basic path manager
> 
> Signed-off-by: Peter Krystad <peter.krystad(a)linux.intel.com>

LGTM, nice cleanup, thanks!

It's unclear to me if I should update patchwork status, too ("Under
review"? would that help?)

Paolo