[PATCH 1/1] handle werid mbm card network name

[PATCH 1/1] handle werid mbm card network name

[Martin Xu]

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]

---
 plugins/udev.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/plugins/udev.c b/plugins/udev.c
index c2e9c41..345613b 100644
--- a/plugins/udev.c
+++ b/plugins/udev.c
@@ -120,7 +120,8 @@ static void add_mbm(struct ofono_modem *modem,
 		devnode = udev_device_get_devnode(udev_device);
 		ofono_modem_set_string(modem, GPS_DEVICE, devnode);
 	} else if (g_str_has_suffix(desc, "Minicard Network Adapter") ||
-			g_str_has_suffix(desc, "Broadband Network Adapter")) {
+			g_str_has_suffix(desc, "Broadband Network Adapter") ||
+				g_str_has_suffix(desc, "Minicard NetworkAdapter")) {
 		devnode = udev_device_get_property_value(udev_device,
 								"INTERFACE");
 		ofono_modem_set_string(modem, NETWORK_INTERFACE, devnode);
-- 
1.6.1.3

Re: [PATCH 1/1] handle werid mbm card network name

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

Hi Martin,

>  plugins/udev.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/plugins/udev.c b/plugins/udev.c
> index c2e9c41..345613b 100644
> --- a/plugins/udev.c
> +++ b/plugins/udev.c
> @@ -120,7 +120,8 @@ static void add_mbm(struct ofono_modem *modem,
>  		devnode = udev_device_get_devnode(udev_device);
>  		ofono_modem_set_string(modem, GPS_DEVICE, devnode);
>  	} else if (g_str_has_suffix(desc, "Minicard Network Adapter") ||
> -			g_str_has_suffix(desc, "Broadband Network Adapter")) {
> +			g_str_has_suffix(desc, "Broadband Network Adapter") ||
> +				g_str_has_suffix(desc, "Minicard NetworkAdapter")) {
>  		devnode = udev_device_get_property_value(udev_device,
>  								"INTERFACE");
>  		ofono_modem_set_string(modem, NETWORK_INTERFACE, devnode);

are you serious? They forgot the space in one of their USB interface
descriptions.

Do me a favor and just add it between these two and don't bother with
the extra indentation. Two are enough.

Regards

Marcel

RE: [PATCH 1/1] handle werid mbm card network name

[Xu, Martin]

[-- Attachment #1: Type: text/plain, Size: 1726 bytes --]

> -----Original Message-----
> From: ofono-bounces(a)ofono.org [mailto:ofono-bounces(a)ofono.org] On Behalf
> Of Marcel Holtmann
> Sent: Wednesday, November 04, 2009 1:55 PM
> To: ofono(a)ofono.org
> Subject: Re: [PATCH 1/1] handle werid mbm card network name
> 
> Hi Martin,
> 
> >  plugins/udev.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/plugins/udev.c b/plugins/udev.c
> > index c2e9c41..345613b 100644
> > --- a/plugins/udev.c
> > +++ b/plugins/udev.c
> > @@ -120,7 +120,8 @@ static void add_mbm(struct ofono_modem *modem,
> >  		devnode = udev_device_get_devnode(udev_device);
> >  		ofono_modem_set_string(modem, GPS_DEVICE, devnode);
> >  	} else if (g_str_has_suffix(desc, "Minicard Network Adapter") ||
> > -			g_str_has_suffix(desc, "Broadband Network Adapter")) {
> > +			g_str_has_suffix(desc, "Broadband Network Adapter") ||
> > +				g_str_has_suffix(desc, "Minicard NetworkAdapter")) {
> >  		devnode = udev_device_get_property_value(udev_device,
> >  								"INTERFACE");
> >  		ofono_modem_set_string(modem, NETWORK_INTERFACE, devnode);
> 
> are you serious? They forgot the space in one of their USB interface
> descriptions.
Of course, I am serious.
It waste me almost half of morning to debug the weird issue. 
> Do me a favor and just add it between these two and don't bother with
> the extra indentation. Two are enough.
I cannot understand what your meaning exactly. Anyway I will send the modified patch, if it is not what you want, just replace it. ;-)
> Regards
> 
> Marcel
> 
> 
> _______________________________________________
> ofono mailing list
> ofono(a)ofono.org
> http://lists.ofono.org/listinfo/ofono