* [PATCH] drm: rcar-du: lvds: use dev_err_probe()
@ 2021-06-23 3:06 Laurent Pinchart
2021-06-23 8:48 ` Kieran Bingham
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Pinchart @ 2021-06-23 3:06 UTC (permalink / raw)
To: dri-devel; +Cc: linux-renesas-soc, Kieran Bingham
Simplify error handling by using the dev_err_probe() function.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/gpu/drm/rcar-du/rcar_lvds.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
index 5909173b26eb..165be31c4c45 100644
--- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
+++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
@@ -839,9 +839,8 @@ static struct clk *rcar_lvds_get_clock(struct rcar_lvds *lvds, const char *name,
if (PTR_ERR(clk) == -ENOENT && optional)
return NULL;
- if (PTR_ERR(clk) != -EPROBE_DEFER)
- dev_err(lvds->dev, "failed to get %s clock\n",
- name ? name : "module");
+ dev_err_probe(lvds->dev, PTR_ERR(clk), "failed to get %s clock\n",
+ name ? name : "module");
return clk;
}
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: rcar-du: lvds: use dev_err_probe()
2021-06-23 3:06 [PATCH] drm: rcar-du: lvds: use dev_err_probe() Laurent Pinchart
@ 2021-06-23 8:48 ` Kieran Bingham
0 siblings, 0 replies; 2+ messages in thread
From: Kieran Bingham @ 2021-06-23 8:48 UTC (permalink / raw)
To: Laurent Pinchart, dri-devel; +Cc: linux-renesas-soc
Hi Laurent,
On 23/06/2021 04:06, Laurent Pinchart wrote:
> Simplify error handling by using the dev_err_probe() function.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_lvds.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> index 5909173b26eb..165be31c4c45 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> @@ -839,9 +839,8 @@ static struct clk *rcar_lvds_get_clock(struct rcar_lvds *lvds, const char *name,
> if (PTR_ERR(clk) == -ENOENT && optional)
> return NULL;
>
> - if (PTR_ERR(clk) != -EPROBE_DEFER)
> - dev_err(lvds->dev, "failed to get %s clock\n",
> - name ? name : "module");
> + dev_err_probe(lvds->dev, PTR_ERR(clk), "failed to get %s clock\n",
> + name ? name : "module");
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> return clk;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-23 8:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23 3:06 [PATCH] drm: rcar-du: lvds: use dev_err_probe() Laurent Pinchart
2021-06-23 8:48 ` Kieran Bingham
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.