From: Alan Jenkins <sourcejedi.lkml@googlemail.com> To: Steven Rostedt <rostedt@goodmis.org> Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@linux-foundation.org>, Linus Torvalds <torvalds@linux-foundation.org>, Peter Zijlstra <peterz@infradead.org>, Thomas Gleixner <tglx@linutronix.de>, Theodore Tso <tytso@mit.edu>, Arnaldo Carvalho de Melo <acme@redhat.com>, zippel@linux-m68k.org, linux-kbuild@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org> Subject: Re: [PATCH 3/7] kconfig: enable CONFIG_IKCONFIG from streamline_config.pl Date: Thu, 30 Apr 2009 22:51:32 +0100 [thread overview] Message-ID: <9b2b86520904301451v1d77589l7ee48217fb64e567@mail.gmail.com> (raw) In-Reply-To: <20090430185219.656122641@goodmis.org> On 4/30/09, Steven Rostedt <rostedt@goodmis.org> wrote: > From: Steven Rostedt <srostedt@redhat.com> > > Ingo Molnar suggested that the streamline_config.pl should enable > CONFIG_IKCONFIG to keep the current config in the kernel. > Then we can use scripts/extract-ikconfig to find the current > modules. > > This patch changes streamline_config.pl to check if CONFIG_IKCONFIG > is not set, and if it is not, it enables it to be a module. > > [ Impact: make current config options easier to find ] > > Reported-by: Ingo Molnar <mingo@elte.hu> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org> > --- > scripts/kconfig/streamline_config.pl | 33 > +++++++++++++++++++++++---------- > 1 files changed, 23 insertions(+), 10 deletions(-) > > diff --git a/scripts/kconfig/streamline_config.pl > b/scripts/kconfig/streamline_config.pl > index caac952..2334641 100644 > --- a/scripts/kconfig/streamline_config.pl > +++ b/scripts/kconfig/streamline_config.pl > @@ -256,18 +256,31 @@ my %setconfigs; > # Finally, read the .config file and turn off any module enabled that > # we could not find a reason to keep enabled. > while(<CIN>) { > - if (/^(CONFIG.*)=(m|y)/) { > - if (defined($configs{$1})) { > - $setconfigs{$1} = $2; > - print; > - } elsif ($2 eq "m") { > - print "# $1 is not set\n"; > - } else { > - print; > - } > + > + if (/CONFIG_IKCONFIG/) { > + if (/# CONFIG_IKCONFIG is not set/) { > + # enable IKCONFIG at least as a module > + print "CONFIG_IKCONFIG=m\n"; > + # don't ask about PROC > + print "# CONFIG_IKCONFIG is not set\n"; I assume the second one should be CONFIG_IKCONFIG_PROC :-). > + } else { > + print; > + } > + next; > + } > + > + if (/^(CONFIG.*)=(m|y)/) { > + if (defined($configs{$1})) { > + $setconfigs{$1} = $2; > + print; > + } elsif ($2 eq "m") { > + print "# $1 is not set\n"; > } else { > - print; > + print; > } > + } else { > + print; > + } Maybe it would be cleaner make the two "if" blocks the same; i.e. do this instead: + next; + } + + print; > } > close(CIN); >
WARNING: multiple messages have this Message-ID (diff)
From: Alan Jenkins <sourcejedi.lkml@googlemail.com> To: Steven Rostedt <rostedt@goodmis.org> Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@linux-foundation.org>, Linus Torvalds <torvalds@linux-foundation.org>, Peter Zijlstra <peterz@infradead.org>, Thomas Gleixner <tglx@linutronix.de>, Theodore Tso <tytso@mit.edu>, Arnaldo Carvalho de Melo <acme@redhat.com>, zippel@linux-m68k.org, linux-kbuild@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org> Subject: Re: [PATCH 3/7] kconfig: enable CONFIG_IKCONFIG from streamline_config.pl Date: Thu, 30 Apr 2009 22:51:32 +0100 [thread overview] Message-ID: <9b2b86520904301451v1d77589l7ee48217fb64e567@mail.gmail.com> (raw) In-Reply-To: <20090430185219.656122641@goodmis.org> On 4/30/09, Steven Rostedt <rostedt@goodmis.org> wrote: > From: Steven Rostedt <srostedt@redhat.com> > > Ingo Molnar suggested that the streamline_config.pl should enable > CONFIG_IKCONFIG to keep the current config in the kernel. > Then we can use scripts/extract-ikconfig to find the current > modules. > > This patch changes streamline_config.pl to check if CONFIG_IKCONFIG > is not set, and if it is not, it enables it to be a module. > > [ Impact: make current config options easier to find ] > > Reported-by: Ingo Molnar <mingo@elte.hu> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org> > --- > scripts/kconfig/streamline_config.pl | 33 > +++++++++++++++++++++++---------- > 1 files changed, 23 insertions(+), 10 deletions(-) > > diff --git a/scripts/kconfig/streamline_config.pl > b/scripts/kconfig/streamline_config.pl > index caac952..2334641 100644 > --- a/scripts/kconfig/streamline_config.pl > +++ b/scripts/kconfig/streamline_config.pl > @@ -256,18 +256,31 @@ my %setconfigs; > # Finally, read the .config file and turn off any module enabled that > # we could not find a reason to keep enabled. > while(<CIN>) { > - if (/^(CONFIG.*)=(m|y)/) { > - if (defined($configs{$1})) { > - $setconfigs{$1} = $2; > - print; > - } elsif ($2 eq "m") { > - print "# $1 is not set\n"; > - } else { > - print; > - } > + > + if (/CONFIG_IKCONFIG/) { > + if (/# CONFIG_IKCONFIG is not set/) { > + # enable IKCONFIG at least as a module > + print "CONFIG_IKCONFIG=m\n"; > + # don't ask about PROC > + print "# CONFIG_IKCONFIG is not set\n"; I assume the second one should be CONFIG_IKCONFIG_PROC :-). > + } else { > + print; > + } > + next; > + } > + > + if (/^(CONFIG.*)=(m|y)/) { > + if (defined($configs{$1})) { > + $setconfigs{$1} = $2; > + print; > + } elsif ($2 eq "m") { > + print "# $1 is not set\n"; > } else { > - print; > + print; > } > + } else { > + print; > + } Maybe it would be cleaner make the two "if" blocks the same; i.e. do this instead: + next; + } + + print; > } > close(CIN); >
next prev parent reply other threads:[~2009-04-30 21:51 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-04-30 18:50 [PATCH 0/7] kconfig: more featured minimum module configs Steven Rostedt 2009-04-30 18:50 ` [PATCH 1/7] kconfig: streamline_config.pl do not stop with no depends Steven Rostedt 2009-04-30 18:50 ` [PATCH 2/7] kconfig: do not warn about modules built in Steven Rostedt 2009-04-30 18:50 ` [PATCH 3/7] kconfig: enable CONFIG_IKCONFIG from streamline_config.pl Steven Rostedt 2009-04-30 21:51 ` Alan Jenkins [this message] 2009-04-30 21:51 ` Alan Jenkins 2009-04-30 22:53 ` Steven Rostedt 2009-04-30 22:53 ` Steven Rostedt 2009-04-30 18:50 ` [PATCH 4/7] kconfig: add check if end exists in extract-ikconfig Steven Rostedt 2009-04-30 18:50 ` [PATCH 5/7] kconfig: have extract-ikconfig read ELF files Steven Rostedt 2009-04-30 18:50 ` [PATCH 6/7] kconfig: keep config.gz around even if CONFIG_IKCONFIG_PROC is not set Steven Rostedt 2009-04-30 18:50 ` [PATCH 7/7] kconfig: search for a config to base the local(mod|yes)config on Steven Rostedt 2009-04-30 22:04 ` Alan Jenkins 2009-04-30 22:04 ` Alan Jenkins 2009-04-30 22:54 ` Steven Rostedt 2009-04-30 22:54 ` Steven Rostedt 2009-05-04 12:15 ` Andi Kleen 2009-05-04 12:28 ` Peter Zijlstra 2009-05-04 14:46 ` Steven Rostedt 2009-05-04 14:59 ` Andi Kleen 2009-04-30 19:10 ` [PATCH 0/7] kconfig: more featured minimum module configs Ingo Molnar 2009-04-30 22:55 ` Steven Rostedt 2009-05-01 12:01 ` Ingo Molnar 2009-05-01 23:27 ` Steven Rostedt 2009-05-06 12:15 ` Ingo Molnar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9b2b86520904301451v1d77589l7ee48217fb64e567@mail.gmail.com \ --to=sourcejedi.lkml@googlemail.com \ --cc=acme@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@elte.hu \ --cc=peterz@infradead.org \ --cc=rostedt@goodmis.org \ --cc=sam@ravnborg.org \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ --cc=tytso@mit.edu \ --cc=zippel@linux-m68k.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.