From: Prakash Gupta <guptap@codeaurora.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mhocko@suse.com, vbabka@suse.cz, will.deacon@arm.com,
catalin.marinas@arm.com, iamjoonsoo.kim@lge.com,
rmk+kernel@arm.linux.org.uk, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 1/2] arm64: stacktrace: avoid listing stacktrace functions in stacktrace
Date: Thu, 31 Aug 2017 11:58:31 +0530 [thread overview]
Message-ID: <9ce9206f-cffa-99c5-2a34-e5988bd0b603@codeaurora.org> (raw)
In-Reply-To: <20170830132828.0bf9b9bc64f51362a64a6694@linux-foundation.org>
On 8/31/2017 1:58 AM, Andrew Morton wrote:
> On Wed, 30 Aug 2017 13:02:22 +0530 Prakash Gupta <guptap@codeaurora.org> wrote:
>
>> The stacktraces always begin as follows:
>>
>> [<c00117b4>] save_stack_trace_tsk+0x0/0x98
>> [<c0011870>] save_stack_trace+0x24/0x28
>> ...
>>
>> This is because the stack trace code includes the stack frames for itself.
>> This is incorrect behaviour, and also leads to "skip" doing the wrong thing
>> (which is the number of stack frames to avoid recording.)
>>
>> Perversely, it does the right thing when passed a non-current thread. Fix
>> this by ensuring that we have a known constant number of frames above the
>> main stack trace function, and always skip these.
>>
>> This was fixed for arch arm by Commit 3683f44c42e9 ("ARM: stacktrace: avoid
>> listing stacktrace functions in stacktrace")
>
> I can take this (with acks, please?)
>
> 3683f44c42e9 has a cc:stable but your patch does not. Should it?
>
My bad, it should be copied to stable as well.
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: Prakash Gupta <guptap@codeaurora.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mhocko@suse.com, vbabka@suse.cz, will.deacon@arm.com,
catalin.marinas@arm.com, iamjoonsoo.kim@lge.com,
rmk+kernel@arm.linux.org.uk, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 1/2] arm64: stacktrace: avoid listing stacktrace functions in stacktrace
Date: Thu, 31 Aug 2017 11:58:31 +0530 [thread overview]
Message-ID: <9ce9206f-cffa-99c5-2a34-e5988bd0b603@codeaurora.org> (raw)
In-Reply-To: <20170830132828.0bf9b9bc64f51362a64a6694@linux-foundation.org>
On 8/31/2017 1:58 AM, Andrew Morton wrote:
> On Wed, 30 Aug 2017 13:02:22 +0530 Prakash Gupta <guptap@codeaurora.org> wrote:
>
>> The stacktraces always begin as follows:
>>
>> [<c00117b4>] save_stack_trace_tsk+0x0/0x98
>> [<c0011870>] save_stack_trace+0x24/0x28
>> ...
>>
>> This is because the stack trace code includes the stack frames for itself.
>> This is incorrect behaviour, and also leads to "skip" doing the wrong thing
>> (which is the number of stack frames to avoid recording.)
>>
>> Perversely, it does the right thing when passed a non-current thread. Fix
>> this by ensuring that we have a known constant number of frames above the
>> main stack trace function, and always skip these.
>>
>> This was fixed for arch arm by Commit 3683f44c42e9 ("ARM: stacktrace: avoid
>> listing stacktrace functions in stacktrace")
>
> I can take this (with acks, please?)
>
> 3683f44c42e9 has a cc:stable but your patch does not. Should it?
>
My bad, it should be copied to stable as well.
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-08-31 6:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 7:32 [PATCH 1/2] arm64: stacktrace: avoid listing stacktrace functions in stacktrace Prakash Gupta
2017-08-30 7:32 ` Prakash Gupta
2017-08-30 7:32 ` [PATCH 2/2] mm, page_owner: Skip unnecessary stack_trace entries Prakash Gupta
2017-08-30 7:32 ` Prakash Gupta
2017-08-31 7:34 ` Vlastimil Babka
2017-08-31 7:34 ` Vlastimil Babka
2017-09-01 5:00 ` Prakash Gupta
2017-09-01 5:00 ` Prakash Gupta
2017-08-30 20:28 ` [PATCH 1/2] arm64: stacktrace: avoid listing stacktrace functions in stacktrace Andrew Morton
2017-08-30 20:28 ` Andrew Morton
2017-08-31 6:28 ` Prakash Gupta [this message]
2017-08-31 6:28 ` Prakash Gupta
2017-09-04 10:29 ` Catalin Marinas
2017-09-04 10:29 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ce9206f-cffa-99c5-2a34-e5988bd0b603@codeaurora.org \
--to=guptap@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=vbabka@suse.cz \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.