* bounce limit in mmc?
@ 2017-08-28 17:48 Christoph Hellwig
2017-08-30 6:14 ` Shawn Lin
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2017-08-28 17:48 UTC (permalink / raw)
To: linux-mmc
Hi all, any idea why the mmc driver defaults to bouncing highmem
pages if the device doesn't have a DMA mask? highmem is defined
different on different architectures or even based on config options,
so it seems like a very odd choice.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bounce limit in mmc?
2017-08-28 17:48 bounce limit in mmc? Christoph Hellwig
@ 2017-08-30 6:14 ` Shawn Lin
[not found] ` <CAG8K7gS7Lo2GL9ve7ze-huTT9ETNQMwdzjM6hb7_f8-GsSEF4A@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Lin @ 2017-08-30 6:14 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-mmc, shawn.lin
Hi Christoph,
On 2017/8/29 1:48, Christoph Hellwig wrote:
> Hi all, any idea why the mmc driver defaults to bouncing highmem
> pages if the device doesn't have a DMA mask? highmem is defined
> different on different architectures or even based on config options,
> so it seems like a very odd choice.
Not sure why mmc stack defaults to use BLK_BOUNCE_HIGH as it seems that
it has been there when mmc was added into linux.
I *guess* this is a copy-and-paste from other block drivers, especially
see drivers/memstick/core/ms_block.c which does actual the same thing.
And that raises another question that if mmc stack doesn't defaults to
boucing highmem pages but host drivers don't provide DMA mask either, so
what should we use for saftly limiting bouncing for DMA capable?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bounce limit in mmc?
[not found] ` <CAG8K7gS7Lo2GL9ve7ze-huTT9ETNQMwdzjM6hb7_f8-GsSEF4A@mail.gmail.com>
@ 2017-09-27 5:54 ` Pierre Ossman
0 siblings, 0 replies; 3+ messages in thread
From: Pierre Ossman @ 2017-09-27 5:54 UTC (permalink / raw)
To: Avri Altman, Shawn Lin; +Cc: Christoph Hellwig, linux-mmc
On 30/08/17 15:09, Avri Altman wrote:
> better ask the author - (mmc: bounce requests for simple hosts) and
> (mmc_block: bounce buffer highmem support).
>
Sorry for the late reply. This got lost in my inbox.
> On Wed, Aug 30, 2017 at 9:14 AM, Shawn Lin <shawn.lin@rock-chips.com> wrote:
>
>> Hi Christoph,
>>
>> On 2017/8/29 1:48, Christoph Hellwig wrote:
>>
>>> Hi all, any idea why the mmc driver defaults to bouncing highmem
>>> pages if the device doesn't have a DMA mask? highmem is defined
>>> different on different architectures or even based on config options,
>>> so it seems like a very odd choice.
>>>
>>
>> Not sure why mmc stack defaults to use BLK_BOUNCE_HIGH as it seems that
>> it has been there when mmc was added into linux.
>>
>> I *guess* this is a copy-and-paste from other block drivers, especially
>> see drivers/memstick/core/ms_block.c which does actual the same thing.
>>
>> And that raises another question that if mmc stack doesn't defaults to
>> boucing highmem pages but host drivers don't provide DMA mask either, so
>> what should we use for saftly limiting bouncing for DMA capable?
>>
I'm afraid it's way too long ago, so I don't really remember. git blame
seems to suggest it has been there since before I took over though. RMK
was the one in charge before me.
The only thing I do remember is that the original bounce stuff was done
for the wbsd driver, which is a ISA bus device so it had to work around
the limitations of that system.
Regards
--
Pierre Ossman
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-27 6:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-28 17:48 bounce limit in mmc? Christoph Hellwig
2017-08-30 6:14 ` Shawn Lin
[not found] ` <CAG8K7gS7Lo2GL9ve7ze-huTT9ETNQMwdzjM6hb7_f8-GsSEF4A@mail.gmail.com>
2017-09-27 5:54 ` Pierre Ossman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.