Re: [PATCH 1/2] can: xilinx_can: skip error message on deferred probe - Marc Kleine-Budde

From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Srinivas Neeli <srinivas.neeli@xilinx.com>,
	wg@grandegger.com, davem@davemloft.net, michal.simek@xilinx.com,
	appanad@xilinx.com
Cc: netdev@vger.kernel.org,
	Venkatesh Yadav Abbarapu <venkatesh.abbarapu@xilinx.com>,
	linux-kernel@vger.kernel.org, linux-can@vger.kernel.org,
	nagasure@xilinx.com, git@xilinx.com,
	Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] can: xilinx_can: skip error message on deferred probe
Date: Fri, 22 Nov 2019 15:28:04 +0100	[thread overview]
Message-ID: <9f0f491d-74fe-296a-9636-1c0e14a5f77a@pengutronix.de> (raw)
In-Reply-To: <1574251865-19592-2-git-send-email-srinivas.neeli@xilinx.com>

[-- Attachment #1.1.1: Type: text/plain, Size: 1709 bytes --]

On 11/20/19 1:11 PM, Srinivas Neeli wrote:
> From: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@xilinx.com>
> 
> When can clock is provided from the clock wizard, clock wizard driver
       ^^^

The code looks like the "bus" clock is probed here, not the "can" clock.

> may not be available when can driver probes resulting to the error
> message "bus clock not found error".
> 
> As this error message is not very useful to the end user, skip printing
> in the case of deferred probe.
> 
> Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@xilinx.com>
> Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>  drivers/net/can/xilinx_can.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c
> index 4a96e2dd7d77..c5f05b994435 100644
> --- a/drivers/net/can/xilinx_can.c
> +++ b/drivers/net/can/xilinx_can.c
> @@ -1772,7 +1772,8 @@ static int xcan_probe(struct platform_device *pdev)
>  
>  	priv->bus_clk = devm_clk_get(&pdev->dev, devtype->bus_clk_name);
              ^^^^^^^
>  	if (IS_ERR(priv->bus_clk)) {
> -		dev_err(&pdev->dev, "bus clock not found\n");
> +		if (PTR_ERR(priv->bus_clk) != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "bus clock not found\n");
>  		ret = PTR_ERR(priv->bus_clk);
>  		goto err_free;
>  	}
> 

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel